fix: remove defensive coding

Author: chrisfalaska

src/auro-tail-group.js

@@ -1,6 +1,6 @@
 import AuroLibraryRuntimeUtils from "@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs";
 import { LitElement, html, nothing } from 'lit';
-import { MAX_TAILS_IN_GROUP, GROUPS_SIZES } from './constants';
+import { GROUPS_SIZES } from './constants';
 import groupStyleCss from './styles/auro-tail-group.scss';
 
 /**
@@ -69,17 +69,6 @@ export class AuroTailGroup extends LitElement {
     this.runtimeUtils = new AuroLibraryRuntimeUtils();
   }
 
-  /**
-   * Prevent shadow DOM creation for unsupported sizes.
-   * @protected
-   */
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  createRenderRoot() {
-    if (!GROUPS_SIZES.includes(this.size)) {
-      return this;
-    }
-    return super.createRenderRoot();
-  }
 
   connectedCallback() {
     super.connectedCallback();
@@ -102,31 +91,21 @@ export class AuroTailGroup extends LitElement {
   }
 
   /**
-   * Manages child tails - removes excess tails and updates sizes.
+   * Updates the size of child tails to match the group size.
    * @private
    */
   updateChildTails() {
     // Small delay to ensure slotted content is available
     setTimeout(() => {
-      const allChildren = Array.from(this.children);
-      const tails = allChildren.filter(isAuroTailElement);
-      
-      // If size is not supported, remove all child tails from light DOM.
       if (!GROUPS_SIZES.includes(this.size)) {
-        tails.forEach((tail) => {
-          tail.remove();
-        });
         return;
       }
 
-      // Remove excess tails from DOM completely.
-      tails.forEach((tail, index) => {
-        if (index >= MAX_TAILS_IN_GROUP) {
-          tail.remove();
-        } else {
-          // Update size for allowed tails
-          tail.size = this.size;
-        }
+      const allChildren = Array.from(this.children);
+      const tails = allChildren.filter(isAuroTailElement);
+
+      tails.forEach((tail) => {
+        tail.size = this.size;
       });
     }, 0);
   }

src/constants.js

@@ -16,9 +16,6 @@ export const BADGES_SIZES = ['md', 'lg', 'xl', '2xl'];
 // Sizes that should be used in groups
 export const GROUPS_SIZES = ['xs', 'sm', 'md', 'lg'];
 
-// Maximum number of tails allowed in a group
-export const MAX_TAILS_IN_GROUP = 2;
-
 // Default airline name (EN/i18n)
 export const DEFAULT_AIRLINE_NAME = 'Airline';
 

test/auro-tail-group.test.js

@@ -66,46 +66,6 @@ describe("auro-tail-group", () => {
     expect(tails[0].size).to.equal("md");
     expect(tails[1].size).to.equal("md");
   });
-
-
-  it("removes excess tails beyond MAX_TAILS_IN_GROUP", async () => {
-    const el = /** @type {AuroTailGroup} */ (await fixture(html`
-      <auro-tail-group>
-        <auro-tail tail="AS"></auro-tail>
-        <auro-tail tail="HA"></auro-tail>
-        <auro-tail tail="AA"></auro-tail>
-        <auro-tail tail="OA"></auro-tail>
-      </auro-tail-group>
-    `));
-    
-    // Wait for async updateChildTails
-    await new Promise(resolve => setTimeout(resolve, 10));
-    
-    const tails = el.querySelectorAll('auro-tail');
-    expect(tails.length).to.equal(2); // Only first 2 should remain
-  });
-
-  it("does not render shadow DOM for unsupported sizes", async () => {
-    const el = /** @type {AuroTailGroup} */ (await fixture(html`<auro-tail-group size="xl"></auro-tail-group>`));
-    // xl is not in GROUPS_SIZES, so no shadow DOM should be created
-    expect(el.shadowRoot).to.be.null;
-  });
-
-  it("removes all child tails for unsupported sizes", async () => {
-    const el = /** @type {AuroTailGroup} */ (await fixture(html`
-      <auro-tail-group size="xl">
-        <auro-tail tail="AS"></auro-tail>
-        <auro-tail tail="HA"></auro-tail>
-      </auro-tail-group>
-    `));
-    
-    // Wait for async updateChildTails
-    await new Promise(resolve => setTimeout(resolve, 10));
-    
-    const tails = el.querySelectorAll('auro-tail');
-    expect(tails.length).to.equal(0); // All should be removed
-  });
-
   it("updates child tails when size changes", async () => {
     const el = /** @type {AuroTailGroup} */ (await fixture(html`
       <auro-tail-group size="lg">