Skip to content

Commit 0e94556

Browse files
committed
Update xUnit major version from 2 to 3
1 parent 02c4e0b commit 0e94556

4 files changed

Lines changed: 14 additions & 12 deletions

File tree

Tests/Dns/LiveDnsTests.cs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ public class LiveDnsTests {
1111
private readonly LiveDns _liveDns;
1212
private readonly UnfuckedHttpClient _httpClient = A.Fake<UnfuckedHttpClient>();
1313

14+
private static CancellationToken Ct => TestContext.Current.CancellationToken;
15+
1416
public LiveDnsTests() {
1517
_httpClient.Property(PropertyKey.JsonSerializerOptions, GandiClient.JsonOptions);
1618
A.CallTo(() => _gandi.HttpClient).Returns(_httpClient);
@@ -25,7 +27,7 @@ public async Task ListAll() {
2527
Encoding.UTF8, MediaTypeNames.Application.Json)
2628
});
2729

28-
IEnumerable<DnsRecord> actual = await _liveDns.List();
30+
IEnumerable<DnsRecord> actual = await _liveDns.List(cancellationToken: Ct);
2931

3032
actual.Should().BeEquivalentTo([
3133
new DnsRecord(RecordType.A, "@", TimeSpan.FromMinutes(5), "67.210.32.33"),
@@ -46,7 +48,7 @@ public async Task ListByType() {
4648
Encoding.UTF8, MediaTypeNames.Application.Json)
4749
});
4850

49-
IEnumerable<DnsRecord> actual = await _liveDns.List(RecordType.A);
51+
IEnumerable<DnsRecord> actual = await _liveDns.List(RecordType.A, cancellationToken: Ct);
5052

5153
actual.Should().BeEquivalentTo([
5254
new DnsRecord(RecordType.A, "@", TimeSpan.FromMinutes(5), "67.210.32.33"),
@@ -67,7 +69,7 @@ public async Task ListByName() {
6769
Encoding.UTF8, MediaTypeNames.Application.Json)
6870
});
6971

70-
IEnumerable<DnsRecord> actual = await _liveDns.List(name: "west");
72+
IEnumerable<DnsRecord> actual = await _liveDns.List(name: "west", cancellationToken: Ct);
7173

7274
actual.Should().BeEquivalentTo([
7375
new DnsRecord(RecordType.A, "west", TimeSpan.FromMinutes(5), "172.11.57.29")
@@ -87,7 +89,7 @@ public async Task ListByTypeAndName() {
8789
Encoding.UTF8, MediaTypeNames.Application.Json)
8890
});
8991

90-
IEnumerable<DnsRecord> actual = await _liveDns.List(RecordType.A, "west");
92+
IEnumerable<DnsRecord> actual = await _liveDns.List(RecordType.A, "west", Ct);
9193

9294
actual.Should().BeEquivalentTo([
9395
new DnsRecord(RecordType.A, "west", TimeSpan.FromMinutes(5), "172.11.57.29")
@@ -107,7 +109,7 @@ public async Task Get() {
107109
Encoding.UTF8, MediaTypeNames.Application.Json)
108110
});
109111

110-
DnsRecord? actual = await _liveDns.Get(RecordType.A, "west");
112+
DnsRecord? actual = await _liveDns.Get(RecordType.A, "west", Ct);
111113

112114
actual.Should().Be(new DnsRecord(RecordType.A, "west", TimeSpan.FromMinutes(5), "172.11.57.29"));
113115

@@ -124,7 +126,7 @@ public async Task GetMissing() {
124126
MediaTypeNames.Application.Json)
125127
});
126128

127-
DnsRecord? actual = await _liveDns.Get(new DnsRecord(RecordType.A, "missing"));
129+
DnsRecord? actual = await _liveDns.Get(new DnsRecord(RecordType.A, "missing"), Ct);
128130

129131
actual.Should().BeNull();
130132

@@ -138,14 +140,14 @@ public async Task GetMissing() {
138140
Content = new StringContent("hargle invalid json", Encoding.UTF8, MediaTypeNames.Text.Plain)
139141
});
140142

141-
(await _liveDns.Get(RecordType.A, "_test")).Should().BeNull();
143+
(await _liveDns.Get(RecordType.A, "_test", Ct)).Should().BeNull();
142144
}
143145

144146
[Fact]
145147
public async Task Delete() {
146148
A.CallTo(() => _httpClient.SendAsync(A<HttpRequest>._, A<CancellationToken>._)).Returns(new HttpResponseMessage(HttpStatusCode.NoContent));
147149

148-
await _liveDns.Delete(new DnsRecord(RecordType.A, "deleteme"));
150+
await _liveDns.Delete(new DnsRecord(RecordType.A, "deleteme"), Ct);
149151

150152
A.CallTo(() => _httpClient.SendAsync(A<HttpRequest>.That.Matches(req =>
151153
req.Equals(new HttpRequest(HttpMethod.Delete, new Uri("https://api.gandi.net/v5/livedns/domains/aldaviva.com/records/deleteme/A"),
@@ -160,7 +162,7 @@ public async Task Set() {
160162
Headers = { Location = new Uri("https://api.gandi.net/v5/livedns/domains/aldaviva.com/records/_test/TXT") }
161163
});
162164

163-
await _liveDns.Set(new DnsRecord(RecordType.TXT, "_test", null, "hi"));
165+
await _liveDns.Set(new DnsRecord(RecordType.TXT, "_test", null, "hi"), Ct);
164166

165167
A.CallTo(() => _httpClient.SendAsync(A<HttpRequest>.That.Matches(req =>
166168
req.Equals(new HttpRequest(HttpMethod.Put, new Uri("https://api.gandi.net/v5/livedns/domains/aldaviva.com/records/_test/TXT"),

Tests/GandiClientTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public async Task LiveDnsRequest() {
3939
});
4040

4141
ILiveDns liveDns = gandiClient.LiveDns("aldaviva.com");
42-
DnsRecord? actual = await liveDns.Get(RecordType.A, DnsRecord.Origin);
42+
DnsRecord? actual = await liveDns.Get(RecordType.A, DnsRecord.Origin, TestContext.Current.CancellationToken);
4343

4444
actual.Should().Be(new DnsRecord(RecordType.A, "@", TimeSpan.FromDays(7), "67.210.32.33"));
4545

Tests/Marshal/SecondsToTimeSpanConverterTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public async Task Serialize() {
2020
using MemoryStream jsonStream = new();
2121
await using Utf8JsonWriter writer = new(jsonStream);
2222
_converter.Write(writer, TimeSpan.FromMinutes(5), JsonSerializerOptions.Default);
23-
await writer.FlushAsync();
23+
await writer.FlushAsync(TestContext.Current.CancellationToken);
2424
jsonStream.ToArray().Should().Equal("300"u8.ToArray());
2525
}
2626

Tests/Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
<PackageReference Include="FakeItEasy" Version="9.0.1" />
1919
<PackageReference Include="FluentAssertions" Version="[7.2.1, 8)" />
2020
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
21-
<PackageReference Include="xunit" Version="2.9.3" />
2221
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
2322
<PrivateAssets>all</PrivateAssets>
2423
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2524
</PackageReference>
25+
<PackageReference Include="xunit.v3" Version="3.2.2" />
2626
</ItemGroup>
2727

2828
<ItemGroup>

0 commit comments

Comments
 (0)