Patch for Dask (#74)

* Weird errors

* Casting

* Add logs

* Docs

Author: AlecThomson

racs_tools/beamcon_2D.py

@@ -7,6 +7,7 @@
 
 import logging
 import sys
+import traceback
 from pathlib import Path
 from typing import Literal, NamedTuple, Optional
 
@@ -318,13 +319,19 @@ def get_common_beam(
     beams = Beams(beams=beams_list)
 
     # Init flags - False is good, True is bad
-    flags = np.array([False for beam in beams])
+    flags = np.array([False for _ in beams])
 
     # Flag zero beams
     flags = np.array([beam == ZERO_BEAM for beam in beams]) | flags
 
     if cutoff is not None:
-        flags = beams.major.to(u.arcsec).value > cutoff | flags
+        # Make an uncessary copy to in case we're using with Dask
+        # Whacky errors abound...
+        _majors = beams.major.to(u.arcsec).value
+        major_values = np.copy(_majors).astype(float)
+        major_flags = np.array(major_values > cutoff).astype(bool)
+        flags = major_flags | flags
+
         if np.all(flags):
             logger.critical(
                 "All beams are larger than cutoff. All outputs will be blanked!"

tests/test_2d.py

@@ -11,7 +11,7 @@
 import numpy as np
 import pytest
 from astropy.io import fits
-from radio_beam import Beam
+from radio_beam import Beam, Beams
 
 from racs_tools import au2, beamcon_2D
 from racs_tools.convolve_uv import smooth
@@ -279,3 +279,14 @@ def test_get_common_beam(make_2d_image, make_2d_image_smaller):
         common_beam.major.to(u.arcsec).value
         == make_2d_image_smaller.beam.major.to(u.arcsec).value
     )
+
+
+def test_flags():
+    beams = Beams([1, 1, 1, 1])
+    flags = np.array([False for beam in beams])
+    cutoff = 1
+
+    with pytest.raises(TypeError) as e_info:
+        flags = beams.major.to(u.arcsec) > cutoff * u.arcsec | flags
+
+    flags = beams.major.to(u.arcsec).value > cutoff | flags