Enhanced HUD crosshairs are unintuitively offset

[Dylan-Dog-Nightmare]

As far as I can tell, this is accurate to the XBLA port, but unhelpful in the actual game and not separable from the main Enhanced HUD plugin. Most notable is the SPNKR's left-leaning crosshair, but there are other puzzling things such as the Fusion Cannon's crosshair being ever so slightly higher than it should be.


This makes even less sense in M1, which has no relation to the XBLA port of 2 and should not suffer from these issues even from an accuracy/preservation standpoint.

[treellama]

@Hopper262 do you know any history about this?

[Hopper262]

The rocket launcher and alien weapon crosshairs have hardcoded offsets in the XBLA port's HUD code, which I copied when I ported it to Lua. So it's deliberate, but that doesn't mean we should keep it.

I couldn't find any explanation in the code or my emails, but I suspect they're left over from an earlier visual design. The XBLA code doesn't measure every crosshair image, only the pistol's. If the rocket and alien crosshairs used larger images than the others at some point, offsets would have been necessary to keep them centered. In the final version (and the Aleph One plugins), all of the crosshair images are 64x64 pixels and visually centered within that square.

If the x and y values in rawpos.crosshairRocket and rawpos.crosshairAlien are set to zero within the Lua, all crosshairs should point to the center of the screen.