Skip to content
This repository was archived by the owner on Apr 20, 2020. It is now read-only.

Commit a9bde71

Browse files
author
MrCrankHank
committed
Small corrections
1 parent 70898e4 commit a9bde71

File tree

1 file changed

+17
-13
lines changed

1 file changed

+17
-13
lines changed

app/models/target/Target.php

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -455,19 +455,23 @@ public function add_setting($option, $newvalue) {
455455
}
456456

457457
if ($default_settings[$default_settings_key]['defaultvalue'] == $newvalue) {
458-
if (isset($targetsettings[$key])) {
459-
$return = $this->parse_file($this->ietd_config_file, [$this, 'delete_option_from_iqn'], array($option . ' ' . $targetsettings[$key][1]), false, false);
460-
461-
if ($return !== 0) {
462-
$this->logging->log_action_result('The new value is the default value, so i just deleted it!', array('result' => 0, 'code_type' => 'intern'), __METHOD__);
463-
} else {
464-
$return = $this->add_config_to_daemon($option, $newvalue);
465-
466-
if ($return['result'] !== 0) {
467-
$this->logging->log_action_result('Could not set the default value for ' . $option . ' in daemon config', $return, __METHOD__);
468-
}
469-
}
470-
}
458+
if ($targetsettings !== 0) {
459+
if (isset($targetsettings[$key])) {
460+
$return = $this->parse_file($this->ietd_config_file, [$this, 'delete_option_from_iqn'], array($option . ' ' . $targetsettings[$key][1]), false, false);
461+
462+
if ($return !== 0) {
463+
$this->logging->log_action_result('The new value is the default value, so i just deleted it!', array('result' => 0, 'code_type' => 'intern'), __METHOD__);
464+
} else {
465+
$return = $this->add_config_to_daemon($option, $newvalue);
466+
467+
if ($return['result'] !== 0) {
468+
$this->logging->log_action_result('Could not set the default value for ' . $option . ' in daemon config', $return, __METHOD__);
469+
}
470+
}
471+
}
472+
} else {
473+
$this->logging->log_action_result('I won\'t add the default value', array('result' => 4, 'code_type' => 'intern'), __METHOD__);
474+
}
471475
} else {
472476
// add option
473477
$return = $this->parse_file($this->ietd_config_file, [$this, 'add_option_to_iqn'], array($option . ' ' . $newvalue), false, false);

0 commit comments

Comments
 (0)