Merge pull request #5 from AlexSorb/fix-one

bugfix checkstyle

Author: AlexSorb

app/config/checkstyle/checkstyle.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!DOCTYPE module PUBLIC
-        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
-        "https://checkstyle.org/dtds/configuration_1_3.dtd">
+          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+          "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
 <!--
 
@@ -72,8 +72,8 @@
     <!-- See https://checkstyle.org/config_sizes.html -->
     <module name="FileLength"/>
     <module name="LineLength">
-        <property name="fileExtensions" value="java"/>
-        <property name="max" value="120"/>
+      <property name="fileExtensions" value="java"/>
+      <property name="max" value="120"/>
     </module>
 
     <!-- Checks for whitespace                               -->
@@ -83,10 +83,10 @@
     <!-- Miscellaneous other checks.                   -->
     <!-- See https://checkstyle.org/config_misc.html -->
     <module name="RegexpSingleline">
-        <property name="format" value="\s+$"/>
-        <property name="minimum" value="0"/>
-        <property name="maximum" value="0"/>
-        <property name="message" value="Line has trailing spaces."/>
+       <property name="format" value="\s+$"/>
+       <property name="minimum" value="0"/>
+       <property name="maximum" value="0"/>
+       <property name="message" value="Line has trailing spaces."/>
     </module>
 
     <!-- Checks for Headers                                -->
@@ -164,24 +164,24 @@
         <module name="EmptyStatement"/>
         <module name="EqualsHashCode"/>
         <module name="HiddenField" >
-            <property name="ignoreSetter" value="true" />
-            <property name="ignoreConstructorParameter" value="true" />
-        </module>
+    <property name="ignoreSetter" value="true" />
+    <property name="ignoreConstructorParameter" value="true" />
+</module>
         <module name="IllegalInstantiation"/>
         <module name="InnerAssignment"/>
-        <!-- <module name="MagicNumber"/> -->
+        <module name="MagicNumber"/>
         <module name="MissingSwitchDefault"/>
         <module name="MultipleVariableDeclarations"/>
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
 
         <!-- Checks for class design                         -->
         <!-- See https://checkstyle.org/config_design.html -->
-        <!-- <module name="DesignForExtension"/> -->
+        <module name="DesignForExtension"/>
         <module name="FinalClass"/>
         <!-- <module name="HideUtilityClassConstructor"/> -->
         <module name="InterfaceIsType"/>
-        <!-- <module name="VisibilityModifier"/> -->
+        <module name="VisibilityModifier"/>
 
         <!-- Miscellaneous other checks.                   -->
         <!-- See https://checkstyle.org/config_misc.html -->
@@ -191,7 +191,7 @@
         <module name="UpperEll"/>
 
         <module name="Indentation">
-            <property name="basicOffset" value="4"/>
+          <property name="basicOffset" value="4"/>
         </module>
 
         <!-- https://checkstyle.org/config_filters.html#SuppressionXpathFilter -->
@@ -201,8 +201,6 @@
             <property name="optional" value="true"/>
         </module>
 
-        <module name="SuppressionCommentFilter">
-            <property name="checkFormat" value="MethodLength"/>
-        </module>
     </module>
+
 </module>

app/src/main/java/hexlet/code/App.java

@@ -12,7 +12,7 @@
 
 @Command(name = "gendiff", mixinStandardHelpOptions = true, version = "gendiff 0.9",
     description = "Compares two configuration files and shows a difference.")
-public class App implements Callable<Integer> {
+public final class App implements Callable<Integer> {
 
     @Option(names = {"-f", "--format"}, paramLabel = "format", defaultValue = "stylish",
             description = "output format [default: stylish]")

app/src/main/java/hexlet/code/source/Differ.java

@@ -54,7 +54,7 @@ public static String generate(String filePath1, String filePath2, String format)
                 stage = dataSecond.containsKey(key) ? ADDED : DELETED;
             }
 
-            List<Object> date = new ArrayList<>(3);
+            List<Object> date = new ArrayList<>();
             date.add(stage);
             date.add(dataFirstValue);
             date.add(dataSecondValue);

app/src/main/java/hexlet/code/source/formatters/Plain.java

@@ -30,9 +30,6 @@ public static String plain(Map<String, List<Object>> differenceMap) {
         StringBuilder result = new StringBuilder();
         differenceMap.forEach((key, value) -> {
             String addString = "Property '" + key + "' was ";
-            if (value.size() != 3) {
-                throw new IllegalArgumentException("Неподходящие данные");
-            }
 
             var currentState = value.getFirst();
 

app/src/main/java/hexlet/code/source/formatters/Stylish.java

@@ -11,10 +11,6 @@ public static String stylish(Map<String, List<Object>> differenceMap) {
         differenceMap.forEach((key, value) -> {
             String addedString = "";
 
-            if (value.size() != 3) {
-                throw new IllegalArgumentException("Неподходящие данные");
-            }
-
             if (value.getFirst().equals(Differ.DELETED) || value.getFirst().equals(Differ.CHANGED)) {
                 addedString += "- " + key + ": " + value.get(1) + "\n";
             }