feat(Group/Drawer): add dynamic drawer hiding modules based on module's class #4014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `always-visible-class` to config. Update the drawer on `hide_group`.
…stantly on module update using dynamic signal handling. Improve performance - manage the visibility of updated module only instead of iterating over all modules on `hide_group`.
piwonskp
commented
Apr 2, 2025
| if (config_["on-update"].isString()) { | ||
| pid_.push_back(util::command::forkExec(config_["on-update"].asString())); | ||
| } | ||
| signal_updated.emit(this); |
Author
There was a problem hiding this comment.
It means that every module will emit an update signal.
An alternative solution is to wrap (before calling group->addWidget(module)) only the modules belonging to groups in a class that emits update signals, or limit it to those in dynamic drawers. This would limit signal emitting to dynamic-drawers and minimize the performance overhead on other modules to the bare minimum.
Depends on whether other modules could also benefit from update signaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4008