Sway Workspace: Fix workspace button not showing for tabbed/nested layouts #4046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logic used to detect the currently focused workspace in Sway by fixing an issue that occurred when the layout was set to tabbed (or any other nested layout).
Previously, the code only checked one level deep for a focused container, this failed to detect focus correctly when the focused view was nested deeper within tabbed or stacked containers, causing waybar to show incorrect or missing workspace names.
We now recursively traverse all child nodes (including nodes and floating_nodes) to check for a focused container, ensuring proper detection regardless of layout depth