CLI Refactor

1. No more string parsing unnecessarily
2. Removed dead code bad bad logic

Author: AlexsanderHamir

.gitignore

@@ -1,4 +1,5 @@
 tasks.md
 *.out
 *.prof
-*prof
+*prof
+/Enviroment*/

cli/api.go

@@ -6,17 +6,19 @@ import (
 	"log/slog"
 
 	"github.com/AlexsanderHamir/prof/args"
+	"github.com/AlexsanderHamir/prof/benchmark"
 	"github.com/AlexsanderHamir/prof/collector"
 	"github.com/AlexsanderHamir/prof/config"
+	"github.com/AlexsanderHamir/prof/shared"
 	"github.com/AlexsanderHamir/prof/tracker"
 	"github.com/AlexsanderHamir/prof/version"
 	"github.com/spf13/cobra"
 )
 
 var (
 	// Root command flags.
-	benchmarks string
-	profiles   string
+	benchmarks []string
+	profiles   []string
 	tag        string
 	count      int
 
@@ -48,16 +50,16 @@ func CreateRootCmd() *cobra.Command {
 func createManualCmd() *cobra.Command {
 	manualCmd := &cobra.Command{
 		Use:     "manual",
-		Short:   "Receives profile files and performs data collection and organization.",
+		Short:   "Receives profile files and performs data collection and organization. (doesn't wrap go test)",
 		Args:    cobra.MinimumNArgs(1),
-		Example: "prof manual cpu.prof memory.prof block.prof",
+		Example: "prof manual --tag tagName cpu.prof memory.prof block.prof mutex.prof",
 		RunE: func(_ *cobra.Command, args []string) error {
 			return collector.RunCollector(args, tag)
 		},
 	}
 
 	tagFlag := "tag"
-	manualCmd.Flags().StringVar(&tag, tagFlag, "", "Tag for organization")
+	manualCmd.Flags().StringVar(&tag, tagFlag, "", "The tag is used to organize the results")
 	_ = manualCmd.MarkFlagRequired(tagFlag)
 
 	return manualCmd
@@ -68,8 +70,7 @@ func createRunCmd() *cobra.Command {
 	profileFlag := "profiles"
 	tagFlag := "tag"
 	countFlag := "count"
-	example := fmt.Sprintf(`prof run --%s "[BenchmarkGenPool]" --%s "[cpu,memory]" --%s 10 --%s "tag1"`,
-		benchFlag, profileFlag, countFlag, tagFlag)
+	example := fmt.Sprintf(`prof run --%s BenchmarkGenPool --%s cpu,memory --%s 10 --%s "tag1"`, benchFlag, profileFlag, countFlag, tagFlag)
 
 	runCmd := &cobra.Command{
 		Use:     "run",
@@ -78,9 +79,9 @@ func createRunCmd() *cobra.Command {
 		Example: example,
 	}
 
-	runCmd.Flags().StringVar(&benchmarks, benchFlag, "", `Benchmarks to run (e.g., "[BenchmarkGenPool]")"`)
-	runCmd.Flags().StringVar(&profiles, profileFlag, "", `Profiles to use (e.g., "[cpu,memory,mutex]")`)
-	runCmd.Flags().StringVar(&tag, tagFlag, "", "Tag for the run")
+	runCmd.Flags().StringSliceVar(&benchmarks, benchFlag, []string{}, `Benchmarks to run (e.g., "[BenchmarkGenPool]")"`)
+	runCmd.Flags().StringSliceVar(&profiles, profileFlag, []string{}, `Profiles to use (e.g., "[cpu,memory,mutex]")`)
+	runCmd.Flags().StringVar(&tag, tagFlag, "", "The tag is used to organize the results")
 	runCmd.Flags().IntVar(&count, countFlag, 0, "Number of runs")
 
 	_ = runCmd.MarkFlagRequired(benchFlag)
@@ -153,34 +154,33 @@ func Execute() error {
 }
 
 func runBenchmarks(_ *cobra.Command, _ []string) error {
-	if benchmarks == "" || profiles == "" || tag == "" || count == 0 {
-		return errors.New("missing required arguments. Use --help for usage information")
+	if len(benchmarks) == 0 {
+		return errors.New("benchmarks flag is empty")
 	}
 
-	cfg, err := config.LoadFromFile("config_template.json")
-	if err != nil {
-		cfg = &config.Config{}
+	if len(profiles) == 0 {
+		return errors.New("profiles flag is empty")
 	}
 
-	benchmarkList, profileList, err := parseAndValidateBenchmarkParams(benchmarks, profiles)
+	cfg, err := config.LoadFromFile(shared.ConfigFilename)
 	if err != nil {
-		return fmt.Errorf("failed to parse benchmark config: %w", err)
+		cfg = &config.Config{}
 	}
 
-	if err = setupDirectories(tag, benchmarkList, profileList); err != nil {
+	if err = benchmark.SetupDirectories(tag, benchmarks, profiles); err != nil {
 		return fmt.Errorf("failed to setup directories: %w", err)
 	}
 
 	benchArgs := &args.BenchArgs{
-		Benchmarks: benchmarkList,
-		Profiles:   profileList,
+		Benchmarks: benchmarks,
+		Profiles:   profiles,
 		Count:      count,
 		Tag:        tag,
 	}
 
 	printConfiguration(benchArgs, cfg.FunctionFilter)
 
-	if err = runBencAndGetProfiles(benchArgs, cfg.FunctionFilter); err != nil {
+	if err = runBenchAndGetProfiles(benchArgs, cfg.FunctionFilter); err != nil {
 		return err
 	}
 
@@ -202,10 +202,6 @@ func runSetup(_ *cobra.Command, _ []string) error {
 
 // runTrack handles the track command execution
 func runTrack(_ *cobra.Command, _ []string) error {
-	if !validProfiles[profileType] {
-		return fmt.Errorf("invalid profile type '%s'. Valid types: cpu, memory, mutex, block", profileType)
-	}
-
 	validFormats := map[string]bool{
 		"summary":  true,
 		"detailed": true,
@@ -215,20 +211,13 @@ func runTrack(_ *cobra.Command, _ []string) error {
 		return fmt.Errorf("invalid output format '%s'. Valid formats: summary, detailed", outputFormat)
 	}
 
-	// Call the tracker API
-	report, err := tracker.CheckPerformanceDifferences(
-		baselineTag,
-		currentTag,
-		benchmarkName,
-		profileType,
-	)
-
+	report, err := tracker.CheckPerformanceDifferences(baselineTag, currentTag, benchmarkName, profileType)
 	if err != nil {
 		return fmt.Errorf("failed to track performance differences: %w", err)
 	}
 
-	// Display results based on output format
-	if len(report.FunctionChanges) == 0 {
+	noFunctionChanges := len(report.FunctionChanges) == 0
+	if noFunctionChanges {
 		slog.Info("No function changes detected between the two runs")
 		return nil
 	}

cli/globals.go

@@ -5,7 +5,6 @@ import (
 	"log/slog"
 	"math"
 	"sort"
-	"strings"
 
 	"github.com/AlexsanderHamir/prof/args"
 	"github.com/AlexsanderHamir/prof/benchmark"
@@ -14,85 +13,14 @@ import (
 	"github.com/AlexsanderHamir/prof/tracker"
 )
 
-var validProfiles = map[string]bool{
-	"cpu":    true,
-	"memory": true,
-	"mutex":  true,
-	"block":  true,
-}
-
-// validateListArguments checks if the benchmarks and profiles arguments are valid lists.
-func validateListArguments(benchmarks, profiles string) error {
-	if strings.TrimSpace(benchmarks) == "[]" {
-		return ErrEmptyBenchmarks
-	}
-	if strings.TrimSpace(profiles) == "[]" {
-		return ErrEmptyProfiles
-	}
-
-	benchmarks = strings.TrimSpace(benchmarks)
-	profiles = strings.TrimSpace(profiles)
-
-	if !strings.HasPrefix(benchmarks, "[") || !strings.HasSuffix(benchmarks, "]") {
-		return fmt.Errorf("benchmarks %w %s", ErrBracket, benchmarks)
-	}
-	if !strings.HasPrefix(profiles, "[") || !strings.HasSuffix(profiles, "]") {
-		return fmt.Errorf("profiles %w %s", ErrBracket, profiles)
-	}
-
-	return nil
-}
-
-// parseListArgument parses a bracketed, comma-separated string into a slice of strings.
-func parseListArgument(arg string) []string {
-	arg = strings.Trim(arg, "[]")
-	if arg == "" {
-		return []string{}
-	}
-
-	parts := strings.Split(arg, ",")
-	var result []string
-	for _, part := range parts {
-		result = append(result, strings.TrimSpace(part))
-	}
-	return result
-}
-
-// Rest of the functions remain the same...
-func parseAndValidateBenchmarkParams(benchmarks, profiles string) ([]string, []string, error) {
-	if err := validateListArguments(benchmarks, profiles); err != nil {
-		return nil, nil, err
-	}
-
-	benchmarkList := parseListArgument(benchmarks)
-	profileList := parseListArgument(profiles)
-
-	if err := validateAcceptedProfiles(profileList); err != nil {
-		return nil, nil, err
-	}
-
-	return benchmarkList, profileList, nil
-}
-
-func validateAcceptedProfiles(profiles []string) error {
-	for _, profile := range profiles {
-		if valid := validProfiles[profile]; !valid {
-			return fmt.Errorf("received unvalid profile: %s", profile)
-		}
-	}
-	return nil
-}
-
-func setupDirectories(tag string, benchmarks, profiles []string) error {
-	return benchmark.SetupDirectories(tag, benchmarks, profiles)
-}
-
 func printConfiguration(benchArgs *args.BenchArgs, functionFilterPerBench map[string]config.FunctionFilter) {
-	slog.Info("Parsed arguments",
+	slog.Info(
+		"Parsed arguments",
 		"Benchmarks", benchArgs.Benchmarks,
 		"Profiles", benchArgs.Profiles,
 		"Tag", benchArgs.Tag,
-		"Count", benchArgs.Count)
+		"Count", benchArgs.Count,
+	)
 
 	hasBenchFunctionFilters := len(functionFilterPerBench) > 0
 	if hasBenchFunctionFilters {
@@ -105,7 +33,7 @@ func printConfiguration(benchArgs *args.BenchArgs, functionFilterPerBench map[st
 	}
 }
 
-func runBencAndGetProfiles(benchArgs *args.BenchArgs, benchmarkConfigs map[string]config.FunctionFilter) error {
+func runBenchAndGetProfiles(benchArgs *args.BenchArgs, benchmarkConfigs map[string]config.FunctionFilter) error {
 	slog.Info("Starting benchmark pipeline...")
 
 	for _, benchmarkName := range benchArgs.Benchmarks {
@@ -120,7 +48,6 @@ func runBencAndGetProfiles(benchArgs *args.BenchArgs, benchmarkConfigs map[strin
 		}
 
 		slog.Info("Analyzing profile functions", "Benchmark", benchmarkName)
-
 		args := &args.CollectionArgs{
 			Tag:             benchArgs.Tag,
 			Profiles:        benchArgs.Profiles,