Non-Wrapping Implemented

The core feature for the non wrapping way of collecting profile information is ready

Author: AlexsanderHamir

benchmark/api.go

@@ -96,17 +96,12 @@ func CollectProfileFunctions(args *args.CollectionArgs) error {
 			return fmt.Errorf("failed to create output directory: %w", err)
 		}
 
-		filter := parser.ProfileFilter{
-			FunctionPrefixes: args.BenchmarkConfig.IncludePrefixes,
-			IgnoreFunctions:  args.BenchmarkConfig.IgnoreFunctions,
-		}
-
-		functions, err := parser.GetAllFunctionNames(paths.ProfileTextFile, filter)
+		functions, err := parser.GetAllFunctionNames(paths.ProfileTextFile, args.BenchmarkConfig)
 		if err != nil {
 			return fmt.Errorf("failed to extract function names: %w", err)
 		}
 
-		if err = saveAllFunctionsPprofContents(functions, paths); err != nil {
+		if err = collector.SaveAllFunctionsPprofContents(functions, paths.ProfileBinaryFile, paths.FunctionDirectory); err != nil {
 			return fmt.Errorf("getAllFunctionsPprofContents failed: %w", err)
 		}
 	}

benchmark/helpers.go

@@ -10,7 +10,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/AlexsanderHamir/prof/collector"
 	"github.com/AlexsanderHamir/prof/shared"
 )
 
@@ -209,15 +208,3 @@ func getProfilePaths(tag, benchmarkName, profile string) ProfilePaths {
 		FunctionDirectory: filepath.Join(tagDir, profile+shared.FunctionsDirSuffix, benchmarkName),
 	}
 }
-
-// saveAllFunctionsPprofContents calls [getFunctionPprofContent] sequentially.
-func saveAllFunctionsPprofContents(functions []string, paths ProfilePaths) error {
-	for _, function := range functions {
-		outputFile := filepath.Join(paths.FunctionDirectory, function+"."+shared.TextExtension)
-		if err := collector.GetFunctionPprofContent(function, paths.ProfileBinaryFile, outputFile); err != nil {
-			return fmt.Errorf("failed to extract function content for %s: %w", function, err)
-		}
-	}
-
-	return nil
-}

collector/api.go

@@ -9,9 +9,13 @@ import (
 	"path/filepath"
 	"strings"
 
+	"github.com/AlexsanderHamir/prof/config"
+	"github.com/AlexsanderHamir/prof/parser"
 	"github.com/AlexsanderHamir/prof/shared"
 )
 
+const globalSign = "*"
+
 // RunCollector handles data organization without wrapping go test.
 func RunCollector(files []string, tag string) error {
 	if err := ensureDirExists(shared.MainDirOutput); err != nil {
@@ -24,23 +28,51 @@ func RunCollector(files []string, tag string) error {
 		return fmt.Errorf("CleanOrCreateDir failed: %w", err)
 	}
 
+	cfg, err := config.LoadFromFile(shared.ConfigFilename)
+	if err != nil {
+		cfg = &config.Config{}
+	}
+
+	var functionFilter config.FunctionFilter
+
+	globalFilter, hasGlobalFilter := cfg.FunctionFilter[globalSign]
+	if hasGlobalFilter {
+		functionFilter = globalFilter
+	}
+
 	for _, binaryFilePath := range files {
-		// 3. create a dir for each profile file
 		fileName := strings.TrimSuffix(binaryFilePath, filepath.Ext(binaryFilePath))
 		profilepath := path.Join(tagDir, fileName)
-		if err := ensureDirExists(profilepath); err != nil {
+		if err = ensureDirExists(profilepath); err != nil {
 			return err
 		}
 
-		// 4. Collect results.
-		// 1. generate txt files
-		outputFilePath := path.Join(profilepath, fileName+"."+shared.TextExtension)
-		if err := GenerateProfileTextOutput(binaryFilePath, outputFilePath); err != nil {
+		if !hasGlobalFilter {
+			localFilter, hasLocalFilter := cfg.FunctionFilter[fileName]
+			if hasLocalFilter {
+				functionFilter = localFilter
+			}
+		}
+
+		outputTextFilePath := path.Join(profilepath, fileName+"."+shared.TextExtension)
+		if err = GenerateProfileTextOutput(binaryFilePath, outputTextFilePath); err != nil {
 			return err
 		}
 
-		// 2. collect functions according to config
+		var functions []string
+		functions, err = parser.GetAllFunctionNames(outputTextFilePath, functionFilter)
+		if err != nil {
+			return fmt.Errorf("failed to extract function names: %w", err)
+		}
+
+		functionDir := path.Join(profilepath, "functions")
+		if err = ensureDirExists(functionDir); err != nil {
+			return err
+		}
 
+		if err = SaveAllFunctionsPprofContents(functions, binaryFilePath, functionDir); err != nil {
+			return fmt.Errorf("getAllFunctionsPprofContents failed: %w", err)
+		}
 	}
 	return nil
 }
@@ -92,3 +124,15 @@ func GetFunctionPprofContent(function, binaryFile, outputFile string) error {
 	slog.Info("Collected function", "function", function)
 	return nil
 }
+
+// SaveAllFunctionsPprofContents calls [GetFunctionPprofContent] sequentially.
+func SaveAllFunctionsPprofContents(functions []string, binaryPath, basePath string) error {
+	for _, functionName := range functions {
+		outputFile := filepath.Join(basePath, functionName+"."+shared.TextExtension)
+		if err := GetFunctionPprofContent(functionName, binaryPath, outputFile); err != nil {
+			return fmt.Errorf("failed to extract function content for %s: %w", functionName, err)
+		}
+	}
+
+	return nil
+}

collector/helpers.go

@@ -17,4 +17,3 @@ func ensureDirExists(basePath string) error {
 
 	return nil
 }
-

parser/api.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 
 	"github.com/AlexsanderHamir/prof/args"
+	"github.com/AlexsanderHamir/prof/config"
 	"github.com/AlexsanderHamir/prof/shared"
 )
 
@@ -74,7 +75,7 @@ func TurnLinesIntoObjects(profilePath, profileType string) ([]*LineObj, error) {
 }
 
 // GetAllFunctionNames extracts all function names from a profile text file, applying the given filter.
-func GetAllFunctionNames(filePath string, filter ProfileFilter) (names []string, err error) {
+func GetAllFunctionNames(filePath string, filter config.FunctionFilter) (names []string, err error) {
 	scanner, file, err := shared.GetScanner(filePath)
 	if err != nil {
 		return nil, fmt.Errorf("GetAllFunctionNames Failed: %w", err)
@@ -107,7 +108,7 @@ func GetAllFunctionNames(filePath string, filter ProfileFilter) (names []string,
 			continue
 		}
 
-		if funcName := extractFunctionName(line, filter.FunctionPrefixes, ignoreSet); funcName != "" {
+		if funcName := extractFunctionName(line, filter.IncludePrefixes, ignoreSet); funcName != "" {
 			names = append(names, funcName)
 		}
 	}

shared/utils.go

@@ -22,6 +22,7 @@ const (
 	PermFile           = 0o644
 	FunctionsDirSuffix = "_functions"
 	TextExtension      = "txt"
+	ConfigFilename     = "config_template.json"
 )
 
 func GetScanner(filePath string) (*bufio.Scanner, *os.File, error) {
@@ -40,7 +41,7 @@ func CleanOrCreateDir(dir string) error {
 	info, err := os.Stat(dir)
 	if err != nil {
 		if os.IsNotExist(err) {
-			if err := os.MkdirAll(dir, PermDir); err != nil {
+			if err = os.MkdirAll(dir, PermDir); err != nil {
 				return fmt.Errorf("failed to create %s directory: %w", dir, err)
 			}
 			return nil