completed parser transition

Author: AlexsanderHamir

engine/benchmark/helpers.go

@@ -464,7 +464,7 @@ func collectProfileFunctions(args *internal.CollectionArgs) error {
 			return fmt.Errorf("failed to create output directory: %w", err)
 		}
 
-		functions, err := parser.GetAllFunctionNames(paths.ProfileTextFile, args.BenchmarkConfig)
+		functions, err := parser.GetAllFunctionNamesV2(paths.ProfileBinaryFile, args.BenchmarkConfig)
 		if err != nil {
 			return fmt.Errorf("failed to extract function names: %w", err)
 		}

engine/collector/api.go

@@ -54,7 +54,7 @@ func RunCollector(files []string, tag string) error {
 			return err
 		}
 
-		if err = collectFunctions(outputTextFilePath, profileDirPath, fullBinaryPath, functionFilter); err != nil {
+		if err = collectFunctions(profileDirPath, fullBinaryPath, functionFilter); err != nil {
 			return fmt.Errorf("collectFunctions failed: %w", err)
 		}
 	}

engine/collector/helpers.go

@@ -43,9 +43,9 @@ func getFunctionPprofContent(function, binaryFile, outputFile string) error {
 	return nil
 }
 
-func collectFunctions(outputTextFilePath, profileDirPath, fullBinaryPath string, functionFilter internal.FunctionFilter) error {
+func collectFunctions(profileDirPath, fullBinaryPath string, functionFilter internal.FunctionFilter) error {
 	var functions []string
-	functions, err := parser.GetAllFunctionNames(outputTextFilePath, functionFilter)
+	functions, err := parser.GetAllFunctionNamesV2(fullBinaryPath, functionFilter)
 	if err != nil {
 		return fmt.Errorf("failed to extract function names: %w", err)
 	}

parser/api.go

@@ -203,3 +203,24 @@ func extractSimpleFunctionName(fullPath string) string {
 
 	return lastPart
 }
+
+func matchPrefix(funcName string, functionPrefixes []string) bool {
+	var hasPrefix bool
+	for _, prefix := range functionPrefixes {
+		if strings.Contains(funcName, prefix) {
+			hasPrefix = true
+			break
+		}
+	}
+
+	return hasPrefix
+}
+
+func getFilterSets(ignoreFunctions []string) map[string]struct{} {
+	ignoreSet := make(map[string]struct{})
+	for _, f := range ignoreFunctions {
+		ignoreSet[f] = struct{}{}
+	}
+
+	return ignoreSet
+}