added chroma support via platforms/chroma/nordic.xml #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you share some screenshots? The code looks good though. |
|
Will do when I get back to my pc. Thanks! |
|
@avih7531 I figure I should just remind you this PR is still open. I am waiting on those screenshots before I request a review from Alex, but he is on vacation, so there is no rush. |
|
Hi pebbles, Sorry for the long wait! I abandoned chroma as I decided that it A. didn't look good and B. wasn't useful software. I've since refactored the project I had that used chroma, so I can't provide any screenshots, but it ~worked All the best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for alecthomas' chroma syntax highlighter