Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add tests for configuration options #150

Merged
merged 56 commits into from
Sep 24, 2024
Merged

Feat: Add tests for configuration options #150

merged 56 commits into from
Sep 24, 2024

Conversation

5-pebbles
Copy link
Collaborator

@5-pebbles 5-pebbles commented Jul 7, 2024 •
edited
Loading

This PR adds state tests for every option.

5-pebbles added 30 commits June 12, 2024 13:19
@5-pebbles
feat(tests): separate test modules;
1f04c6d
@5-pebbles
feat(tests): add assert_eq to test module;
cda0836
@5-pebbles
ci(tests): echo tests output on complete;
5f3658a
@5-pebbles
fix(tests): remove intentional failures;
2261642
@5-pebbles
feat(tests): assert_eq works on tables now;
c117dae
@5-pebbles
feat(tests): add tests for none, is_none, & hex_to_rgb;
21c2ca9
@5-pebbles
feat(tests): add tests & fix merge;
e7d742a
@5-pebbles
fix(tests): fix bad module name in error messages;
f5ff09c
@5-pebbles
feat(tests): add tests for merge_inplace;
289870e
@5-pebbles
fix(utils): merge_inplace clones values in t1 nested tables;
706f874
@5-pebbles
feat(utils): add is_table to utils;
7c38ee1
@5-pebbles
feat(tests): add tests for rgb_to_hex;
ae12e29
@5-pebbles
fix(utils): rgb_to_hex returns uppercase like everything else;
be45c60
@5-pebbles
feat(tests): readable table asserts;
a109c94
@5-pebbles
feat(tests): add tests for rgb_to_hsv;
a741e90
@5-pebbles
fix(utils): hsv_to_rgb function was misnamed;
e627217
@5-pebbles
feat(tests): add tests for hsv_to_rgb;
ea111b0
@5-pebbles
rm(utils): rgb_to_hsv, hsv_to_rgb, darken, & lighten;
7876f49 
They aren't used anywhere...
@5-pebbles
rm(utils): replace merge with merge_inplace;
9d89242
@5-pebbles
feat(tests): add tests for blend;
3349c8b
@5-pebbles
feat(tests): add test for merge_inplace returning a reference;
4f5b445
@5-pebbles
feat(utils): re-add merge & cleanup merge_inplace usage;
8c8fff4
@5-pebbles
feat(assert_eq): add stack_level optional arg;
bed9e2b
@5-pebbles
rm(options.lua): remove old option tests;
5c1255a
@5-pebbles
fix(tests): change utils assert message for consistency;
9f8c6fc
@5-pebbles
feat(tests): reset config before tests;
a460c9a
@5-pebbles
feat(tests): add state tests for italic_comments;
0736782
@5-pebbles
feat(tests): add state tests for bold_keywords;
a5a74f3
@5-pebbles
feat(tests): make highlight return hexed colors;
61f4b47
@5-pebbles
feat(tests): add state tests for on_palette;
b73e8b4
@AlexvZyl
Copy link
Owner

AlexvZyl commented Sep 1, 2024

@5-pebbles Look into git rebase. Would have made working on these two branches a lot nicer.

@5-pebbles
Copy link
Collaborator Author

5-pebbles commented Sep 6, 2024 •
edited
Loading

@5-pebbles Look into git rebase. Would have made working on these two branches a lot nicer.

I will look into it. I have had some bad experiences with it in the past, but I expect I have just been using it wrong.

@5-pebbles 5-pebbles changed the base branch from tests to dev September 6, 2024 14:23
AlexvZyl
AlexvZyl requested changes Sep 7, 2024
View reviewed changes
Copy link
Owner

@AlexvZyl AlexvZyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are really super nice.

@5-pebbles 5-pebbles requested a review from AlexvZyl September 7, 2024 15:28
@5-pebbles
Copy link
Collaborator Author

That should be everything you mentioned fixed. Thanks for the review!

AlexvZyl
AlexvZyl requested changes Sep 8, 2024
View reviewed changes
@5-pebbles 5-pebbles mentioned this pull request Sep 23, 2024
Closed
@AlexvZyl
Copy link
Owner

@5-pebbles Squash and merge when you are ready.

@AlexvZyl
Copy link
Owner

Actually, I am just gonna merge. You can move the utils out in another MR if you feel strongly about it.

@AlexvZyl AlexvZyl merged commit 457cf92 into dev Sep 24, 2024
1 check passed
@AlexvZyl AlexvZyl deleted the tests_options branch September 28, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexvZyl AlexvZyl AlexvZyl approved these changes

Assignees

@5-pebbles 5-pebbles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@5-pebbles @AlexvZyl