-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimal data model to config so that palette param gets completions #162
Conversation
Thanks! That is nice. Are those generated or did you do them manually? |
The screenshot is real :) It’s the actual output of cmp through the lsp. |
I think he meant is the |
Oh got it, it’s manual. |
Alright so there seems to be a better way of doing this... I am still figuring how it works but would it be alright if I push the change to this PR? You define the types above the values and the lsp will fill in all the fields it's self. I would just make a review suggestion but it takes a lot of small changes in different files. Also thanks for pointing this out it will make configuring the extended palette and highlights much easier. |
And one other thing I can get it working when editing the nordic source code but I can't get anything when working in my config... It won't work for me when using your system or my new one, does it still work for you when you run it remotely: "jameswalls/nordic.nvim",
branch = "palette_completions", |
Co-authored-by: Jaime Paredes [email protected]
I still can't get it working with my config, but I tried using yours, and it works like a charm! I inlined the classes, and lua-ls should now automatically generate all the fields. When you have the time can you give it a test and if it's all working as expected I will get this merged. |
Simplify the config experience of the
on_highlight
,on_palette
, andafter_palette
config functions by adding code completion to thepalette
parameter.