Merge pull request #1592 from Alfresco/fix/MNT-23303_MetadataTracker_hole_fix

MNT-23303 - Tracker should start off from lastGoodTxCommitTimeInIndex that takes into account the retention hole

Author: evasques

Diff for: search-services/alfresco-search/src/main/java/org/alfresco/solr/tracker/MetadataTracker.java

@@ -944,9 +944,7 @@ protected void trackTransactions() throws IOException, JSONException
                 */
                 this.state = getTrackerState();
 
-                Long fromCommitTime = getTxFromCommitTime(txnsFound,
-                        state.getLastIndexedTxCommitTime() == 0 ? state.getLastGoodTxCommitTimeInIndex()
-                                : state.getLastIndexedTxCommitTime());
+                Long fromCommitTime = getTxFromCommitTime(txnsFound,state.getLastGoodTxCommitTimeInIndex());
 
                 // Get transaction list to be indexed
                 if (docRouter instanceof DBIDRangeRouter && txIntervalCommitTimeServiceAvailable)