temp files not deleted in many exceptional cases

[binduwavell]

In Alfresco there is a temp file provider that cleans up temp files that have not been cleaned properly within 24h. No such system exists in this project.

In

alfresco-transform-core/alfresco-transformer-base/src/main/java/org/alfresco/transformer/AbstractTransformerController.java

Line 344 in 60eb104

final File targetFile = buildFile(targetFilename);

a temp file is created to hold the transform results/target. Similarly a source file is produced near the top of this transform() method.

If any of the exceptional conditions happen that result in the following lines of code: 364, 373, 389, 398, 407 executing, the transform method returns without a finally and leave the source and target files on disk and they are NEVER cleaned up.

The transform implementation that starts on line 165 (handles REST calls) doesn't appear to clean up temp files ever.