Skip to content

Allow WithModel with Dispatch models#197

Merged
kris-brown merged 1 commit into
mainfrom
dispatchfix2
May 22, 2025
Merged

Allow WithModel with Dispatch models#197
kris-brown merged 1 commit into
mainfrom
dispatchfix2

Conversation

@kris-brown

@kris-brown kris-brown commented May 22, 2025

Copy link
Copy Markdown
Collaborator

Dispatch models are special models that have the meaning of "just use dispatch". Previously one could index a method with a dispatch model, i.e. f[d](args...) = f(args...). However to be more consistent with normal models, we also need a f(::WithModel{Dispatch}, args...) = f(args...) method to be automatically generated for each theory operation.

@kris-brown kris-brown merged commit 125be0a into main May 22, 2025
8 of 9 checks passed
@codecov

codecov Bot commented May 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (92f194e) to head (61edcd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files          39       39           
  Lines        2366     2367    +1     
=======================================
+ Hits         2182     2183    +1     
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kris-brown kris-brown deleted the dispatchfix2 branch May 22, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant