Skip to content

Use a wrapper type for ThCategory in Opposite cat models#198

Merged
kris-brown merged 1 commit into
mainfrom
opwrapper
May 22, 2025
Merged

Use a wrapper type for ThCategory in Opposite cat models#198
kris-brown merged 1 commit into
mainfrom
opwrapper

Conversation

@kris-brown

@kris-brown kris-brown commented May 22, 2025

Copy link
Copy Markdown
Collaborator

Opposite cat models have a piece of data: something which implements ThCategory itself. This is a great use case for wrapper types around models, so this PR shows how to use wrapper types in this context (removing the need to manually check that that the value implements ThCategory).

This also forces us to not rely on GATlab being in the namespace of wherever @wrapper gets expanded. The solution is to use GlobalRef.

@codecov

codecov Bot commented May 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (125be0a) to head (106849b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   92.18%   91.97%   -0.21%     
==========================================
  Files          39       39              
  Lines        2367     2369       +2     
==========================================
- Hits         2182     2179       -3     
- Misses        185      190       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kris-brown kris-brown merged commit 92b59cd into main May 22, 2025
11 checks passed
@kris-brown kris-brown deleted the opwrapper branch May 22, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant