Add error handling to Google News search; Remvoe unnecessary error handling in rfc822.vala

Author: Allen-B1

src/MainWindow.vala

@@ -54,9 +54,13 @@ class MainWindow : Gtk.ApplicationWindow {
             this.source_remove(src); });
 
         headerbar.search.connect((query) => {
-            var feed = Feed.from_uri("https://news.google.com/news/rss/search/section/q/" + query + "?ned=us&gl=US&hl=en");
-            this.add_feed(feed);
-            this.source_add(feed.source);
+            try {
+                var feed = Feed.from_uri("https://news.google.com/news/rss/search/section/q/" + query + "?ned=us&gl=US&hl=en");
+                this.add_feed(feed);
+                this.source_add(feed.source);
+            } catch (Error err) {
+                this.show_error("Couldn't reach Google News");
+            }
         });
         headerbar.view_info_clicked.connect(() => {
             var dialog = new Gtk.Dialog.with_buttons("Feed information", this, Gtk.DialogFlags.MODAL | Gtk.DialogFlags.DESTROY_WITH_PARENT, "Close", Gtk.ResponseType.ACCEPT, null);

src/rfc822.vala

@@ -1,81 +1,76 @@
 DateTime? parse_rfc822_date(string date) {
-	try {
-		var pieces = new Gee.ArrayList<string>.wrap(date.split(" "));
-		// if there is a day of the week, remove it
-		if(pieces[0][pieces[0].length - 1] == ',') {
-			pieces.remove_at(0);
-		}
-		var day = int.parse(pieces[0]);
-		int month = 1;
-		switch(pieces[1]) {
-			case "Jan": month = 1; break;
-			case "Feb": month = 2; break;
-			case "Mar": month = 3; break;
-			case "Apr": month = 4; break;
-			case "May": month = 5; break;
-			case "Jun": month = 6; break;
-			case "Jul": month = 7; break;
-			case "Aug": month = 8; break;
-			case "Sep": month = 9; break;
-			case "Oct": month = 10; break;
-			case "Nov": month = 11; break;
-			case "Dec": month = 12; break;
-		}
-		var year = int.parse(pieces[2]);
+	var pieces = new Gee.ArrayList<string>.wrap(date.split(" "));
+	// if there is a day of the week, remove it
+	if(pieces[0][pieces[0].length - 1] == ',') {
+		pieces.remove_at(0);
+	}
+	var day = int.parse(pieces[0]);
+	int month = 1;
+	switch(pieces[1]) {
+		case "Jan": month = 1; break;
+		case "Feb": month = 2; break;
+		case "Mar": month = 3; break;
+		case "Apr": month = 4; break;
+		case "May": month = 5; break;
+		case "Jun": month = 6; break;
+		case "Jul": month = 7; break;
+		case "Aug": month = 8; break;
+		case "Sep": month = 9; break;
+		case "Oct": month = 10; break;
+		case "Nov": month = 11; break;
+		case "Dec": month = 12; break;
+	}
+	var year = int.parse(pieces[2]);
 
-		var time_arr = pieces[3].split(":");
-		var hour = int.parse(time_arr[0]);
-		var minute = int.parse(time_arr[1]);
-		var second = 0;
-		if(time_arr.length >= 3) {
-			second = int.parse(time_arr[2]);
-		}
+	var time_arr = pieces[3].split(":");
+	var hour = int.parse(time_arr[0]);
+	var minute = int.parse(time_arr[1]);
+	var second = 0;
+	if(time_arr.length >= 3) {
+		second = int.parse(time_arr[2]);
+	}
 
-		TimeZone zone;
-		switch(pieces[4]) {
-			case "EDT":
-				zone = new TimeZone("-04");
-				break;
-			case "EST":
-			case "CDT":
-				zone = new TimeZone("-05");
-				break;
-			case "CST":
-			case "MDT":
-				zone = new TimeZone("-06");
-				break;
-			case "MST":
-			case "PDT":
-				zone = new TimeZone("-07");
-				break;
-			case "PST":
-				zone = new TimeZone("-08");
-				break;
-			case "1A":
-				zone = new TimeZone("-01");
-				break;
-			case "1M":
-				zone = new TimeZone("-12");
-				break;
-			case "1N":
-				zone = new TimeZone("+01");
-				break;
-			case "1Y":
-				zone = new TimeZone("+12");
-				break;
-			case "GMT":
-			case "UT":
-			case "1Z":
-				zone = new TimeZone.utc();
-				break;
-			default:
-				zone = new TimeZone(pieces[4]);
-				break;
-		}
-		return new DateTime(zone, year, month, day, hour, minute, second);	
-	} catch(Error err) {
-		stderr.printf("Error parsing date: %s\n", err.message);
-		return null;
+	TimeZone zone;
+	switch(pieces[4]) {
+		case "EDT":
+			zone = new TimeZone("-04");
+			break;
+		case "EST":
+		case "CDT":
+			zone = new TimeZone("-05");
+			break;
+		case "CST":
+		case "MDT":
+			zone = new TimeZone("-06");
+			break;
+		case "MST":
+		case "PDT":
+			zone = new TimeZone("-07");
+			break;
+		case "PST":
+			zone = new TimeZone("-08");
+			break;
+		case "1A":
+			zone = new TimeZone("-01");
+			break;
+		case "1M":
+			zone = new TimeZone("-12");
+			break;
+		case "1N":
+			zone = new TimeZone("+01");
+			break;
+		case "1Y":
+			zone = new TimeZone("+12");
+			break;
+		case "GMT":
+		case "UT":
+		case "1Z":
+			zone = new TimeZone.utc();
+			break;
+		default:
+			zone = new TimeZone(pieces[4]);
+			break;
 	}
+	return new DateTime(zone, year, month, day, hour, minute, second);	
 }