windows testing

Your Name · Your Name · commit e3312b8d4f71 · 2026-01-31T18:19:18.000-05:00
diff --git a/daw/README.md b/daw/README.md
@@ -8,6 +8,10 @@ cmake ..
 cmake --build .
 ```
 
+## Windows
+
+to investigate: VS2026 has a compile error that VS2022 doesn't. stick to 2022 for now.
+
 ## Assets
 
 raw gltf files right out of blender aren't great, so we use gltfpack on the result: run
diff --git a/daw/assets/kitskeys.glb b/daw/assets/kitskeys.glb
diff --git a/daw/src/chorus/chorus.cpp b/daw/src/chorus/chorus.cpp
@@ -97,6 +97,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         ImGui::TextWrapped(
             "KitsChorus is currently based on the Juno-60 chorus algorithm. More algorithms Soon(tm), maybe?");
         kitgui::DebugParam<ParamsFeature, Params::Rate>(mParams);
diff --git a/daw/src/distort/distort.cpp b/daw/src/distort/distort.cpp
@@ -178,6 +178,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         kitgui::DebugParam<ParamsFeature, Params::Algorithm>(mParams);
         kitgui::DebugParam<ParamsFeature, Params::Gain>(mParams);
         kitgui::DebugParam<ParamsFeature, Params::Tone>(mParams);
diff --git a/daw/src/example/example.cpp b/daw/src/example/example.cpp
@@ -64,6 +64,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         ImGui::TextWrapped("UI example (TODO)");
         /*mParams.DebugImGui();*/
     }
diff --git a/daw/src/freqshift/freqshift.cpp b/daw/src/freqshift/freqshift.cpp
@@ -87,6 +87,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         ImGui::TextWrapped(
             "KitFreqsOut shifts the frequencies of the input sound by a fixed hz amount. this is most useful for "
             "inharmonic sounds; aka sound effects, percussion, etc. Use it on a voice clip to get alien sounds, or "
diff --git a/daw/src/gui/debugui.h b/daw/src/gui/debugui.h
@@ -77,6 +77,8 @@ class BaseParamKnob : public kitgui::Knob {
         clap_param_info_t info;
         mParam.FillInformation(id, &info);
         mName = info.name;
+        mMin = info.min_value;
+        mMax = info.max_value;
     }
     ~BaseParamKnob() override = default;
     clap_id GetParamId() const { return mId; }
diff --git a/daw/src/gui/kitguiFeature.h b/daw/src/gui/kitguiFeature.h
@@ -37,6 +37,8 @@ class KitguiFeature : public clapeze::GuiFeature {
     bool Show() override;
     bool Hide() override;
 
+    kitgui::Context& GetContext() { return mCtx; };
+
    private:
     clapeze::PluginHost& mHost;
     kitgui::Context mCtx;
diff --git a/daw/src/harmonizer/harmonizer.cpp b/daw/src/harmonizer/harmonizer.cpp
@@ -123,6 +123,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         ImGui::TextWrapped(
             "This is a pitch shift effect inspired by the EvenTide H910, the very first realtime pitch shift hardware "
             "module. This, of course, means the way it achieves this effect is kind of nasty, and not very "
diff --git a/daw/src/keysynth/keysynth.cpp b/daw/src/keysynth/keysynth.cpp
@@ -206,7 +206,7 @@ class Processor : public clapeze::InstrumentProcessor<ParamsFeature::ProcessorHa
             // filter
             // range from 8hz to 12.5khz
             float filterNote = kitdsp::lerpf(0.0f, 127.0f, params.Get<Params::FilterCutoff>());
-            float res = params.Get<Params::FilterResonance>();
+            float res = params.Get<Params::FilterResonance>() * 0.89f; // 0.85 acts as cap, experimentally determined
             float filterSteepness = 0.5f;  // steeper means "achieves self-oscillation quicker"
             float filterQ = 0.5f * std::exp(filterSteepness * (res / (1 - res)));  // [0, 1] -> [0.5, inf]
             float filterModMix = params.Get<Params::FilterModMix>();
@@ -302,15 +302,37 @@ class GuiApp : public kitgui::BaseApp {
         mScene->Load("assets/kitskeys.glb");
         // TODO: to update all this if the viewport changes
         mScene->SetViewport({600.0f, 400.0f});
+        mScene->SetBrightness(0.0025f); // idk why magnum is so intense by default, to investigate
 
         struct KnobSetupInfo {
             Params param;
             std::string node;
         };
         const std::vector<KnobSetupInfo> knobs{
-            {Params::PolyMode, "knob-mid-Davies-1900h"},         {Params::PolyCount, "knob-mid-Davies-1900h.001"},
-            {Params::OscOctave, "knob-mid-Davies-1900h.003"},    {Params::OscTune, "knob-mid-Davies-1900h.004"},
-            {Params::FilterCutoff, "knob-mid-Davies-1900h.006"}, {Params::FilterResonance, "knob-mid-Davies-1900h.005"},
+            {Params::PolyMode, "knob-mid-Davies-1900h"},
+            {Params::PolyCount, "knob-mid-Davies-1900h.001"},
+            {Params::PolyChordType, "knob-mid-Davies-1900h.002"},
+            {Params::OscOctave, "knob-mid-Davies-1900h.003"},
+            {Params::OscTune, "knob-mid-Davies-1900h.004"},
+            {Params::OscModMix, "knob-small-trimpot-R-0904N-L-25KC"},
+            {Params::OscModAmount, "knob-small-trimpot-R-0904N-L-25KC.001"},
+            {Params::FilterCutoff, "knob-mid-Davies-1900h.006"},
+            {Params::FilterResonance, "knob-mid-Davies-1900h.005"},
+            {Params::FilterModMix, "knob-small-trimpot-R-0904N-L-25KC.002"},
+            {Params::FilterModAmount, "knob-small-trimpot-R-0904N-L-25KC.003"},
+            {Params::LfoRate, "knob-mid-Davies-1900h.008"},
+            {Params::LfoShape, "knob-mid-Davies-1900h.009"},
+            {Params::EnvAttack, "knob-mid-Davies-1900h.010"},
+            {Params::EnvDecay, "knob-mid-Davies-1900h.011"},
+            {Params::EnvSustain, "knob-mid-Davies-1900h.012"},
+            {Params::EnvRelease, "knob-mid-Davies-1900h.013"},
+            {Params::VcaGain, "knob-mid-Davies-1900h.007"},
+            {Params::VcaLfoAmount, "knob-small-trimpot-R-0904N-L-25KC.004"},
+        };
+
+        // TODO
+        const std::vector<KnobSetupInfo> toggles{
+            {Params::VcaEnvDisabled, "switch-toggle"},
         };
 
         // TODO: data-driven
@@ -367,6 +389,7 @@ class GuiApp : public kitgui::BaseApp {
         kitgui::DebugParam<ParamsFeature, Params::VcaLfoAmount>(mParams);
     }
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         mScene->Update();
         // imgui
         if (ImGui::BeginMenuBar()) {
@@ -379,12 +402,20 @@ class GuiApp : public kitgui::BaseApp {
         for (auto& knob : mKnobs) {
             clap_id id = knob->GetParamId();
             double raw = mParams.GetMainHandle().GetRawValue(id);
+
+            auto pos = mScene->GetObjectScreenPositionByName(knob->GetSceneNode());
+            knob->mShowDebug = mShowDebugWindow;
             if (knob->Update(raw)) {
                 mParams.GetMainHandle().SetRawValue(id, raw);
             }
             // we assume the knob is at 12-o-clock, and knobs have 0.75turn(270deg) ranges
+            auto normalizedValue = kitdsp::clamp((raw - knob->mMin) / (knob->mMax - knob->mMin), 0.0, 1.0);
             constexpr float maxTurn = kitdsp::kPi * 2.0f * 0.75f;
-            mScene->SetObjectRotationByName(knob->GetSceneNode(), (static_cast<float>(raw) - 0.5f) * -maxTurn);
+            mScene->SetObjectRotationByName(knob->GetSceneNode(), (static_cast<float>(normalizedValue) - 0.5f) * -maxTurn);
+        }
+
+        if(ImGui::IsKeyPressed(ImGuiKey_GraveAccent)) {
+            mShowDebugWindow = !mShowDebugWindow;
         }
 
         if (mShowDebugWindow) {
@@ -401,7 +432,7 @@ class GuiApp : public kitgui::BaseApp {
     ParamsFeature& mParams;
     std::unique_ptr<kitgui::Scene> mScene;
     std::vector<std::unique_ptr<kitgui::BaseParamKnob>> mKnobs;
-    bool mShowDebugWindow = false;
+    bool mShowDebugWindow = true;
 };
 #endif
 
@@ -446,7 +477,7 @@ class Plugin : public InstrumentPlugin {
 #if KITSBLIPS_ENABLE_GUI
         ConfigFeature<clapeze::AssetsFeature>(GetHost());
         // aspect ratio 1.5
-        kitgui::SizeConfig cfg{600, 400, true, true};
+        kitgui::SizeConfig cfg{600, 400, false, true};
         ConfigFeature<KitguiFeature>(
             GetHost(), [&params](kitgui::Context& ctx) { return std::make_unique<GuiApp>(ctx, params); }, cfg);
 #endif
diff --git a/daw/src/snecho/snecho.cpp b/daw/src/snecho/snecho.cpp
@@ -206,6 +206,7 @@ class GuiApp : public kitgui::BaseApp {
    public:
     GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}
     void OnUpdate() override {
+        mParams.FlushFromAudio();
         ImGui::TextWrapped(
             "With Snecho, I have created an emulation of the echo effect found in the SPC700 chip, used in the "
             "SNES/Super Famicom consoles."
diff --git a/kitgui/examples/3dscene.cpp b/kitgui/examples/3dscene.cpp
@@ -44,6 +44,10 @@ class MyApp : public kitgui::BaseApp {
                     GetContext().SetSizeDirectly(w, h, false);
                 }
 
+                if(ImGui::DragFloat("brightness", &mBrightness, 0.0001, 0.0f, 1.0f, "%.6f")) {
+                    mScene->SetBrightness(mBrightness);
+                }
+
                 if (ImGui::ColorEdit4("bgcolor", reinterpret_cast<float*>(&mClearColor))) {
                     GetContext().SetClearColor(mClearColor);
                 }
@@ -56,16 +60,17 @@ class MyApp : public kitgui::BaseApp {
    private:
     std::unique_ptr<kitgui::Scene> mScene;
     bool mShowUi = true;
-    std::string mFilePath{PROJECT_DIR "/assets/duck.glb"};
+    std::string mFilePath{PROJECT_DIR "/../daw/assets/kitskeys.glb"};
     kitgui::Color4 mClearColor{0.1f, 0.4f, 0.4f, 1.0f};
+    float mBrightness = 0.0025f;
 };
 
 int main() {
     kitgui::Context::init(kitgui::WindowApi::Any, "kitgui");
 
     {
         kitgui::Context ctx1([](kitgui::Context& ctx) { return std::make_unique<MyApp>(ctx); });
-        ctx1.SetSizeConfig({400, 400, true, false});
+        ctx1.SetSizeConfig({600, 400, true, false});
         ctx1.Create(true);
         ctx1.Show();
 
diff --git a/kitgui/include/kitgui/controls/knob.h b/kitgui/include/kitgui/controls/knob.h
@@ -17,9 +17,12 @@ class Knob {
     std::optional<Vector2> mPos = {};
     // if not provided, works off of imgui normal sizing
     std::optional<float> mWidth = {};
+    double mMin = 0.0f;
+    double mMax = 1.0f;
+    double mDefault = 0.5f;
 
-    float minAngleRadians = kPi * 0.75f;
-    float maxAngleRadians = kPi * 2.25f;
+    float mMinAngleRadians = kPi * 0.75f;
+    float mMaxAngleRadians = kPi * 2.25f;
 
    protected:
     virtual const std::string& GetName() const {
diff --git a/kitgui/include/kitgui/gfx/scene.h b/kitgui/include/kitgui/gfx/scene.h
@@ -24,6 +24,8 @@ class Scene {
     void Draw();
     /** Sets the viewport size, recalculating any cameras as needed. */
     void SetViewport(const kitgui::Vector2& size);
+    /** Sets scene overall brightness, from 0-1+. nullopt means fullbright. */
+    void SetBrightness(std::optional<float> brightness);
 
     // These methods are added as needed, so no rhyme or reason to what's supported really
     void PlayAnimationByName(std::string_view name);
diff --git a/kitgui/src/controls/knob.cpp b/kitgui/src/controls/knob.cpp
@@ -4,6 +4,7 @@
 #include <imgui_internal.h>
 #include <cmath>
 #include <string>
+#include <algorithm>
 
 namespace kitgui {
 bool Knob::Update(double& rawValueInOut) {
@@ -23,10 +24,8 @@ bool Knob::Update(double& rawValueInOut) {
 
     ImGuiSliderFlags drag_behaviour_flags =
         static_cast<ImGuiSliderFlags>(ImGuiSliderFlags_Vertical) | ImGuiSliderFlags_AlwaysClamp;
-    double min = 0.0;
-    double max = 1.0;
     auto value_changed =
-        ImGui::DragBehavior(gid, ImGuiDataType_Double, &rawValueInOut, 0, &min, &max, "%.2f", drag_behaviour_flags);
+        ImGui::DragBehavior(gid, ImGuiDataType_Double, &rawValueInOut, 0, &mMin, &mMax, "%.2f", drag_behaviour_flags);
 
     auto is_active = ImGui::IsItemActive();
     auto is_hovered = ImGui::IsItemHovered();
@@ -48,12 +47,13 @@ bool Knob::Update(double& rawValueInOut) {
 
     if (mShowDebug) {
         // Drawing using imgui primitives
-        auto angle_min = minAngleRadians;
-        auto angle_max = maxAngleRadians;
+        auto angle_min = mMinAngleRadians;
+        auto angle_max = mMaxAngleRadians;
+        auto normalizedValue = std::clamp((rawValueInOut - mMin) / (mMax - mMin), 0.0, 1.0);
 
         auto radius = itemWidth * 0.5f;
         ImVec2 center = {screen_pos[0] + radius, screen_pos[1] + radius};
-        auto angle = angle_min + (angle_max - angle_min) * rawValueInOut;
+        auto angle = angle_min + (angle_max - angle_min) * normalizedValue;
         auto angle_cos = std::cos(static_cast<float>(angle));
         auto angle_sin = std::sin(static_cast<float>(angle));
         auto* colors = ImGui::GetStyle().Colors;
diff --git a/kitgui/src/gfx/lights.cpp b/kitgui/src/gfx/lights.cpp
@@ -98,8 +98,8 @@ void LightCache::LoadLights(Trade::AbstractImporter& importer) {
             lightInfo.debugName = fmt::format("{}", i);
         }
 
-        auto light = std::optional<Trade::LightData>{importer.light(i)};
-        if (!light) {
+        lightInfo.light = std::optional<Trade::LightData>{importer.light(i)};
+        if (!lightInfo.light) {
             kitgui::log::error(fmt::format("Cannot load light {} {}", i, importer.lightName(i)));
             continue;
         }
diff --git a/kitgui/src/gfx/lights.h b/kitgui/src/gfx/lights.h
@@ -29,7 +29,7 @@ struct LightCache {
     std::vector<LightInfo> mLights;
     size_t mLightCount{};
     bool mShadeless{false};
-    float mBrightness{0.5f};
+    float mBrightness{0.0025f};
     std::vector<Magnum::Vector4> mLightPositions;
     std::vector<Magnum::Color3> mLightColors;
 
diff --git a/kitgui/src/gfx/scene.cpp b/kitgui/src/gfx/scene.cpp
@@ -61,6 +61,7 @@ struct Scene::Impl {
     void Update();
     void Draw();
     void SetViewport(const kitgui::Vector2& size);
+    void SetBrightness(std::optional<float> brightness);
 
     void PlayAnimationByName(std::string_view name);
     void SetObjectRotationByName(std::string_view name, float angleRadians);
@@ -237,6 +238,7 @@ void Scene::Impl::LoadImpl(Magnum::Trade::AbstractImporter& importer, std::strin
        that are not part of the hierarchy. There can be multiple mesh
        assignments for one object, simply add one drawable for each. */
     if (scene->hasField(Trade::SceneField::Mesh)) {
+        // TODO: can we redo this if shadeless changes?
         for (const auto& meshMaterial : scene->meshesMaterialsAsArray()) {
             const uint32_t objectId = meshMaterial.first();
             const uint32_t meshId = meshMaterial.second().first();
@@ -247,12 +249,11 @@ void Scene::Impl::LoadImpl(Magnum::Trade::AbstractImporter& importer, std::strin
         }
     }
 
-    /* Initialize light colors for all instantiated shaders */
-    const auto lightColorsBrightness = mLightCache.CalculateLightColors();
-    mDrawableCache.SetLightColors(lightColorsBrightness);
-
     /* Import animations */
     mAnimationCache.LoadAnimations(importer, mSceneObjects);
+
+    /* We need to calculate SetBrightness at least once to set up light colors/intensity */
+    SetBrightness(mLightCache.mBrightness);
 }
 
 void Scene::SetViewport(const kitgui::Vector2& size) {
@@ -286,6 +287,22 @@ void Scene::Impl::SetViewport(const kitgui::Vector2& size) {
     }
 }
 
+void Scene::SetBrightness(std::optional<float> brightness) {
+    mImpl->SetBrightness(brightness);
+}
+
+void Scene::Impl::SetBrightness(std::optional<float> brightness) {
+    if(brightness) {
+        mLightCache.mBrightness = *brightness;
+        mLightCache.mShadeless = false;
+    } else {
+        mLightCache.mShadeless = true;
+    }
+    const auto lightColorsBrightness = mLightCache.CalculateLightColors();
+    mDrawableCache.SetLightColors(lightColorsBrightness);
+}
+
+
 void Scene::PlayAnimationByName(std::string_view name) {
     mImpl->PlayAnimationByName(name);
 }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ class GuiApp : public kitgui::BaseApp {`
`64`	`64`	`public:`
`65`	`65`	`GuiApp(kitgui::Context& ctx, ParamsFeature& params) : kitgui::BaseApp(ctx), mParams(params) {}`
`66`	`66`	`void OnUpdate() override {`
	`67`	`+ mParams.FlushFromAudio();`
`67`	`68`	`ImGui::TextWrapped("UI example (TODO)");`
`68`	`69`	`/mParams.DebugImGui();/`
`69`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,8 @@ class BaseParamKnob : public kitgui::Knob {`
`77`	`77`	`clap_param_info_t info;`
`78`	`78`	`mParam.FillInformation(id, &info);`
`79`	`79`	`mName = info.name;`
	`80`	`+ mMin = info.min_value;`
	`81`	`+ mMax = info.max_value;`
`80`	`82`	`}`
`81`	`83`	`~BaseParamKnob() override = default;`
`82`	`84`	`clap_id GetParamId() const { return mId; }`