Skip to content

Commit 6287f92

Browse files
SECURITY FIX - Dont rely on x forwarded for to check for localhost addresses as it can be spoofed
1 parent 32b1f00 commit 6287f92

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

server/modules/auth_utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88
from flask import jsonify, request
99

1010
def is_local_request():
11-
# Honour X-Forwarded-For if present (take first IP)
12-
xff = request.headers.get("X-Forwarded-For", "")
13-
client_ip = (xff.split(",")[0].strip() if xff else request.remote_addr) or ""
11+
client_ip = request.remote_addr or ""
1412
return client_ip in ("127.0.0.1", "::1")
1513

1614
def web_login_required_or_local(fn):

0 commit comments

Comments
 (0)