Don't log successful healthchecks and clean up

Author: alexiri

astra_app/config/settings.py

@@ -1,4 +1,5 @@
 import datetime
+import logging
 import os
 import sys
 from pathlib import Path
@@ -684,10 +685,22 @@ def _parse_email_url(email_url: str) -> dict[str, Any]:
 
 # Logging
 # Ensure app logs (including FreeIPA integration) are visible in container stdout.
+class HealthEndpointFilter(logging.Filter):
+    def filter(self, record: logging.LogRecord) -> bool:
+        message = record.getMessage()
+        if "/healthz" in message or "/readyz" in message:
+            return " 200 " not in message
+        return True
+
+
 LOGGING = {
     'version': 1,
     'disable_existing_loggers': False,
-    'filters': {},
+    'filters': {
+        'health_endpoint': {
+            '()': 'config.settings.HealthEndpointFilter',
+        },
+    },
     'formatters': {
         'console': {
             'format': '[{asctime}] {levelname} {name}: {message}',
@@ -723,6 +736,7 @@ def _parse_email_url(email_url: str) -> dict[str, Any]:
         'django.server': {
             'handlers': ['console'],
             'level': 'INFO',
+            'filters': ['health_endpoint'],
             'propagate': False,
         },
         # Django security events

astra_app/core/tests/test_logging_filters.py

@@ -0,0 +1,45 @@
+from __future__ import annotations
+
+import logging
+
+from django.test import SimpleTestCase
+
+
+class LoggingFilterTests(SimpleTestCase):
+    def test_health_endpoint_filter(self) -> None:
+        from config.settings import HealthEndpointFilter
+
+        filt = HealthEndpointFilter()
+
+        record_ok = logging.LogRecord(
+            name="django.server",
+            level=logging.INFO,
+            pathname=__file__,
+            lineno=1,
+            msg='"GET /healthz HTTP/1.1" 200 12',
+            args=(),
+            exc_info=None,
+        )
+        self.assertFalse(filt.filter(record_ok))
+
+        record_error = logging.LogRecord(
+            name="django.server",
+            level=logging.INFO,
+            pathname=__file__,
+            lineno=1,
+            msg='"GET /healthz HTTP/1.1" 503 12',
+            args=(),
+            exc_info=None,
+        )
+        self.assertTrue(filt.filter(record_error))
+
+        record_other = logging.LogRecord(
+            name="django.server",
+            level=logging.INFO,
+            pathname=__file__,
+            lineno=1,
+            msg='"GET /users HTTP/1.1" 200 12',
+            args=(),
+            exc_info=None,
+        )
+        self.assertTrue(filt.filter(record_other))

astra_app/healthcheck_server.py

@@ -11,8 +11,5 @@ astra.almalinux.org {
         lb_retries 2
 
         health_uri /readyz
-        health_interval 10s
-        health_timeout 5s
-        health_up_status 200
     }
 }