fix(gencloud-test): use steps.run_tests.outcome instead of job.status

job.status does not reflect failures of steps inside the same composite action - the parent job's status only flips after the composite returns, so inside the composite an if: always() follow-up step sees job.status == "success" even when an earlier composite step failed. The job summary and Mattermost message therefore would report "Test: passed" for runs whose test step had actually failed.

Tag the "Run image tests" step with id: run_tests and have the summary / Mattermost steps read steps.run_tests.outcome instead. When an earlier composite step fails (install, KVM probe, etc.) run_tests is skipped and its outcome is "skipped" - correctly treated as "not success" by the if/ternary.

Author: yuravk

.github/actions/gencloud-test-steps/action.yml

@@ -179,6 +179,7 @@ runs:
         done
 
     - name: Run image tests
+      id: run_tests
       shell: bash
       env:
         ALMA_ARCH: ${{ inputs.alma_arch }}
@@ -292,7 +293,13 @@ runs:
         IMAGE_FILENAME: ${{ inputs.image_filename }}
         IMAGE_URL: ${{ inputs.image_url }}
         SUBTYPE: ${{ inputs.subtype }}
-        JOB_STATUS: ${{ job.status }}
+        # job.status doesn't reflect failures of steps inside the same
+        # composite action (the parent job's status flips only after this
+        # composite returns) - so read the test step's own outcome.
+        # When a step BEFORE run_tests fails (install, KVM probe, ...),
+        # run_tests is skipped and its outcome is "skipped", which is
+        # correctly treated as "not success" below.
+        TESTS_OUTCOME: ${{ steps.run_tests.outcome }}
       run: |
         # Job summary
         {
@@ -308,7 +315,7 @@ runs:
           if [ -n "${SYSTEM_ARCH:-}" ]; then
             echo "- **System architecture**: \`${SYSTEM_ARCH}\`"
           fi
-          if [ "${JOB_STATUS}" = "success" ]; then
+          if [ "${TESTS_OUTCOME}" = "success" ]; then
             echo "- **Test**: passed ✅"
           else
             echo "- **Test**: failed ❌"
@@ -346,4 +353,4 @@ runs:
           ${{ inputs.subtype == 'gencloud_ext4' && '**Subtype**: `gencloud_ext4` (ext4 root)' || '' }}
           ${{ env.ALMA_RELEASE && format('**AlmaLinux release**: `{0}`', env.ALMA_RELEASE) || '' }}
           ${{ env.SYSTEM_ARCH && format('**System architecture**: `{0}`', env.SYSTEM_ARCH) || '' }}
-          **Test**: ${{ job.status == 'success' && 'passed ✅' || 'failed ❌' }}
+          **Test**: ${{ steps.run_tests.outcome == 'success' && 'passed ✅' || 'failed ❌' }}