Refactor code and add more test cases

The code has been refactored to remove redundancies, fix incorrect logic, and improve readability. In addition, multiple test cases have been added to verify the absence of diagnostics when accessing a value after checking for failure.

Author: AlmarAubel

CSharpFunctionalExtensions.Analyzers.Tests/UseResultValueWithoutCheckTests/UseResultValueWithoutCheckTests.cs

@@ -91,6 +91,17 @@ public async Task Test_AccessValueAfterCheckForFailure(string source)
     {
         await VerifyDiagnosticAsync(AddContext(source), options: CSharpTestOptions());
     }
+    
+    [Theory]
+    [InlineData("if(!result.IsFailure) Console.WriteLine(result.Value);")]
+    [InlineData(" var x = result.IsFailure ? 0 : result.Value;")]
+    [InlineData(" var x = !result.IsSuccess ? 0 : result.Value;")]
+    [InlineData(" var x = result.IsSuccess ? result.Value : 0;")]
+    [InlineData(" var x = !result.IsFailure ? result.Value : 0;")]
+    public async Task TestNoDiagnostic_AccessValueAfterCheckForFailure(string source)
+    {
+        await VerifyNoDiagnosticAsync(AddContext(source), options: CSharpTestOptions());
+    }
 
     [Fact]
     public async Task Test_AccessWithinReturnStatement()

CSharpFunctionalExtensions.Analyzers/UseResultValueWithoutCheck/ResultValueWalker.cs

@@ -73,10 +73,11 @@ private void NodeWalkerInternal(SyntaxNode node)
     private void CheckTernaryCondition(ConditionalExpressionSyntax ternary)
     {
         _result.CheckResult = DetermineCheckResult(ternary.Condition);
+        _result.Terminated = true;
         _result.AccessedValue = _result.CheckResult switch
         {
             CheckResult.CheckedSuccess => ternary.WhenTrue == _memberAccessValueResult && ternary.WhenFalse != _memberAccessValueResult,
-            CheckResult.CheckedFailure => ternary.WhenFalse == _memberAccessValueResult && ternary.WhenTrue != _memberAccessValueResult,
+            CheckResult.CheckedFailure => ternary.WhenTrue == _memberAccessValueResult,
             _ => _result.AccessedValue
         };
     }
@@ -183,8 +184,6 @@ private CheckResult DetermineCheckResult(ExpressionSyntax condition)
                 {
                     RecursivePatternSyntax recursivePatternSyntax => CheckedRecusivePattern(recursivePatternSyntax),
                 };
-
-                break;
             case SwitchExpressionSyntax switchExpressionSyntax:
                 throw new NotImplementedException();
         }

CSharpFunctionalExtensions.Analyzers/UseResultValueWithoutCheck/WalkerResult.cs

@@ -8,7 +8,7 @@ internal class WalkerResult
 
     public bool CorrectUsage =>
         (AccessedValue && CheckResult == CheckResult.CheckedSuccess) || 
-        (CheckResult == CheckResult.CheckedFailure && Terminated && !AccessedValue);
+        (CheckResult == CheckResult.CheckedFailure && Terminated || !AccessedValue);
 
     public void Reset()
     {

build/Build.cs

@@ -151,7 +151,6 @@ class Build : NukeBuild
         .Requires(() => NugetApiUrl)
         .Requires(() => NugetApiKey)
         .OnlyWhenDynamic(() => IsTag|| Repository.IsOnReleaseBranch(), "No Tag added to commit")
-        .Triggers(CreateRelease)
         .Executes(() =>
         {
             DotNetNuGetPush(s =>