Skip to content

Commit 9d291c3

Browse files
update
2 parents ab48dbc + 93c246d commit 9d291c3

File tree

48 files changed

+1304
-562
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1304
-562
lines changed

.github/workflows/build_ascent_win.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
jobs:
88
build_windows_msvc_base:
99
name: MSVC Base Release
10-
runs-on: windows-2019
10+
runs-on: windows-2025
1111
steps:
1212
- name: Setup MPI
1313
uses: mpi4py/setup-mpi@v1

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ and this project aspires to adhere to [Semantic Versioning](https://semver.org/s
4747

4848
### Fixed
4949
- Fix parse_camera where order you apply camera operations matters.
50+
- Fixed WarpX filter that was not allowing for rendering of the output streamlines
5051
- Fixed Uniform Grid bug only accepting 2D slices along the Z-axis.
5152
- Resolved a few cases where MPI_COMM_WORLD was used instead instead of the selected MPI communicator.
5253
- Resolved a bug where a sharing a coordset between multiple polytopal topologies would corrupt mesh processing.
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
diff --git a/vtkm/rendering/raytracing/Camera.cxx b/vtkm/rendering/raytracing/Camera.cxx
2+
index 10febf39f..5b6500c20 100644
3+
--- a/vtkm/rendering/raytracing/Camera.cxx
4+
+++ b/vtkm/rendering/raytracing/Camera.cxx
5+
@@ -830,11 +830,6 @@ void Camera::FindSubset(const vtkm::Bounds& bounds)
6+
transformed[2] = (transformed[2] * 0.5f + 0.5f);
7+
zmin = vtkm::Min(zmin, transformed[2]);
8+
zmax = vtkm::Max(zmax, transformed[2]);
9+
- // skip if outside near and far clipping
10+
- if (transformed[2] < 0 || transformed[2] > 1)
11+
- {
12+
- continue;
13+
- }
14+
xmin = vtkm::Min(xmin, transformed[0]);
15+
ymin = vtkm::Min(ymin, transformed[1]);
16+
xmax = vtkm::Max(xmax, transformed[0]);
17+
@@ -861,7 +856,7 @@ void Camera::FindSubset(const vtkm::Bounds& bounds)
18+
//
19+
// scene is behind the camera
20+
//
21+
- if (zmax < 0 || xmin >= xmax || ymin >= ymax)
22+
+ if (xmin >= xmax || ymin >= ymax)
23+
{
24+
this->SubsetWidth = 1;
25+
this->SubsetHeight = 1;

scripts/build_ascent/build_ascent.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,11 @@ if [ ! -d ${vtkm_src_dir} ]; then
655655
echo "**** Downloading ${vtkm_tarball}"
656656
curl -L https://gitlab.kitware.com/vtk/vtk-m/-/archive/${vtkm_version}/vtk-m-${vtkm_version}.tar.gz -o ${vtkm_tarball}
657657
tar ${tar_extra_args} -xzf ${vtkm_tarball} -C ${source_dir}
658+
659+
# apply patches
660+
cd ${vtkm_src_dir}
661+
patch -p1 < ${script_dir}/2025_06_18_vtkm_z_extents_ray_culling_bugfix_viskores_mr109.patch
662+
cd ${root_dir}
658663
fi
659664

660665

@@ -766,7 +771,7 @@ fi # build_camp
766771
################
767772
# RAJA
768773
################
769-
raja_version=v2025.03.1
774+
raja_version=v2025.03.2
770775
raja_src_dir=$(ospath ${source_dir}/RAJA-${raja_version})
771776
raja_build_dir=$(ospath ${build_dir}/raja-${raja_version})
772777
raja_install_dir=$(ospath ${install_dir}/raja-${raja_version}/)

scripts/uberenv_configs/packages/ascent/package.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,14 +198,14 @@ class Ascent(CMakePackage, CudaPackage):
198198
#######################
199199
with when("+raja"):
200200
depends_on("raja")
201-
depends_on("[email protected]:2024.02.99", when="@0.9.3:")
201+
depends_on("[email protected]:2026.12.99", when="@0.9.3:")
202202
depends_on("raja+openmp", when="+openmp")
203203
depends_on("raja~openmp", when="~openmp")
204204

205205
with when("+umpire"):
206206
depends_on("umpire")
207207
depends_on("umpire@:2023.06.0", when="@:0.9.2")
208-
depends_on("[email protected]:2024.02.99", when="@0.9.3:")
208+
depends_on("[email protected]:2026.12.99", when="@0.9.3:")
209209

210210
#######################
211211
# BabelFlow

scripts/uberenv_configs/packages/raja/package.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@ class Raja(CachedCMakePackage, CudaPackage, ROCmPackage):
3333

3434
version("develop", branch="develop", submodules=submodules)
3535
version("main", branch="main", submodules=submodules)
36+
version(
37+
"2025.03.2",
38+
tag="v2025.03.2",
39+
commit="6e36a94380adbe88fed11a3213fc08461428ece0",
40+
submodules=submodules,
41+
preferred=True,
42+
)
3643
version(
3744
"2025.03.1",
3845
tag="v2025.03.1",

scripts/uberenv_configs/packages/umpire/package.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ class Umpire(CachedCMakePackage, CudaPackage, ROCmPackage):
3030
tag="v2025.03.0",
3131
commit="1ed0669c57f041baa1f1070693991c3a7a43e7ee",
3232
submodules=False,
33+
preferred=True,
3334
)
3435
version(
3536
"2024.07.0",

scripts/uberenv_configs/packages/vtk-m/package.py

Lines changed: 22 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
# Copyright 2013-2024 Lawrence Livermore National Security, LLC and other
2-
# Spack Project Developers. See the top-level COPYRIGHT file for details.
1+
# Copyright Spack Project Developers. See COPYRIGHT file for details.
32
#
43
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
54

65

76
import os
87
import sys
98

9+
from spack.build_systems.cmake import CMakeBuilder
1010
from spack.package import *
1111

1212

@@ -21,7 +21,7 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
2121
homepage = "https://m.vtk.org/"
2222
maintainers("kmorel", "vicentebolea")
2323

24-
url = "https://github.com/Kitware/VTK-m/archive/refs/tags/v2.3.0.tar.gz"
24+
url = "https://github.com/Kitware/VTK-m/archive/refs/tags/v2.2.0.tar.gz"
2525
git = "https://github.com/Kitware/VTK-m.git"
2626
tags = ["e4s"]
2727

@@ -31,10 +31,10 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
3131
version("release", branch="release")
3232
version(
3333
"2.3.0",
34-
sha256="f40d6b39ca1bcecd232571c92ce606627811909f4e21972d1823e605f686bcf5",
34+
sha256="d105ee2de5cfa600f1b4b3d2061f97bebd581a0ae1c86c6174af4e8128f83c54",
3535
preferred=True,
3636
)
37-
version("2.2.0", sha256="d105ee2de5cfa600f1b4b3d2061f97bebd581a0ae1c86c6174af4e8128f83c54")
37+
version("2.2.0", sha256="f40d6b39ca1bcecd232571c92ce606627811909f4e21972d1823e605f686bcf5")
3838
version("2.1.0", sha256="7b224f1f91e5ef140e193338bf091133b1e9f40d323bccdc8bb80bfc2675e6ea")
3939
version("2.0.0", sha256="21c8b2cb8f3d4116a4f90c1d08c9f5e27b25c7a0951f7b403eced94576f84880")
4040
version("1.9.0", sha256="f9862d9d24deae32063ba1ea3d9a42900ac0cdd7f98412d960249a7cac35d47f")
@@ -53,8 +53,6 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
5353
version("1.2.0", sha256="44596e88b844e7626248fb8e96a38be25a0e585a22256b1c859208b23ef45171")
5454
version("1.1.0", sha256="55f42c417d3a41893230b2fd3b5c192daeee689a2193de10bf22a1ef5c24c7ad")
5555

56-
depends_on("cxx", type="build") # generated
57-
5856
variant("shared", default=False, description="build shared libs")
5957

6058
variant("doubleprecision", default=True, description="enable double precision")
@@ -88,6 +86,9 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
8886
variant("tbb", default=(sys.platform == "darwin"), description="build TBB support")
8987
variant("sycl", default=False, description="Build with SYCL backend")
9088

89+
depends_on("c", type="build")
90+
depends_on("cxx", type="build")
91+
9192
depends_on("[email protected]:", type="build") # CMake >= 3.12
9293
depends_on("[email protected]:", when="+rocm", type="build") # CMake >= 3.18
9394

@@ -153,23 +154,23 @@ class VtkM(CMakePackage, CudaPackage, ROCmPackage):
153154

154155
# VTK-M PR#3215
155156
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3215
156-
patch("vtkm-mr3215-ext-geom-fix.patch", when="@2.1:2.2")
157+
patch("vtkm-mr3215-ext-geom-fix.patch", when="@2.1")
157158

158159
# VTK-M PR#2972
159160
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2972
160161
patch("vtkm-cuda-swap-conflict-pr2972.patch", when="@1.9 +cuda ^cuda@12:")
161162

162163
# VTK-M PR#3160
163164
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3160
164-
patch("mr3160-rocthrust-fix.patch", when="@2.1:2.2")
165+
patch("mr3160-rocthrust-fix.patch", when="@2.1")
165166

166167
# VTK-M PR#3258
167168
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3258
168-
patch("mr3258-fix-typo-thrust-dependency-with-rocm.patch", when="@:2.2.0")
169+
patch("mr3258-fix-typo-thrust-dependency-with-rocm.patch", when="@2.2.0")
169170

170171
# VTK-M PR#3259
171172
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3259
172-
patch("mr3259-thrust-is_arithmetic-fix.patch", when="@2.0.0:2.3.0 +cuda ^[email protected]:")
173+
patch("mr3259-thrust-is_arithmetic-fix.patch", when="@2.0.0:2.2.0 +cuda ^[email protected]:")
173174

174175
# VTK-m PR#3271
175176
# https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3271
@@ -238,7 +239,7 @@ def cmake_args(self):
238239
os.environ["TBB_ROOT"] = spec["tbb"].prefix
239240

240241
if "+kokkos" in spec and "+rocm" in spec and spec.satisfies("^kokkos@4:"):
241-
options.append(f"-DCMAKE_CXX_COMPILER:BOOL={spec['hip'].prefix.bin.hipcc}")
242+
options.append(f"-DCMAKE_CXX_COMPILER:FILEPATH={spec['hip'].prefix.bin.hipcc}")
242243

243244
# Support for relocatable code
244245
if "~shared" in spec and "+fpic" in spec:
@@ -250,7 +251,7 @@ def cmake_args(self):
250251
options.append("-DCMAKE_CUDA_HOST_COMPILER={0}".format(env["SPACK_CXX"]))
251252

252253
if spec.satisfies("@1.9.0:") and spec.satisfies("^[email protected]:"):
253-
options.append(self.builder.define_cuda_architectures(self))
254+
options.append(CMakeBuilder.define_cuda_architectures(self))
254255

255256
else:
256257
# VTKm_CUDA_Architecture only accepts a single CUDA arch
@@ -270,28 +271,24 @@ def cmake_args(self):
270271

271272
# hip support
272273
if "+rocm" in spec:
273-
options.append(self.builder.define_hip_architectures(self))
274+
options.append(CMakeBuilder.define_hip_architectures(self))
274275

275276
return options
276277

277278
def test_smoke_test(self):
278279
"""Build and run ctests"""
279-
spec = self.spec
280-
281-
if "+examples" not in spec:
280+
if "+examples" not in self.spec:
282281
raise SkipTest("Package must be installed with +examples")
283282

284283
testdir = "smoke_test_build"
285284
with working_dir(testdir, create=True):
286-
cmake = Executable(spec["cmake"].prefix.bin.cmake)
287-
ctest = Executable(spec["cmake"].prefix.bin.ctest)
288-
cmakeExampleDir = spec["vtk-m"].prefix.share.doc.VTKm.examples.smoke_test
289-
290-
cmake(*([cmakeExampleDir, "-DVTKm_ROOT=" + spec["vtk-m"].prefix]))
291-
cmake(*(["--build", "."]))
292-
ctest(*(["--verbose"]))
285+
cmake = Executable(self.spec["cmake"].prefix.bin.cmake)
286+
ctest = Executable(self.spec["cmake"].prefix.bin.ctest)
287+
cmake(self.prefix.share.doc.VTKm.examples.smoke_test, f"-DVTKm_ROOT={self.prefix}")
288+
cmake("--build", ".")
289+
ctest("--verbose")
293290

294291
@run_after("install")
295292
@on_package_attributes(run_tests=True)
296293
def build_test(self):
297-
self.test_smoke_test()
294+
self.test_smoke_test()

src/cmake/thirdparty/SetupMFEM.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ if(MFEM_MPI_ENABLED)
152152
message(FATAL_ERROR "MFEM was build with MPI support (config.mk has MFEM_USE_MPI = YES)"
153153
" but MPI::MPI_CXX target is missing.")
154154
endif()
155-
list(APPEND MFEM_LIBRARIES MPI::MPI_CXX)
155+
list(APPEND MFEM_LIBRARIES ${ascent_blt_mpi_deps})
156156
endif()
157157

158158
if(NOT MFEM_FOUND)

0 commit comments

Comments
 (0)