Skip to content

Commit f76bf40

Browse files
committed
Fixing VTKm references in Visit Camera branch
Signed-off-by: Emily Howell <[email protected]>
1 parent 30488fe commit f76bf40

File tree

5 files changed

+20
-20
lines changed

5 files changed

+20
-20
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ and this project aspires to adhere to [Semantic Versioning](https://semver.org/s
88
### Preferred dependency versions for ascent@develop
99
1010
11-
11+
1212
1313
1414

src/docs/sphinx/Actions/Scenes.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ Now we add a second render to the same example using every available parameter:
405405
Rendering Camera Configuration
406406
---------------------------------
407407
Ascent supports rendering in both 2D and 3D. For 3D rendering, Ascent supports two primary methods for defining the camera:
408-
the Ascent native (VTKm style) camera, which is camera-centric, and the VisIt style camera, which is view-centric.
408+
the Ascent native (Viskores style) camera, which is camera-centric, and the VisIt style camera, which is view-centric.
409409
Both formats provide control over how scenes are rendered, but they differ in terminology, orientation, and internal computation of the view matrix.
410410

411411
2D Camera
@@ -414,9 +414,9 @@ Both formats provide control over how scenes are rendered, but they differ in te
414414

415415
- ``2d`` or ``windowCoords``: Enables 2D rendering mode. Expects a 4-element array defining the 2D view bounds [x0 (left), x1 (right), y0 (bottom), y1 (top)].
416416

417-
Ascent Native (VTKm Style) Camera
417+
Ascent Native (Viskores Style) Camera
418418
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
419-
The native Ascent camera follows the VTKm camera model which focuses on defining the camera's physical parameters and orientation in 3D space.
419+
The native Ascent camera follows the Viskores camera model which focuses on defining the camera's physical parameters and orientation in 3D space.
420420
This camera-centric approach specifies where the camera is located, what it is looking at, and how it is oriented.
421421
The following parameters are supported:
422422

@@ -451,7 +451,7 @@ The following parameters are supported:
451451

452452
Unsupported VisIt Camera Parameters
453453
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
454-
In addition to the above supported VisIt camera parameters, there are a number of VisIt camera parameters that are not completely translatable to the VTKm style camera and are therefore currently ignored.
454+
In addition to the above supported VisIt camera parameters, there are a number of VisIt camera parameters that are not completely translatable to the Viskores style camera and are therefore currently ignored.
455455

456456
.. Note::
457457
These parameters are safely ignored if provided. They will not influence the rendered image but also will not produce errors.

src/docs/sphinx/BuildingAscent.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Ascent requires Conduit and provides optional features that depend on third-part
5656
- Required TPLS
5757

5858
* - VTK-h Rendering and Filtering Pipelines
59-
- VTk-m (Serial, OpenMP, CUDA, Kokkos)
59+
- Viskores (Serial, OpenMP, CUDA, Kokkos)
6060

6161
* - MFEM High-Order to Low-Order Refinement for VTK-h Pipelines
6262
- MFEM

src/libs/ascent/runtimes/flow_filters/ascent_runtime_conduit_to_viskores_parsing.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ parse_camera(const conduit::Node camera_node, viskores::rendering::Camera &camer
209209
if(camera_node.has_child("focus"))
210210
{
211211
float64_accessor coords = camera_node["focus"].value();
212-
vtkmVec3f look_at(coords[0], coords[1], coords[2]);
212+
viskoresVec3f look_at(coords[0], coords[1], coords[2]);
213213
camera.SetLookAt(look_at);
214214
}
215215

@@ -219,7 +219,7 @@ parse_camera(const conduit::Node camera_node, viskores::rendering::Camera &camer
219219
camera_node.has_child("parallel_scale"))
220220
{
221221
// Compute camera distance using perspective projection formula
222-
conduit::float64 view_angle = camera_node["view_angle"].to_float64() * (vtkm::Pi() / 360.0);
222+
conduit::float64 view_angle = camera_node["view_angle"].to_float64() * (viskores::Pi() / 360.0);
223223
conduit::float64 parallel_scale = camera_node["parallel_scale"].to_float64();
224224
conduit::float64 distance = (parallel_scale) / std::tan(view_angle);
225225

@@ -235,20 +235,20 @@ parse_camera(const conduit::Node camera_node, viskores::rendering::Camera &camer
235235
pos[i] = focus[i] + view_norm[i] * distance;
236236
}
237237

238-
vtkmVec3f position(pos[0], pos[1], pos[2]);
238+
viskoresVec3f position(pos[0], pos[1], pos[2]);
239239
camera.SetPosition(position);
240240

241241
// Clipping planes require positional information to be computed
242242
if(camera_node.has_child("near_plane"))
243243
{
244-
vtkm::Range clipping_range = camera.GetClippingRange();
244+
viskores::Range clipping_range = camera.GetClippingRange();
245245
clipping_range.Min =std::max(CONDUIT_EPSILON, distance + camera_node["near_plane"].to_float64());
246246
camera.SetClippingRange(clipping_range);
247247
}
248248

249249
if(camera_node.has_child("far_plane"))
250250
{
251-
vtkm::Range clipping_range = camera.GetClippingRange();
251+
viskores::Range clipping_range = camera.GetClippingRange();
252252
clipping_range.Max = distance + camera_node["far_plane"].to_float64();
253253
camera.SetClippingRange(clipping_range);
254254
}
@@ -262,8 +262,8 @@ parse_camera(const conduit::Node camera_node, viskores::rendering::Camera &camer
262262
if(camera_node.has_child("view_up"))
263263
{
264264
float64_accessor coords = camera_node["view_up"].value();
265-
vtkmVec3f up(coords[0], coords[1], coords[2]);
266-
vtkm::Normalize(up);
265+
viskoresVec3f up(coords[0], coords[1], coords[2]);
266+
viskores::Normalize(up);
267267
camera.SetViewUp(up);
268268
}
269269

@@ -275,7 +275,7 @@ parse_camera(const conduit::Node camera_node, viskores::rendering::Camera &camer
275275

276276
if(camera_node.has_child("image_zoom"))
277277
{
278-
camera.Zoom(zoom_to_vtkm_zoom(camera_node["image_zoom"].to_float64()));
278+
camera.Zoom(zoom_to_viskores_zoom(camera_node["image_zoom"].to_float64()));
279279
}
280280

281281
if(camera_node.has_child("perspective"))

src/tests/ascent/t_ascent_render_3d.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3660,8 +3660,8 @@ TEST(ascent_render_3d, test_render_ascent_camera)
36603660
Node n;
36613661
ascent::about(n);
36623662

3663-
// only run this test if ascent was built with vtkm support
3664-
if(n["runtimes/ascent/vtkm/status"].as_string() == "disabled")
3663+
// only run this test if ascent was built with viskores support
3664+
if(n["runtimes/ascent/viskores/status"].as_string() == "disabled")
36653665
{
36663666

36673667
ASCENT_INFO("Ascent support disabled, skipping 3D default"
@@ -3787,8 +3787,8 @@ TEST(ascent_render_3d, test_render_visit_camera)
37873787
Node n;
37883788
ascent::about(n);
37893789

3790-
// only run this test if ascent was built with vtkm support
3791-
if(n["runtimes/ascent/vtkm/status"].as_string() == "disabled")
3790+
// only run this test if ascent was built with viskores support
3791+
if(n["runtimes/ascent/viskores/status"].as_string() == "disabled")
37923792
{
37933793

37943794
ASCENT_INFO("Ascent support disabled, skipping 3D default"
@@ -3917,8 +3917,8 @@ TEST(ascent_render_3d, test_render_invalid_camera)
39173917
// the ascent runtime is currently our only rendering runtime
39183918
Node n;
39193919
ascent::about(n);
3920-
// only run this test if ascent was built with vtkm support
3921-
if(n["runtimes/ascent/vtkm/status"].as_string() == "disabled")
3920+
// only run this test if ascent was built with viskores support
3921+
if(n["runtimes/ascent/viskores/status"].as_string() == "disabled")
39223922
{
39233923
ASCENT_INFO("Ascent support disabled, skipping 3D default"
39243924
"Pipeline test");

0 commit comments

Comments
 (0)