support for actions_file[s] ?

[jfavre]

I was happily using a commit from a few weeks ago (git checkout 00621ed) with an ascent_actions.yaml as below:

-
  action: "add_triggers"
  triggers:
    t1:
      params:
        condition: "cycle() % 100 == 0"
        actions_file: "./add_scene.yaml"

Today, I checked out the latest commit and my execution now seg-faults. I only recompiled Ascent, did not touch my application itself and the yaml file. Moving a few steps back to commit ac3d1bc does the same. Moving one more step back to 00621ed, and my application works again. Was the syntax above working just by chance, or is it valid yaml, and commit ac3d1bc makes it fail?

[cyrush]

That is valid, it is possible the new logic could be to blame. Let me see if I can reproduce
Thanks for the report!

[cyrush]

I tested this case w/ ascent develop and it ran successfully:

- 
  action: "add_triggers"
  triggers: 
    t1: 
      params: 
        condition: "cycle() == 100"
        actions_file: "./my_test_actions.yaml"

Can you share the actions as well, maybe there something else that changed in ascent related to the scenes.

[jfavre]

I have reduced my actions to the most trivial example

-
  action: "add_scenes"
  scenes:
    view:
      image_prefix: "view_%04d"
      plots:
        p1:
          type: "pseudocolor"
          field: "rho"

Here is what I have found out. If the triggering code above is compiled in after my mesh Conduit node description during the initialization of Ascent, all is well and execution goes on (i.e. without parsing an ascent_actions.yaml at run-time). If instead, the yaml code defining the trigger is parsed from a file ascent_actions.yaml in the current directory, things fail. A debugger trace gives me

Thread 1 "dummysph_ascent" received signal SIGSEGV, Segmentation fault.
0x00007ffff71fba74 in conduit::Schema::object_hierarchy (this=<error reading variable: Cannot access memory at address 0x7fffff7fefe8>)
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_schema.cpp:1559
1559    {
(gdb) where
#0  0x00007ffff71fba74 in conduit::Schema::object_hierarchy (this=<error reading variable: Cannot access memory at address 0x7fffff7fefe8>)
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_schema.cpp:1559
#1  0x00007ffff71fc218 in conduit::Schema::object_map[abi:cxx11]() const (this=0x5555698f61e0)
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_schema.cpp:1661
#2  0x00007ffff71f8eb6 in conduit::Schema::child_index (this=0x5555698f61e0, name="default_params")
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_schema.cpp:992
#3  0x00007ffff71c9552 in conduit::Node::fetch_existing (this=0x5555698f6310, path="default_params")
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_node.cpp:14402
#4  0x00007ffff71c8eeb in conduit::Node::fetch_existing (this=0x555568f65520, path="interface/default_params")
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_node.cpp:14350
#5  0x00007ffff71c9e67 in conduit::Node::fetch (this=0x555568f65520, path="interface/default_params")
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_node.cpp:14488
#6  0x00007ffff71ca401 in conduit::Node::operator[] (this=0x555568f65520, path="interface/default_params")
    at /local/apps/Ascent-debug/source/conduit-v0.9.2/src/libs/conduit/conduit_node.cpp:14565
#7  0x00007ffff6fa59d8 in flow::Filter::default_params (this=0x555568f65510)
    at /local/apps/Ascent-debug/ascent/src/libs/flow/flow_filter.cpp:137
#8  0x00007ffff6fa5565 in flow::Filter::init (this=0x555568f65510, g=0x7fffff801ec8, name="expr_method_0_expr_mesh_cycle", p=...)
    at /local/apps/Ascent-debug/ascent/src/libs/flow/flow_filter.cpp:115
#9  0x00007ffff6fab562 in flow::Graph::add_filter (this=0x7fffff801ec8, filter_type="expr_mesh_cycle", 
    filter_name="expr_method_0_expr_mesh_cycle", filter_params=...) at /local/apps/Ascent-debug/ascent/src/libs/flow/flow_graph.cpp:125
#10 0x00007ffff778b937 in BuildGraphVisitor::visit (this=0x7fffff8016e0, call=...)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:822
#11 0x00007ffff7786772 in ASTMethodCall::accept (this=0x5555698fe120, visitor=0x7fffff8016e0)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:158
#12 0x00007ffff778fdf9 in BuildGraphVisitor::visit (this=0x7fffff8016e0, expr=...)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:1053
#13 0x00007ffff7786880 in ASTBinaryOp::accept (this=0x5555698f5da0, visitor=0x7fffff8016e0)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:183
#14 0x00007ffff778fdf9 in BuildGraphVisitor::visit (this=0x7fffff8016e0, expr=...)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:1053
#15 0x00007ffff7786880 in ASTBinaryOp::accept (this=0x5555698fc4d0, visitor=0x7fffff8016e0)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:183
#16 0x00007ffff7787a82 in BuildGraphVisitor::visit (this=0x7fffff8016e0, block=...)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:394
#17 0x00007ffff778662e in ASTBlock::accept (this=0x5555698fe180, visitor=0x7fffff8016e0)
    at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/expressions/ascent_expressions_ast.cpp:128
#18 0x00007ffff7653e16 in ascent::runtime::expressions::ExpressionEval::evaluate (this=0x7fffff801e60, expr="cycle() % 1 == 0", 
    expr_name="cycle() % 1 == 0") at /local/apps/Ascent-debug/ascent/src/libs/ascent/runtimes/ascent_expression_eval.cpp:1637

@cyrush did you try with the trigger code compiled in, or parsed from an external ascent_actions.yaml?

[jfavre]

I have compiled Ascent in Debug mode with tests enabled.
I run ctest -V -R trigger and I get
The following tests passed:
t_ascent_triggers

100% tests passed, 0 tests failed out of 1

no problem so far. I can now re-use the simple_trigger_actions.yaml created, with the only difference that I create an ascent_actions.yaml in my current build directory, which is different than the ctest working directory. The content of my ascent_actions.yaml is cut-and-pasted from the ctest output, i.e.

- 
  action: "add_triggers"
  triggers: 
    t1: 
      params: 
        condition: "1 == 1"
        actions_file: "/local/apps/Ascent-debug/build/ascent-checkout/tests/_output/simple_trigger_actions.yaml"

Instead of running ctest, I run the test directly from its full path, /local/apps/Ascent-debug/build/ascent-checkout/tests/ascent/t_ascent_triggers, and it fails, reproducing the error I see.

[cyrush]

@jfavre still working at this -- I may be able to recreate in our CI containers