Provide kill feature for dbt commands (run model, run parent/children models, run tests)

[jaredx435k2d0]

Expected behavior

If I use this button:

It executes dbt run --select +MY_MODEL_NAME

If I click the VS Code integrated terminal's "Kill Terminal" button on the terminal window that is then started:

I expect that the job will be killed and any planned / scheduled queries will not be sent to my DB.

Actual behavior

If I use this button:

It executes dbt run --select +MY_MODEL_NAME

If I click the VS Code integrated terminal's "Kill Terminal" button on the terminal window that is then started:

All SQL statements are still sent to my DB (even if they are far downstream and I click the button far before most of them can even be started due to dependencies).

If I run the same dbt run --select +MY_MODEL_NAME manually from my terminal, and later hit Ctrl+C and kill it, no furthe SQL is sent to my DB.

I'm not sure if this is something under the extension's control or not.

Prior to posting, I tried searching the Issues for stop, abort, cancel, and kill before posting. Hopefully this isn't a duplicate of an existing Issue.

Steps To Reproduce

Use this button to execute a model and it's dependencies:

Click the VS Code integrated terminal's "Kill Terminal" button on the terminal window that is then started:

Check your DB's activity and watch as all statements are still executed.

Log output/Screenshots

No response

Operating System

12.6.1 (21G217)

dbt version

1.3.0

dbt Adapter

Snowflake

dbt Power User version

0.9.0

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[jaredx435k2d0]

FWIW, I did just verify this still occurs on 0.9.2 as well.

[alexwhite-pattern]

👆🏼

[mdesmet]

The dbt tasks terminal is actually a fake terminal, that just provides output. Killing it won't kill the process indeed, it would just remove the fake terminal.

We would need to refactor this feature to provide ability to stop the process.

[pil0u]

Does anyone know about an alternative trick or command to kill a process while this is not implemented?

[stefinas]

Are there any updates on this feature?

[mdesmet]

We are currently implementing this for the query results. We can probably follow same approach for these commands.

[mdesmet]

@AdiGajbhiye : I think this could work if we change the execution strategy for core commands to CLIDBTCommandExecutionStrategy, however this might have some impact on how env vars are handled. We will need to ensure that .env files are detected and passed down to the command execution. Can you PTAL?