small fixes after qodana analysis

Author: Slach

pkg/backup/backup_shard.go

@@ -167,7 +167,7 @@ func newReplicaDeterminer(q querier, sf shardFunc) *replicaDeterminer {
 
 // getReplicaState obtains the local replication state through a query to `system.replicas`
 func (rd *replicaDeterminer) getReplicaState(ctx context.Context) ([]tableReplicaMetadata, error) {
-	md := []tableReplicaMetadata{}
+	var md []tableReplicaMetadata
 	// TODO: Change query to pull replica_is_active after upgrading to clickhouse-go v2
 	query := "SELECT t.database, t.name AS table, r.replica_name, arraySort(mapKeys(mapFilter((replica, active) -> (active == 1), r.replica_is_active))) AS active_replicas FROM system.tables t LEFT JOIN system.replicas r ON t.database = r.database AND t.name = r.table"
 	if err := rd.q.SelectContext(ctx, &md, query); err != nil {

pkg/backup/delete.go

@@ -258,7 +258,7 @@ func (b *Backuper) skipIfTheSameRemoteBackupPresent(ctx context.Context, backupN
 		} else {
 			for _, remoteBackup := range remoteList {
 				if remoteBackup.BackupName == backupName {
-					if tags == "" || (tags != "" && strings.Contains(remoteBackup.Tags, tags)) {
+					if tags == "" || strings.Contains(remoteBackup.Tags, tags) {
 						return true, nil
 					}
 				}

pkg/log_helper/log_helper.go

@@ -119,7 +119,7 @@ func (w *CustomWriter) Write(p []byte) (n int, err error) {
 
 	// Iterate over all fields to find custom fields - zero allocations
 	hasCustomFields := false
-	jsonparser.ObjectEach(p, func(key []byte, value []byte, dataType jsonparser.ValueType, offset int) error {
+	_ = jsonparser.ObjectEach(p, func(key []byte, value []byte, dataType jsonparser.ValueType, offset int) error {
 		keyStr := string(key)
 		if !systemFields[keyStr] {
 			if !hasCustomFields {

pkg/storage/azblob/chunkwriting.go

@@ -66,7 +66,7 @@ func copyFromReader(ctx context.Context, from io.Reader, to blockWriter, o azb.U
 		}
 	}
 	// If the error is not EOF, then we have a problem.
-	if err != nil && !errors.Is(err, io.EOF) {
+	if !errors.Is(err, io.EOF) {
 		return nil, err
 	}
 
@@ -145,7 +145,7 @@ func (c *copier) sendChunk() error {
 			id:     c.id.next(),
 		}
 		return nil
-	case err != nil && (err == io.EOF || errors.Is(err, io.ErrUnexpectedEOF)) && n == 0:
+	case (err == io.EOF || errors.Is(err, io.ErrUnexpectedEOF)) && n == 0:
 		return io.EOF
 	}
 

pkg/storage/general.go

@@ -304,9 +304,9 @@ func (bd *BackupDestination) DownloadCompressedStream(ctx context.Context, remot
 		compressionFormat = strings.Replace(path.Ext(remotePath), ".", "", -1)
 	}
 	downloadedBytes := int64(0)
-	z, getArchieveReaderErr := getArchiveReader(compressionFormat)
-	if getArchieveReaderErr != nil {
-		return 0, getArchieveReaderErr
+	z, getArchiveReaderErr := getArchiveReader(compressionFormat)
+	if getArchiveReaderErr != nil {
+		return 0, getArchiveReaderErr
 	}
 	if extractErr := z.Extract(ctx, bufReader, nil, func(ctx context.Context, file archiver.File) error {
 		src, openErr := file.Open()

pkg/storage/s3.go

@@ -405,7 +405,7 @@ func (s *S3) getObjectAllVersions(ctx context.Context, key string) ([]string, er
 	if s.Config.RequestPayer != "" {
 		listParams.RequestPayer = s3types.RequestPayer(s.Config.RequestPayer)
 	}
-	versions := []string{}
+	var versions []string
 	pager := s3.NewListObjectVersionsPaginator(s.client, listParams)
 	for pager.HasMorePages() {
 		page, err := pager.NextPage(ctx)