Skip to content

Commit 4f48727

Browse files
authored
Merge pull request #770 from Altinity/issue-756
Add absent options processing
2 parents 22939da + b46b062 commit 4f48727

File tree

5 files changed

+22
-3
lines changed

5 files changed

+22
-3
lines changed

docker/grafana/dashboards/table_examples_dashboard.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@
273273
"type": "table"
274274
}
275275
],
276-
"schemaVersion": 22,
276+
"schemaVersion": 40,
277277
"style": "dark",
278278
"tags": [],
279279
"templating": {

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"create_instrumented": "npx nyc instrument --source-map --nycrc-path .nycrc ./src ./instrumented",
1919
"build:test:frontend": "webpack -c ./webpack.config.instrumented.ts --env test",
2020
"build:frontend": "webpack -c ./.config/webpack/webpack.config.ts --env production",
21+
"build:backend": "docker compose run --rm backend_builder && chmod +rx ./dist",
2122
"build:wasm": "GOARCH=wasm GOOS=js tinygo build --target wasm ./pkg/backend_wasm.go && gzip -f ./backend_wasm.wasm && mkdir -pv ./src/static/ && mv -fv ./backend_wasm.wasm.gz ./src/static/backend.wasm.gz"
2223
},
2324
"author": "Altinity",

pkg/backend_wasm.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ func applyAdhocFiltersWasm(this js.Value, args []js.Value) interface{} {
176176
// Replace $adhoc macro
177177
renderedCondition := "1"
178178
if len(adhocConditions) > 0 {
179-
renderedCondition = fmt.Sprintf("(%s)", strings.Join(adhocConditions, " AND "))
179+
renderedCondition = fmt.Sprintf("AND (%s)", strings.Join(adhocConditions, " AND "))
180180
}
181181

182182
query = strings.ReplaceAll(query, "$adhoc", renderedCondition)

pkg/response.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ func (r *Response) createFrameIfNotExistsAndAddPoint(query *Query, framesMap map
178178
timeStampDataFieldMap[frameName] = data.NewField(timestampFieldName, nil, []time.Time{})
179179
valueDataFieldMap[frameName] = NewDataFieldByType(frameName, fieldType)
180180
framesMap[frameName] = data.NewFrame(
181-
frameName,
181+
"",
182182
timeStampDataFieldMap[frameName],
183183
valueDataFieldMap[frameName],
184184
)

src/views/QueryEditor/QueryEditor.tsx

+18
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,15 @@ export function QueryEditor(props: QueryEditorProps<CHDataSource, CHQuery, CHDat
1717
const isAnnotationView = !props.app;
1818
const initializedQuery = initializeQueryDefaults(query, isAnnotationView, datasource, onChange);
1919
const [formattedData, error] = useFormattedData(initializedQuery, datasource, data?.request);
20+
21+
useEffect(() => {
22+
if (formattedData !== initializedQuery.query) {
23+
onChange({ ...initializedQuery, rawQuery: formattedData })
24+
}
25+
26+
// eslint-disable-next-line
27+
}, [formattedData, initializedQuery.query]);
28+
2029
const [editorMode, setEditorMode] = useState(initializedQuery.editorMode || EditorMode.Builder);
2130
useQueryState(query, onChange, datasource);
2231

@@ -89,6 +98,15 @@ export function QueryEditorVariable(props: QueryEditorProps<CHDataSource, CHQuer
8998
const initializedQuery = initializeQueryDefaultsForVariables(processedQuery, isAnnotationView, datasource, onChange);
9099
const [formattedData, error] = useFormattedData(initializedQuery, datasource);
91100
const [editorMode, setEditorMode] = useState(initializedQuery.editorMode || EditorMode.Builder);
101+
102+
useEffect(() => {
103+
if (formattedData !== initializedQuery.query) {
104+
onChange({ ...initializedQuery, rawQuery: formattedData })
105+
}
106+
107+
// eslint-disable-next-line
108+
}, [formattedData, initializedQuery.query]);
109+
92110
useQueryState(query, onChange, datasource);
93111
const onSqlChange = (sql: string) => onChange({ ...initializedQuery, query: sql });
94112
const onFieldChange = (field: any) => onChange({ ...initializedQuery, [field.fieldName]: field.value });

0 commit comments

Comments
 (0)