fix: _is_trivial_response no longer skips valid JSON responses (#24)

Removed the naive text.startswith('{') and text.startswith('[') checks
that caused all JSON-formatted responses to be classified as trivial.

Lowered the code_char density threshold from 0.6 to 0.5 so that
highly-symbolic but non-JSON responses like '{ } ( ) = ; : # | \ > <'
are still correctly caught as trivial, while valid JSON is not.

Updated test assertions to match new behavior.

Fixes #24

Author: Muhamed Fazal PS

beliefstate/extractor.py

@@ -170,10 +170,8 @@ def _is_trivial_response(text: str) -> bool:
     code_chars = set("{}()=;:|#|\\><")
     if text:
         code_count = sum(1 for c in text if c in code_chars)
-        if code_count / len(text) > 0.6:
+        if code_count / len(text) > 0.5:
             return True
-    if text.startswith("{") or text.startswith("["):
-        return True
     return False
 
 

tests/test_new_features.py

@@ -134,8 +134,8 @@ def test_is_trivial_code_block(self):
         assert _is_trivial_response("{ } ( ) = ; : # | \\ > <") is True
 
     def test_is_trivial_json_start(self):
-        assert _is_trivial_response('{"key": "value"}') is True
-        assert _is_trivial_response('[{"key": "value"}]') is True
+        assert _is_trivial_response('{"key": "value"}') is False
+        assert _is_trivial_response('[{"key": "value"}]') is False
 
     def test_not_trivial_substantive(self):
         assert _is_trivial_response("I understand your budget constraints.") is False