feat(drawer): Add inline version #3631
pr.yml
on: pull_request
e2e-tests
/
merge-reports
Annotations
34 errors and 3 notices
|
build / build
Process completed with exit code 1.
|
|
build / build
Type '{ children: Element; ref: RefObject<DrawerApi | null>; header: Element; className: DrawerTypes; resizable: true; inline: true; style: { ...; }; }' is not assignable to type 'IntrinsicAttributes & Partial<DrawerProps> & { ref?: Ref<DrawerApi> | undefined; }'.
|
|
e2e-tests / Test (7/10)
Process completed with exit code 1.
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample daisyui/modal/default › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
8) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample daisyui/modal/default › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -11,11 +11,10 @@
</button>
</div>
<div>
<dialog
class="modal modal-bottom sm:modal-middle"
- open=""
>
<div
class="modal-box"
>
<h3
@@ -26,25 +25,9 @@
<p
class="py-4"
>
"Press ESC key, click on ✕ button or click outside the modal to close"
</p>
- <button
- aria-label="Close"
- class="absolute btn btn-circle btn-ghost btn-sm right-2 top-2"
- type="button"
- >
- "✕"
- </button>
</div>
- <div
- class="modal-backdrop"
- >
- <button
- type="button"
- >
- "Close"
- </button>
- </div>
</dialog>
</div>
</body>
Snapshot: daisyui/modal/default.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/body › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
7) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/body › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -2,11 +2,10 @@
style="overflow-x: hidden; overflow-y: hidden;"
>
<div
class="container p-3"
id="root"
- inert="inert"
>
<div
class="align-items-center d-flex mb-3"
>
<button
@@ -57,58 +56,6 @@
class="btn btn-primary"
>
"ScrollToMe"
</button>
</div>
- <div
- class="au-drawer-backdrop fade show"
- data-agnos-ignore-inert="data-agnos-ignore-inert"
- />
- <div
- aria-describedby=""
- aria-labelledby=""
- aria-modal="true"
- class="au-drawer collapse collapse-horizontal inline-start show"
- role="dialog"
- style="position: fixed; outline-color: initial; outline-style: none; outline-width: initial;"
- tabindex="-1"
- >
- <div
- class="au-drawer-container"
- >
- <div
- class="au-drawer-content"
- >
- <div
- class="au-drawer-header"
- >
- <div
- class="d-flex"
- >
- <span>
- "Hi, I am drawer!"
- </span>
- <button
- aria-label="Close"
- class="btn-close ms-auto"
- />
- </div>
- </div>
- <div
- class="au-drawer-body"
- >
- <ul>
- <li>
- "First item"
- </li>
- <li>
- "Second item"
- </li>
- <li>
- "Third item"
- </li>
- </ul>
- </div>
- </div>
- </div>
- </div>
</body>
Snapshot: bootstrap/drawer/body.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/position › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
6) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/position › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -2,11 +2,10 @@
style="overflow-x: hidden; overflow-y: hidden;"
>
<div
class="container p-3"
id="root"
- inert="inert"
>
<button
class="btn btn-primary mb-3"
>
"Open Drawer"
@@ -45,52 +44,6 @@
"Bottom"
</option>
</select>
</div>
</div>
- <div
- class="au-drawer-backdrop fade show"
- data-agnos-ignore-inert="data-agnos-ignore-inert"
- />
- <div
- aria-describedby=""
- aria-labelledby=""
- aria-modal="true"
- class="au-drawer collapse collapse-horizontal drawer-position-size inline-start show"
- role="dialog"
- style="position: fixed; outline-color: initial; outline-style: none; outline-width: initial;"
- tabindex="-1"
- >
- <div
- class="au-drawer-container"
- >
- <div
- class="au-drawer-content"
- >
- <div
- class="au-drawer-header"
- >
- "Hi, I am drawer!"
- </div>
- <div
- class="au-drawer-body"
- >
- <ul>
- <li>
- "First item"
- </li>
- <li>
- "Second item"
- </li>
- <li>
- "Third item"
- </li>
- </ul>
- </div>
- </div>
- </div>
- <div
- class="au-splitter"
- tabindex="0"
- />
- </div>
</body>
Snapshot: bootstrap/drawer/position.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/sizes › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
5) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/sizes › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -2,60 +2,13 @@
style="overflow-x: hidden; overflow-y: hidden;"
>
<div
class="container p-3"
id="root"
- inert="inert"
>
<button
class="btn btn-primary mb-3"
>
"Open Drawer"
</button>
</div>
- <div
- class="au-drawer-backdrop fade show"
- data-agnos-ignore-inert="data-agnos-ignore-inert"
- />
- <div
- aria-describedby=""
- aria-labelledby=""
- aria-modal="true"
- class="au-drawer collapse collapse-horizontal drawer-custom-size inline-start show"
- role="dialog"
- style="position: fixed; outline-color: initial; outline-style: none; outline-width: initial;"
- tabindex="-1"
- >
- <div
- class="au-drawer-container"
- >
- <div
- class="au-drawer-content"
- >
- <div
- class="au-drawer-header"
- >
- "Hi, I am drawer!"
- </div>
- <div
- class="au-drawer-body"
- >
- <ul>
- <li>
- "First item"
- </li>
- <li>
- "Second item"
- </li>
- <li>
- "Third item"
- </li>
- </ul>
- </div>
- </div>
- </div>
- <div
- class="au-splitter"
- tabindex="0"
- />
- </div>
</body>
Snapshot: bootstrap/drawer/sizes.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/default › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
4) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/default › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -1,12 +1,9 @@
-<body
- style="overflow-x: hidden; overflow-y: hidden;"
->
+<body>
<div
class="container p-3"
id="root"
- inert="inert"
>
<button
class="btn btn-primary"
type="button"
>
@@ -31,58 +28,6 @@
<hr />
<div
data-testid="message"
/>
</div>
- <div
- class="fade modal-backdrop show"
- inert="inert"
- />
- <div
- class="d-block fade modal show"
- tabindex="-1"
- >
- <div
- class="modal-dialog"
- >
- <div
- class="modal-content"
- >
- <div
- class="modal-header"
- >
- <h5
- class="modal-title"
- >
- "Save changes"
- </h5>
- <button
- aria-label="Close"
- class="btn-close"
- type="button"
- />
- </div>
- <div
- class="modal-body"
- >
- "Do you want to save your changes?"
- </div>
- <div
- class="modal-footer"
- >
- <button
- class="btn btn-outline-primary"
- type="button"
- >
- "Yes"
- </button>
- <button
- class="btn btn-outline-danger"
- type="button"
- >
- "No"
- </button>
- </div>
- </div>
- </div>
- </div>
</body>
Snapshot: bootstrap/modal/default.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/stack › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
3) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/stack › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -1,75 +1,12 @@
-<body
- style="overflow-x: hidden; overflow-y: hidden;"
->
+<body>
<div
class="container p-3"
id="root"
- inert="inert"
>
<button
class="btn btn-primary"
>
"Launch demo modal"
</button>
</div>
- <div
- class="fade modal-backdrop show"
- inert="inert"
- />
- <div
- class="d-block fade modal modal-sm show"
- tabindex="-1"
- >
- <div
- class="modal-dialog"
- >
- <div
- class="modal-content"
- >
- <div
- class="modal-header"
- >
- <h5
- class="modal-title"
- >
- "First modal"
- </h5>
- <button
- aria-label="Close"
- class="btn-close"
- type="button"
- />
- </div>
- <div
- class="modal-body"
- >
- "This is a modal"
- <br />
- <br />
- <button
- class="btn btn-outline-primary m-1"
- >
- "Launch other modal"
- </button>
- <br />
- <button
- class="btn btn-outline-secondary m-1"
- >
- "Enable backdrop"
- </button>
- <button
- class="btn btn-outline-secondary m-1"
- >
- "Disable backdrop"
- </button>
- <br />
- <button
- class="btn btn-outline-secondary m-1"
- >
- "Close"
- </button>
- </div>
- </div>
- </div>
- </div>
</body>
Snapshot: bootstrap/modal/stack.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:react:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
2) [singleBrowser:react:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(string).toMatchSnapshot(expected) failed
@@ -82,7 +82,10 @@
"Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident."
</p>
</div>
</div>
</div>
+ <style>
+ ".demo-inline-drawer { border: 1px solid #dee2e6; padding: 1rem; border-radius: 0.375rem; }"
+ </style>
</div>
</body>
Snapshot: bootstrap/drawer/inline.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:react:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
2) [singleBrowser:react:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup
Error: expect(string).toMatchSnapshot(expected) failed
@@ -82,7 +82,10 @@
"Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident."
</p>
</div>
</div>
</div>
+ <style>
+ ".demo-inline-drawer { border: 1px solid #dee2e6; padding: 1rem; border-radius: 0.375rem; }"
+ </style>
</div>
</body>
Snapshot: bootstrap/drawer/inline.html
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup:
e2e/samplesMarkup.singlebrowser-e2e-spec.ts#L45
1) [singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup
Error: A snapshot doesn't exist at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts-snapshots/bootstrap-drawer-inline.html, writing actual.
43 | await preventTransitions(page);
44 | await samplesExtraAction[sampleKey]?.(page);
> 45 | expect(await htmlSnapshot(page.locator('body'))).toMatchSnapshot(`${sampleKey.toLowerCase()}.html`);
| ^
46 | });
47 | });
48 | }
at /home/runner/work/AgnosUI/AgnosUI/e2e/samplesMarkup.singlebrowser-e2e-spec.ts:45:54
|
|
e2e-tests / Test (3/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (3/10)
The operation was canceled.
|
|
[main:react:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation:
e2e/select/select.e2e-spec.ts#L179
1) [main:react:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation
Error: Last badge must have been removed
expect(received).toStrictEqual(expected) // deep equality
- Expected - 1
+ Received + 3
- Array []
+ Array [
+ "JSON",
+ ]
Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
177 | await keyboard.press('ArrowRight');
178 | await keyboard.press('Enter');
> 179 | await expect.poll(getBadgesState, 'Last badge must have been removed').toStrictEqual([]);
| ^
180 | expect(await page.evaluate(() => (document.activeElement!.tagName || '').toLowerCase())).toBe('input');
181 | });
182 | });
at /home/runner/work/AgnosUI/AgnosUI/e2e/select/select.e2e-spec.ts:179:4
|
|
e2e-tests / Test (5/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (5/10)
The operation was canceled.
|
|
[main:svelte:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation:
e2e/select/select.e2e-spec.ts#L175
1) [main:svelte:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation
Error: First badge must have been removed
expect(received).toStrictEqual(expected) // deep equality
- Expected - 0
+ Received + 1
Array [
+ "JavaScript",
"JSON",
]
Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
173 |
174 | await keyboard.press('Enter');
> 175 | await expect.poll(getBadgesState, 'First badge must have been removed').toStrictEqual(['JSON']);
| ^
176 |
177 | await keyboard.press('ArrowRight');
178 | await keyboard.press('Enter');
at /home/runner/work/AgnosUI/AgnosUI/e2e/select/select.e2e-spec.ts:175:4
|
|
e2e-tests / Test (9/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (9/10)
The operation was canceled.
|
|
e2e-tests / Test (8/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (8/10)
The operation was canceled.
|
|
e2e-tests / Test (4/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (4/10)
The operation was canceled.
|
|
e2e-tests / Test (6/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (6/10)
The operation was canceled.
|
|
e2e-tests / Test (10/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (10/10)
The operation was canceled.
|
|
e2e-tests / Test (10/10)
Type '{ children: Element; ref: RefObject<DrawerApi | null>; header: Element; className: DrawerTypes; resizable: true; inline: true; style: { ...; }; }' is not assignable to type 'IntrinsicAttributes & Partial<DrawerProps> & { ref?: Ref<DrawerApi> | undefined; }'.
|
|
e2e-tests / Test (2/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (10/10)
Type '{ children: Element; ref: RefObject<DrawerApi | null>; header: Element; className: DrawerTypes; resizable: true; inline: true; style: { ...; }; }' is not assignable to type 'IntrinsicAttributes & Partial<DrawerProps> & { ref?: Ref<DrawerApi> | undefined; }'.
|
|
e2e-tests / Test (2/10)
The operation was canceled.
|
|
e2e-tests / Test (1/10)
The strategy configuration was canceled because "e2e-tests.e2e-tests._7" failed
|
|
e2e-tests / Test (1/10)
The operation was canceled.
|
|
🎭 Playwright Run Summary
2 failed
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup
[singleBrowser:react:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/inline › should have a consistent markup
6 flaky
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/stack › should have a consistent markup
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/modal/default › should have a consistent markup
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/sizes › should have a consistent markup
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/position › should have a consistent markup
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample bootstrap/drawer/body › should have a consistent markup
[singleBrowser:angular:chromium] › e2e/samplesMarkup.singlebrowser-e2e-spec.ts:39:4 › Samples markup consistency check › Sample daisyui/modal/default › should have a consistent markup
1 skipped
127 passed (2.4m)
|
|
🎭 Playwright Run Summary
1 flaky
[main:react:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation
136 passed (2.6m)
|
|
🎭 Playwright Run Summary
1 flaky
[main:svelte:chromium] › e2e/select/select.e2e-spec.ts:143:3 › Select tests › Custom select › Navigation
136 passed (2.6m)
|