diff --git a/angular/demo/bootstrap/src/app/samples/alert/config.route.ts b/angular/demo/bootstrap/src/app/samples/alert/config.route.ts index cb7113c30ac..bcac3b6a87c 100644 --- a/angular/demo/bootstrap/src/app/samples/alert/config.route.ts +++ b/angular/demo/bootstrap/src/app/samples/alert/config.route.ts @@ -50,7 +50,7 @@ export default class ConfigAlertComponent { readonly dismissible = signal(true); readonly type = signal(this.styleList[0].value); - showAlert(alert: AlertComponent) { - alert.api.open(); + async showAlert(alert: AlertComponent) { + await alert.api.open(); } } diff --git a/core/src/components/alert/alert.spec.ts b/core/src/components/alert/alert.spec.ts index 195e65c6f04..afcf540212d 100644 --- a/core/src/components/alert/alert.spec.ts +++ b/core/src/components/alert/alert.spec.ts @@ -28,7 +28,7 @@ describe(`Alert`, () => { test(`should close on method call`, () => { const expectedState = state; expect(expectedState.visible).toBe(true); - alert.api.close(); + void alert.api.close(); expectedState.visible = false; expectedState.hidden = true; expect(state).toEqual(expectedState); @@ -38,7 +38,7 @@ describe(`Alert`, () => { alert.patch({visible: false}); const expectedState = state; expect(expectedState.visible).toBe(false); - alert.api.open(); + void alert.api.open(); expectedState.visible = true; expectedState.hidden = false; expect(state).toEqual(expectedState); @@ -71,13 +71,13 @@ describe(`Alert`, () => { }); alertEvents.directives.transitionDirective(element); - alertEvents.api.close(); + void alertEvents.api.close(); await promiseOnHidden.promise; expect(onVisibleChangeCounter).toBe(1); expect(onShownCounter).toBe(0); expect(onHiddenCounter).toBe(1); - alertEvents.api.open(); + void alertEvents.api.open(); await promiseOnShown.promise; expect(onVisibleChangeCounter).toBe(2); expect(onShownCounter).toBe(1); diff --git a/core/src/components/alert/common.spec.ts b/core/src/components/alert/common.spec.ts index 36f825f2c06..18c7fc19618 100644 --- a/core/src/components/alert/common.spec.ts +++ b/core/src/components/alert/common.spec.ts @@ -28,7 +28,7 @@ describe(`Common Alert`, () => { test(`should close on method call`, () => { const expectedState = state; expect(expectedState.visible).toBe(true); - commonAlert.api.close(); + void commonAlert.api.close(); expectedState.visible = false; expectedState.hidden = true; expect(state).toEqual(expectedState); @@ -38,7 +38,7 @@ describe(`Common Alert`, () => { commonAlert.patch({visible: false}); const expectedState = state; expect(expectedState.visible).toBe(false); - commonAlert.api.open(); + void commonAlert.api.open(); expectedState.visible = true; expectedState.hidden = false; expect(state).toEqual(expectedState); @@ -71,13 +71,13 @@ describe(`Common Alert`, () => { }); alertEvents.directives.transitionDirective(element); - alertEvents.api.close(); + void alertEvents.api.close(); await promiseOnHidden.promise; expect(onVisibleChangeCounter).toBe(1); expect(onShownCounter).toBe(0); expect(onHiddenCounter).toBe(1); - alertEvents.api.open(); + void alertEvents.api.open(); await promiseOnShown.promise; expect(onVisibleChangeCounter).toBe(2); expect(onShownCounter).toBe(1); diff --git a/core/src/components/alert/common.ts b/core/src/components/alert/common.ts index 44702d1f344..c0b8f210140 100644 --- a/core/src/components/alert/common.ts +++ b/core/src/components/alert/common.ts @@ -115,12 +115,12 @@ export interface CommonAlertApi { /** * Triggers alert closing programmatically (same as clicking on the close button (×)). */ - close(): void; + close(): Promise; /** * Triggers the alert to be displayed for the user. */ - open(): void; + open(): Promise; } /** diff --git a/core/src/components/collapse/collapse.ts b/core/src/components/collapse/collapse.ts index 7a96cb7f11d..6c0f3297398 100644 --- a/core/src/components/collapse/collapse.ts +++ b/core/src/components/collapse/collapse.ts @@ -103,17 +103,17 @@ export interface CollapseApi { /** * Triggers collapse closing programmatically. */ - close(): void; + close(): Promise; /** * Triggers the collapse content to be displayed for the user. */ - open(): void; + open(): Promise; /** * Toggles the collapse content visibility. */ - toggle(): void; + toggle(): Promise; } /** diff --git a/core/src/components/toast/toast.spec.ts b/core/src/components/toast/toast.spec.ts index d170df879f1..99dd1ae39e1 100644 --- a/core/src/components/toast/toast.spec.ts +++ b/core/src/components/toast/toast.spec.ts @@ -31,7 +31,7 @@ describe(`Toast`, () => { test(`should close on method call`, () => { const expectedState = state; expect(expectedState.visible).toBe(true); - toast.api.close(); + void toast.api.close(); expect(state).toEqual( assign(expectedState, { visible: false, @@ -44,7 +44,7 @@ describe(`Toast`, () => { toast.patch({visible: false}); const expectedState = state; expect(expectedState.visible).toBe(false); - toast.api.open(); + void toast.api.open(); expect(state).toEqual( assign(expectedState, { visible: true, @@ -80,13 +80,13 @@ describe(`Toast`, () => { }); toastEvents.directives.transitionDirective(element); - toastEvents.api.close(); + void toastEvents.api.close(); await promiseOnHidden.promise; expect(onVisibleChangeCounter).toBe(1); expect(onShownCounter).toBe(0); expect(onHiddenCounter).toBe(1); - toastEvents.api.open(); + void toastEvents.api.open(); await promiseOnShown.promise; expect(onVisibleChangeCounter).toBe(2); expect(onShownCounter).toBe(1); diff --git a/react/demo/src/bootstrap/samples/toast/Action.route.tsx b/react/demo/src/bootstrap/samples/toast/Action.route.tsx index 8b413998745..da1e9aa97e0 100644 --- a/react/demo/src/bootstrap/samples/toast/Action.route.tsx +++ b/react/demo/src/bootstrap/samples/toast/Action.route.tsx @@ -9,8 +9,8 @@ import {useRef} from 'react'; const ActionToastDemo = () => { const refToast = useRef(null); - function reset() { - refToast.current?.open(); + async function reset() { + await refToast.current?.open(); } return ( diff --git a/react/demo/src/bootstrap/samples/toast/Default.route.tsx b/react/demo/src/bootstrap/samples/toast/Default.route.tsx index 6703773e954..c05a487e782 100644 --- a/react/demo/src/bootstrap/samples/toast/Default.route.tsx +++ b/react/demo/src/bootstrap/samples/toast/Default.route.tsx @@ -5,8 +5,8 @@ import {useRef} from 'react'; const DefaultToastDemo = () => { const refToast = useRef(null); - function reset() { - refToast.current!.open(); + async function reset() { + await refToast.current!.open(); } return (