Skip to content

Commit 75b28cb

Browse files
edeweerd1Aflazarus1A
authored andcommitted
feat(deps): Migration to Asciidoctorj v3.0.0
This version has introduced some breaking changes amongst which a removal of deprecated methods, which are breaking the extension and its tests. Asciidoctor-maven-plugin has been updated to 3.0.0 also in the IT test. Looking at the non-backwards-compatible nature of the upgrade, setting base version to 2.0-SNAPSHOT.
1 parent 202d5da commit 75b28cb

File tree

5 files changed

+20
-16
lines changed

5 files changed

+20
-16
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<modelVersion>4.0.0</modelVersion>
33
<groupId>com.amadeus.asciidoc</groupId>
44
<artifactId>asciidoctor-extension-apidoc</artifactId>
5-
<version>1.1-SNAPSHOT</version>
5+
<version>2.0-SNAPSHOT</version>
66
<packaging>jar</packaging>
77

88
<name>asciidoctor-extension-apidoc</name>
@@ -55,7 +55,7 @@
5555
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
5656
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
5757

58-
<asciidoctorj.version>2.5.10</asciidoctorj.version>
58+
<asciidoctorj.version>3.0.0</asciidoctorj.version>
5959

6060
<junit.jupiter.version>5.10.0</junit.jupiter.version>
6161
<junit.platform.version>1.10.0</junit.platform.version>

src/it/sample/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<plugin>
1717
<groupId>org.asciidoctor</groupId>
1818
<artifactId>asciidoctor-maven-plugin</artifactId>
19-
<version>2.0.0-RC.1</version>
19+
<version>3.0.0</version>
2020
<configuration>
2121
<!-- Common configuration to all backends -->
2222
<enableVerbose>true</enableVerbose>
@@ -70,7 +70,7 @@
7070
<dependency>
7171
<groupId>org.asciidoctor</groupId>
7272
<artifactId>asciidoctorj-pdf</artifactId>
73-
<version>1.5.0-alpha.17</version>
73+
<version>2.3.18</version>
7474
</dependency>
7575
</dependencies>
7676
</plugin>

src/main/java/com/amadeus/asciidoc/apidoc/ImplicitApidocMacro.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.apache.commons.lang3.StringUtils;
1111
import org.asciidoctor.ast.ContentNode;
1212
import org.asciidoctor.ast.PhraseNode;
13+
import org.asciidoctor.ast.StructuralNode;
1314
import org.asciidoctor.extension.Format;
1415
import org.asciidoctor.extension.FormatType;
1516
import org.asciidoctor.extension.InlineMacroProcessor;
@@ -60,7 +61,7 @@ public class ImplicitApidocMacro extends InlineMacroProcessor {
6061
private ApidocRegistry registry = null;
6162

6263
@Override
63-
public Object process(ContentNode parent, String target, Map<String, Object> attributes) {
64+
public PhraseNode process(StructuralNode parent, String target, Map<String, Object> attributes) {
6465
LOG.log(Level.FINE, "Processing {0}", target);
6566
Map<String, Object> documentAttributes = parent.getDocument().getAttributes();
6667

src/test/java/com/amadeus/asciidoc/apidoc/ApidocExtensionTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ public class ApidocExtensionTest {
2929

3030
private static Asciidoctor asciidoctor;
3131

32-
private Map<String, Object> options = new HashMap<>();
32+
private Options options;
3333

34-
private Attributes attributes = new Attributes();
34+
private Attributes attributes = Attributes.builder().build();
3535

3636
private StubLogHandler logHandler = new StubLogHandler();
3737

@@ -43,7 +43,7 @@ public static void setUpOnce() {
4343
@BeforeEach
4444
public void setUp() {
4545
attributes.setAttribute(ImplicitApidocMacro.ATTRIBUTE_APIDOCS_CONFIG, "src/test/resources/apidoc.properties");
46-
options = OptionsBuilder.options().attributes(attributes).asMap();
46+
options = Options.builder().attributes(attributes).build();
4747
asciidoctor.registerLogHandler(logHandler);
4848
}
4949

@@ -116,7 +116,7 @@ public void relativeLinks() {
116116
@Test
117117
public void relativeLinksWithBaseUrl() {
118118
attributes.setAttribute(ImplicitApidocMacro.ATTRIBUTE_APIDOCS_BASE_URL, "https://my.company.com/");
119-
Map<String, Object> options = OptionsBuilder.options().attributes(attributes).asMap();
119+
Options options = Options.builder().attributes(attributes).build();
120120

121121
String output = asciidoctor.convert("com.company.my.Class", options);
122122

@@ -200,7 +200,7 @@ public void mostPrecisePackageShouldBeUsed() {
200200

201201
@Test
202202
public void renderExampleWithoutConfig() {
203-
Options options = new Options();
203+
Options options = Options.builder().build();
204204
options.setToFile("target/sample.html");
205205
asciidoctor.convertFile(new File("src/it/sample/sample.adoc"), options);
206206

@@ -210,7 +210,7 @@ public void renderExampleWithoutConfig() {
210210

211211
@Test
212212
public void renderExample() {
213-
Options options = OptionsBuilder.options().attributes(attributes).get();
213+
Options options = Options.builder().attributes(attributes).build();
214214
options.setToFile("target/sample.html");
215215
asciidoctor.convertFile(new File("src/it/sample/sample.adoc"), options);
216216

src/test/java/com/amadeus/asciidoc/apidoc/ImplicitApidocMacroTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package com.amadeus.asciidoc.apidoc;
22

3+
import org.asciidoctor.Options;
4+
import org.asciidoctor.ast.PhraseNode;
5+
import org.asciidoctor.ast.StructuralNode;
36
import static org.junit.jupiter.api.Assertions.assertEquals;
47
import static org.mockito.Mockito.when;
58

@@ -25,14 +28,14 @@ public class ImplicitApidocMacroTest {
2528
static ImplicitApidocMacro macro;
2629

2730
@Mock
28-
private ContentNode parent;
31+
private StructuralNode parent;
2932

3033
@Mock
3134
private Document document;
3235

33-
private final Attributes attributes = new Attributes();
36+
private final Attributes attributes = Attributes.builder().build();
3437

35-
private final Map<String, Object> options = OptionsBuilder.options().asMap();
38+
private final Map<String, Object> options = Options.builder().build().map();
3639

3740
@BeforeEach
3841
public void setUp() {
@@ -46,15 +49,15 @@ public void setUp() {
4649
@Disabled("#log requires a JRuby runtime")
4750
@Test
4851
public void unknownPackageShouldSkipProcessing() {
49-
String output = (String)macro.process(parent, "com.unknown.Class", options);
52+
String output = macro.process(parent, "com.unknown.Class", options).convert();
5053

5154
assertEquals("com.unknown.Class", output);
5255
}
5356

5457
@Disabled("JRuby bugs when calling Inline#convert, see ImplicitApidocMacroAscidocTest instead")
5558
@Test
5659
public void relativeLinks() {
57-
String output = (String)macro.process(parent, "com.company.my.Class", options);
60+
String output = macro.process(parent, "com.company.my.Class", options).convert();
5861

5962
assertEquals("<a href=\"apidocs/com/company/my/Class.html\">Class</a>", output);
6063
}

0 commit comments

Comments
 (0)