Skip to content

Commit d760adb

Browse files
authored
fix: wrong default values for o3r-set-version (#3949)
## Proposed change For the cli script `set-version`, we don't want to include `lerna.json` files located inside `node_modules` or `templates` ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- * :octocat: Pull Request #issue -->
2 parents 19ff36a + 916ce3f commit d760adb

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/@o3r/workspace/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Replace the packages version in a monorepos
3939
Options:
4040

4141
-p, --placeholder <placeholder> Pattern of the version placeholder (default: 0.0.0)
42-
--include <file> Add files pattern to apply the verison replacement (default: */lerna.json,**/package.json,!**/node_modules/**/{package,lerna}.json)
42+
--include <file> Add files pattern to apply the verison replacement (default: '**/package.json', '**/lerna.json', '!**/templates', '!**/node_modules')
4343
--set-public Enforce the package to be public
4444
-V, --verbose Display debug logs
4545
-h, --help output usage information

packages/@o3r/workspace/src/cli/set-version.cts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
} from 'semver';
1717
import * as winston from 'winston';
1818

19-
const defaultIncludedFiles = ['**/package.json', '!/**/templates/**/package.json', '!**/node_modules/**/package.json', '**/lerna.json'];
19+
const defaultIncludedFiles = ['**/package.json', '**/lerna.json', '!**/templates', '!**/node_modules'];
2020

2121
const collect = (pattern: string, patterns: string[]) => {
2222
if (patterns === defaultIncludedFiles && pattern) {

0 commit comments

Comments
 (0)