`puni-kill-line` still misbehaving with regard to indentation

[astratagem]

I originally added this as a comment on #64 but I figure that issue has been closed for long enough that it's worth a new thread.

---

I'm running into the behavior described in #64 on the latest commit (f430f5b). #68 looks similar, but the before/after examples in this issue (#64) are definitely the same as what I'm seeing. Why would the issue have come back?

If it matters, I have seen this behavior regardless of the value of kill-whole-line.

Here's another example, this time in nix-ts-mode, though I see it in quite a few other modes (I think also php-ts-mode):

Original, where | represents point:

{
  services.kanshi.settings = [
    {
      output.criteria = "eDP-1";
      |output.scale = 2.0;
    }
  ];
}

After first puni-kill-line invocation, with | as point:

{
  services.kanshi.settings = [
    {
      output.criteria = "eDP-1";
      |
    }
  ];
}

After second puni-kill-line invocation:

{
  services.kanshi.settings = [
    {
      output.criteria = "eDP-1";
      |}
  ];
}

And here's an even more minimal example with the intermediary step elided:

[
  {}
  |
]

[
  {}
  |]

[hpfr]

Did you try to reproduce the exact case in the original post on #64? I don’t think it’s related.

I’m not sure I would call this outright misbehavior. In these examples, the point is placed correctly if you want to start adding new expressions at point.

You can try:

(define-advice puni-kill-line (:after (&rest _) reindent)
  "Reindent after killing lines with Puni."
  (puni--indent-line))

Or more generally, consider a package like aggressive-indent-mode. As a result of #16, Puni does try to place the point correctly when killing lines, but it’s a bit of a special case. Puni is more about augmenting existing commands with soft deletion than it is about augmenting existing commands with automatic reindentation.