Skip to content

Triggered events -- Only use reset like paginated collection? #28

@bryanspears

Description

@bryanspears

Backstory -- Displaying a filtered subcollection using a select-view. It's quite slow when you filter 300+ models and noticeable with 200+ models. Firing add/remove events for each model change is the source of the problem as select-view re-renders the entire options list each add/remove/reset.

The fix is simple, and I'm currently using it (replace the two foreach add/remove cases with one reset) and it works perfectly. I'll work on the tests later.

Any feedback? Reasons for using add/remove over a single reset? Otherwise, I hope to have a PR soon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions