[pgmoneta#883] Replace WAL parser assertion with validation for compressed/encrypted file detection

check the return value of fread

add compress and encrypt file before check magic value

support directories in interactive and non-interactive modes

add pgmoneta prefix

Fix missing file argument message in interactive mode

remove extra hints from invalid WAL

Author: saraanbih

src/include/walfile/wal_reader.h

@@ -394,6 +394,15 @@ extern struct server* server_config;
 
 /* Function definitions */
 
+/**
+ * Validate and extract base WAL filename from path
+ * @param path The full path to the WAL file
+ * @param base_filename Output parameter for the base WAL filename
+ * @return 0 on success, 1 on error
+ */
+int
+pgmoneta_validate_wal_filename(char* path, char** base_filename);
+
 /**
  * Parses a WAL file and populates server information.
  *

src/libpgmoneta/walfile/wal_reader.c

@@ -184,6 +184,84 @@ read_all_page_headers(FILE* file, struct xlog_long_page_header_data* long_header
    return;
 }
 
+int
+pgmoneta_validate_wal_filename(char* path, char** base_filename)
+{
+   char* wal_filename = NULL;
+   char* temp = NULL;
+   timeline_id test_tli = 0;
+   xlog_seg_no test_logSegNo = 0;
+
+   wal_filename = strdup(basename(path));
+   if (wal_filename == NULL)
+   {
+      return 1;
+   }
+
+   if (pgmoneta_ends_with(wal_filename, ".partial"))
+   {
+      temp = pgmoneta_remove_suffix(wal_filename, ".partial");
+      free(wal_filename);
+      wal_filename = temp;
+   }
+
+   if (pgmoneta_is_encrypted(wal_filename))
+   {
+      temp = pgmoneta_remove_suffix(wal_filename, ".aes");
+      free(wal_filename);
+      wal_filename = temp;
+   }
+
+   if (pgmoneta_is_compressed(wal_filename))
+   {
+      if (pgmoneta_ends_with(wal_filename, ".gz"))
+      {
+         temp = pgmoneta_remove_suffix(wal_filename, ".gz");
+         free(wal_filename);
+         wal_filename = temp;
+      }
+      else if (pgmoneta_ends_with(wal_filename, ".zstd"))
+      {
+         temp = pgmoneta_remove_suffix(wal_filename, ".zstd");
+         free(wal_filename);
+         wal_filename = temp;
+      }
+      else if (pgmoneta_ends_with(wal_filename, ".lz4"))
+      {
+         temp = pgmoneta_remove_suffix(wal_filename, ".lz4");
+         free(wal_filename);
+         wal_filename = temp;
+      }
+      else if (pgmoneta_ends_with(wal_filename, ".bz2"))
+      {
+         temp = pgmoneta_remove_suffix(wal_filename, ".bz2");
+         free(wal_filename);
+         wal_filename = temp;
+      }
+   }
+
+   if (xlog_from_file_name(wal_filename, &test_tli, &test_logSegNo, DEFAULT_WAL_SEGZ_BYTES))
+   {
+      pgmoneta_log_trace("Invalid WAL file name: %s", path);
+      free(wal_filename);
+      return 1;
+   }
+
+   pgmoneta_log_trace("Valid WAL file name: %s (timeline: %u, segment: %lu)",
+                      wal_filename, test_tli, test_logSegNo);
+
+   if (base_filename != NULL)
+   {
+      *base_filename = wal_filename;
+   }
+   else
+   {
+      free(wal_filename);
+   }
+
+   return 0;
+}
+
 int
 pgmoneta_wal_parse_wal_file(char* path, int server, struct walfile* wal_file)
 {
@@ -239,6 +317,12 @@ pgmoneta_wal_parse_wal_file(char* path, int server, struct walfile* wal_file)
 
    config = (struct walinfo_configuration*)shmem;
 
+   if (pgmoneta_validate_wal_filename(path, NULL))
+   {
+      pgmoneta_log_error("Error: Invalid WAL file name: %s", path);
+      goto error;
+   }
+
    file = fopen(path, "rb");
    if (file == NULL)
    {
@@ -260,11 +344,22 @@ pgmoneta_wal_parse_wal_file(char* path, int server, struct walfile* wal_file)
       goto error;
    }
 
-   assert(magic_value_to_postgres_version(long_header->std.xlp_magic) != -1);
+   int pg_version = magic_value_to_postgres_version(long_header->std.xlp_magic);
+
+   if (pg_version == -1)
+   {
+      pgmoneta_log_error("Invalid PostgreSQL WAL magic number: 0x%04X in file %s",
+                         long_header->std.xlp_magic, path);
+
+      goto error;
+   }
+
+   pgmoneta_log_trace("Valid PostgreSQL WAL magic number: 0x%04X (PostgreSQL %d) in file %s",
+                      long_header->std.xlp_magic, pg_version, path);
 
    if (server == -1)
    {
-      config->common.servers[0].version = magic_value_to_postgres_version(long_header->std.xlp_magic);
+      config->common.servers[0].version = pg_version;
       server_config = &config->common.servers[0];
    }
    else

src/walinfo.c

@@ -2740,8 +2740,6 @@ main(int argc, char** argv)
             goto error;
          }
 
-         ui_state.wal_filename = strdup(cwd);
-
          show_wal_file_selector(&ui_state);
 
          if (ui_state.record_count == 0)
@@ -2763,10 +2761,45 @@ main(int argc, char** argv)
          /* Check if file exists before initializing ncurses */
          if (!pgmoneta_exists(filepath))
          {
-            fprintf(stderr, "Error: File <%s> doesn't exist\n", filepath);
+            fprintf(stderr, "Error: <%s> doesn't exist\n", filepath);
             goto error;
          }
 
+         if (pgmoneta_is_directory(filepath))
+         {
+            if (wal_interactive_init(&ui_state, filepath) != 0)
+            {
+               fprintf(stderr, "Error: Failed to initialize UI\n");
+               goto error;
+            }
+
+            show_wal_file_selector(&ui_state);
+
+            if (ui_state.record_count == 0)
+            {
+               wal_interactive_cleanup(&ui_state);
+               pgmoneta_destroy_shared_memory(shmem, size);
+               if (logfile)
+               {
+                  pgmoneta_stop_logging();
+               }
+               return 0;
+            }
+
+            wal_interactive_run(&ui_state);
+            wal_interactive_cleanup(&ui_state);
+
+            return 0;
+         }
+         else
+         {
+            if (pgmoneta_validate_wal_filename(filepath, NULL) != 0)
+            {
+               fprintf(stderr, "Error: %s is not a valid WAL file\n", filepath);
+               goto error;
+            }
+         }
+
          if (wal_interactive_init(&ui_state, filepath) != 0)
          {
             fprintf(stderr, "Error: Failed to initialize UI\n");
@@ -2801,6 +2834,13 @@ main(int argc, char** argv)
       partial_record->xlog_record_bytes_read = 0;
       partial_record->xlog_record = NULL;
       partial_record->data_buffer = NULL;
+
+      if (!pgmoneta_exists(filepath))
+      {
+         fprintf(stderr, "Error: <%s> doesn't exist\n", filepath);
+         goto error;
+      }
+
       if (pgmoneta_is_directory(filepath))
       {
          if (describe_walfiles_in_directory(filepath, type, out, quiet, color,
@@ -2810,13 +2850,22 @@ main(int argc, char** argv)
             goto error;
          }
       }
-
-      else if (describe_walfile(filepath, type, out, quiet, color,
-                                rms, start_lsn, end_lsn, xids, limit, summary, included_objects))
+      else
       {
-         fprintf(stderr, "Error while reading/describing WAL file\n");
-         goto error;
+         if (pgmoneta_validate_wal_filename(filepath, NULL) != 0)
+         {
+            fprintf(stderr, "Error: %s is not a valid WAL file\n", filepath);
+            goto error;
+         }
+
+         if (describe_walfile(filepath, type, out, quiet, color,
+                              rms, start_lsn, end_lsn, xids, limit, summary, included_objects))
+         {
+            fprintf(stderr, "Error while reading/describing WAL file\n");
+            goto error;
+         }
       }
+
       if (partial_record->xlog_record != NULL)
       {
          free(partial_record->xlog_record);
@@ -2828,7 +2877,7 @@ main(int argc, char** argv)
       free(partial_record);
       partial_record = NULL;
    }
-   else
+   else if (!interactive)
    {
       fprintf(stderr, "Missing <file> argument\n");
       usage();