configurable pixel

Author: AmyJeanes

Keypad.Flasher.Server.Tests/ConfigurationGeneratorTests.cs

@@ -18,7 +18,8 @@ public void GenerateHeader_MatchesExpectedLayout()
                     new ButtonBinding(2, false, 0, true, true, new HidFunctionBinding("hid_consumer_volume_up"))
                 },
                 Array.Empty<EncoderBinding>(),
-                DebugMode: false);
+                DebugMode: false,
+                NeoPixelPin: 34);
 
             var expected = Lines(
                 "#pragma once",
@@ -48,20 +49,36 @@ public void GenerateHeader_WithMultipleLedIndices_ComputesNeoCountFromBindings()
                     new ButtonBinding(2, true, 4, false, false, new HidSequenceBinding("b", 0))
                 },
                 Array.Empty<EncoderBinding>(),
-                DebugMode: false);
+                DebugMode: false,
+                NeoPixelPin: 34);
 
             var result = Generator.GenerateHeader(configuration);
 
             Assert.That(result, Does.Contain("#define NEO_COUNT 5"));
         }
 
+        [Test]
+        public void GenerateHeader_WithCustomNeoPixelPin_EmitsPin()
+        {
+            var configuration = new ConfigurationDefinition(
+                Array.Empty<ButtonBinding>(),
+                Array.Empty<EncoderBinding>(),
+                DebugMode: false,
+                NeoPixelPin: 31);
+
+            var result = Generator.GenerateHeader(configuration);
+
+            Assert.That(result, Does.Contain("#define PIN_NEO P31"));
+        }
+
         [Test]
         public void GenerateHeader_WithDebugMode_EmitsFlag()
         {
             var configuration = new ConfigurationDefinition(
                 Array.Empty<ButtonBinding>(),
                 Array.Empty<EncoderBinding>(),
-                DebugMode: true);
+                DebugMode: true,
+                NeoPixelPin: 34);
 
             var result = Generator.GenerateHeader(configuration);
 
@@ -89,7 +106,7 @@ public void GenerateSource_WithTwoButtons_WritesExpectedConfiguration()
                     Function: new HidFunctionBinding("hid_consumer_volume_down"))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false);
+            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false, NeoPixelPin: 34);
 
             var expected = ReadExpected("generate_source_2_buttons.c");
 
@@ -133,7 +150,7 @@ public void GenerateSource_WithFourButtons_WritesExpectedConfiguration()
                     Function: new HidFunctionBinding("hid_consumer_volume_down"))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false);
+            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false, NeoPixelPin: 34);
 
             var expected = ReadExpected("generate_source_4_buttons.c");
 
@@ -151,7 +168,7 @@ public void GenerateSource_WithTwoButtonModule_WritesExpectedConfiguration()
                 new ButtonBinding(14, true, 1, false, false, new HidSequenceBinding("2", 0))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false);
+            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false, NeoPixelPin: 34);
 
             var expected = ReadExpected("generate_source_2_button_module.c");
 
@@ -173,7 +190,7 @@ public void GenerateSource_WithDebugMode_WritesInactiveBindings()
                 new EncoderBinding(10, 11, new HidFunctionBinding("hid_consumer_volume_up"), new HidFunctionBinding("hid_consumer_volume_down"))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, encoders, DebugMode: true);
+            var configuration = new ConfigurationDefinition(buttons, encoders, DebugMode: true, NeoPixelPin: 34);
 
             var result = Generator.GenerateSource(configuration);
 
@@ -198,7 +215,7 @@ public void GenerateSource_WithTenButtons_WritesExpectedConfiguration()
                 new ButtonBinding(16, true, 9, false, false, new HidSequenceBinding("j", 0))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false);
+            var configuration = new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false, NeoPixelPin: 34);
 
             var expected = ReadExpected("generate_source_10_buttons.c");
 
@@ -251,7 +268,7 @@ public void GenerateSource_WithFourButtonsAndEncoder_WritesExpectedConfiguration
                     CounterClockwise: new HidFunctionBinding("hid_consumer_volume_down"))
             };
 
-            var configuration = new ConfigurationDefinition(buttons, encoders, DebugMode: false);
+            var configuration = new ConfigurationDefinition(buttons, encoders, DebugMode: false, NeoPixelPin: 34);
 
             var expected = ReadExpected("generate_source_4_buttons_1_dial.c");
 

Keypad.Flasher.Server/Configuration/ConfigurationGenerator.cs

@@ -7,6 +7,12 @@ public class ConfigurationGenerator
         public string GenerateHeader(ConfigurationDefinition configuration)
         {
             var neoPixelCount = CalculateNeoPixelCount(configuration.Buttons);
+            var neoPixelPin = configuration.NeoPixelPin;
+            if (neoPixelPin < 0)
+            {
+                throw new ArgumentOutOfRangeException(nameof(configuration), "NeoPixel pin must be non-negative.");
+            }
+            var neoPixelPinMacro = $"P{neoPixelPin}";
 
             var sb = new StringBuilder();
             sb.AppendLine("#pragma once");
@@ -17,7 +23,7 @@ public string GenerateHeader(ConfigurationDefinition configuration)
             sb.AppendLine($"#define CONFIGURATION_ENCODER_CAPACITY {configuration.Encoders.Count}");
             sb.AppendLine($"#define CONFIGURATION_DEBUG_MODE {ToCInteger(configuration.DebugMode)}");
             sb.AppendLine();
-            sb.AppendLine("#define PIN_NEO P34");
+            sb.AppendLine($"#define PIN_NEO {neoPixelPinMacro}");
             sb.AppendLine($"#define NEO_COUNT {neoPixelCount}");
             sb.AppendLine("#define NEO_GRB");
             return sb.ToString();

Keypad.Flasher.Server/Configuration/ConfigurationModel.cs

@@ -31,5 +31,6 @@ public sealed record EncoderBinding(
     public sealed record ConfigurationDefinition(
         IReadOnlyList<ButtonBinding> Buttons,
         IReadOnlyList<EncoderBinding> Encoders,
-        bool DebugMode);
+        bool DebugMode,
+        int NeoPixelPin);
 }

Keypad.Flasher.Server/Controllers/FlasherController.cs

@@ -149,7 +149,7 @@ internal static ConfigurationDefinition CreateDefaultConfiguration()
                     Function: new HidSequenceBinding("2", 0))
             };
 
-            return new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false);
+            return new ConfigurationDefinition(buttons, Array.Empty<EncoderBinding>(), DebugMode: false, NeoPixelPin: 34);
         }
 
         private bool IsDebugRequested()