Admin Levels

[davetha]

Hey!
I stumbled upon your project a week or so ago. I had a use case where I needed admin level and place in the geo properties. I noticed while I was adding the functionality in that you had a "TODO: add admin level for boundaries".

Do you want it to be an optional flag to add admin level and or place in, or are you fine with it being always on? My code with it always on is a fork located here: https://github.com/davetha/osm_extract_polygon I can alter it if needed and do a pull request whenever I hear from you :)

Another feature I added in that should likely be a cli flag is tacking on the relationship id in the file name. When you're dealing with larger OSM files and many admin levels, you'll often run into conflicting names... As I was typing this, I saw #33 so maybe no longer an issue :)

[AndGem]

Hi David!

Thanks a lot for reaching out. Definitely, I would be happy to accept a PR from you to add the first feature the project.

Regarding your second suggestion. I only added the relation id to duplicate regions, but now I consider adding it just by default to all of them just to make this consistent.

Thanks again, and looking forward to the PR :)

[davetha]

Ok cool. I'll likely submit something this evening. I'm messing with some experimental features as well. I might get your suggestions once it's cleaned up a bit. Basically expanding it from only admin_levels, but allowing places like suburbs, neighborhoods etc.. where they don't have actual admin_level set on the tags

…

On Tue, Sep 27, 2022 at 12:16 PM Andreas ***@***.***> wrote: Hi David! Thanks a lot for reaching out. Definitely, I would be *happy to accept* a PR from you to add the first feature the project. Regarding your second suggestion. I only added the relation id to duplicate regions, but now I consider adding it just by default to all of them just to make this consistent. Thanks again, and looking forward to the PR :) — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAKPT4VSH74VEAJRQKOLGLWAMTYDANCNFSM6AAAAAAQWFFTZU> . You are receiving this because you authored the thread.Message ID: ***@***.***>