Skip to content

Commit ecba715

Browse files
Andrew-McGeeAndrew-McGee
authored
Merge pull request #7 from Andrew-McGee/design
Design
2 parents 0c9b5c0 + 9c9d369 commit ecba715

181 files changed

Lines changed: 85 additions & 188143 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,22 +108,22 @@ Code optimisation, clean up, minimisation, speed, etc.
108108

109109
#### _Known Issues_
110110
- Need a timeout if Ampache host unreachable in order to sign in again
111-
- Long album/playlists get tracks truncated
112111
- Sometimes the track timer glitches after seeking with the slider
113112

114113
## Contributions
115114
Once I have a working release then contributions and suggestions always welcome.
116115

117116
## Testing
118117
Testing on Chrome (Windows and Linux) during initial development.
119-
- Ampache: dev (testing 5.0)
118+
- All lossless FLAC playback
119+
- Ampache: dev (testing 5.2)
120120
- Apache: 2.4.41
121121
- PHP: 7.4.3
122122

123123
## Acknowledgements & Dependencies
124124
- Inspired by the subsonic player [subplayer](https://github.com/peguerosdc/subplayer) - a really nice looking web player for subsonic.
125-
- Using [Fomantic UI](https://github.com/fomantic/Fomantic-UI) components (v2.8.7 included).
126-
- Using [howler.js](https://github.com/goldfire/howler.js) audio library for media playback (In HTML mode for better FLAC playback).
125+
- Using [Fomantic UI](https://github.com/fomantic/Fomantic-UI) components (v2.8.8).
126+
- Using [howler.js](https://github.com/goldfire/howler.js) (v2.2.3) audio library for media playback (In HTML mode for better FLAC playback).
127127
- Fomantic (Semantic) UI is still dependent on jquery (pulled from CDN - no need to include it).
128128
- Of course you need a backend [Ampache](https://github.com/ampache/ampache) server.
129129
- And a PHP enabled webserver (PHP version 7.4+ recommended).

‎album_view.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
parent.list = []; // Clean out the old list before we build a new one
2929

3030
</script>
31-
<body style="overflow:hidden">
31+
<body>
3232
<div class="ui inverted space segment">
3333
<?php
3434
echo '<div class="ui two column grid">' . "\r\n"; //Two columns for album view - art on left, tracks on right.

‎albums_view.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
?>
3939
<script>parent.activeMenu(4);</script> <!-- Call js function in parent to highlight the correct active menu item -->
4040

41-
<body style="overflow:hidden">
41+
<body>
4242
<div class="ui inverted space segment">
4343
<div class='ui middle aligned grid'>
4444
<div class="left floated four wide column">

‎artist_albums.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
?>
3535
<script>parent.activeMenu(0);</script> <!-- Call js function in parent to highlight the correct active menu item -->
3636

37-
<body style="overflow:hidden">
37+
<body>
3838
<div class="ui inverted space segment">
3939
<div class='ui grid'>
4040
<div class="left floated four wide column">

‎artist_tracks.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
parent.list = []; // Clean out the old list before we build a new one
2626

2727
</script>
28-
<body style="overflow:hidden">
28+
<body>
2929
<div class="ui inverted space segment">
3030
<?php
3131
echo '<div class="ui one column grid">' . "\r\n"; //Two columns - first column just for spacing.

‎artists_view.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<script>
4040
parent.activeMenu(3); // Call js function in parent to highlight the correct active menu item -->
4141
</script>
42-
<body style="overflow:hidden">
42+
<body>
4343
<div class="ui inverted space segment">
4444
<?php
4545
echo '<div class="ui one column grid">'; //Two columns - first column just for spacing.

‎css/main.css‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,19 @@
153153
margin: 1em 2em 0em 3em !important;
154154
}
155155

156+
157+
/** Main top menu styling **/
158+
.ui.inverted.top.menu {
159+
background-color: var(--colrfgd1) !important;
160+
color: var(--colrfnt1);
161+
}
162+
163+
.slider.item {
164+
display: inline-block;
165+
width: 10%;
166+
padding-top: 1.4em;
167+
}
168+
156169
/** Main side menu styling **/
157170
.sidemenu.column {
158171
background-color: var(--colrfgd1);
@@ -162,7 +175,7 @@
162175
.ui.inverted.side.menu {
163176
background-color: var(--colrfgd1) !important;
164177
color: var(--colrfnt1) !important;
165-
margin: 2em 0em 0em 2em;
178+
margin: 8em 0em 0em 2em;
166179
}
167180

168181
.ui.menu .active.item {
@@ -231,12 +244,6 @@
231244
}
232245

233246
/** Page segments styling **/
234-
.ui.inverted.top.segment {
235-
background-color: var(--colrfgd1) !important;
236-
color: var(--colrfnt1);
237-
padding: 1em 2em;
238-
}
239-
240247
.ui.inverted.spacecadet.segment {
241248
background-color: var(--colrfgd1) !important;
242249
color: var(--colrfnt1) !important;
@@ -248,6 +255,7 @@
248255
.ui.inverted.manatee.segment {
249256
background-color: var(--colrbgd1) !important;
250257
color: var(--colrfnt2) !important;
258+
margin-top: 6em !important;
251259
}
252260

253261
.ui.inverted.space.segment {

‎dist/components/accordion.css‎

Lines changed: 0 additions & 247 deletions
This file was deleted.

0 commit comments

Comments
 (0)