refactor: remove nav title behaviorsubject

Author: AndrewJBateman

src/app/movie/add-movie/add-movie.component.ts

@@ -1,5 +1,4 @@
 import { MovieService } from "./../services/movie.service";
-import { NavbarService } from "./../../navbar/services/navbar.service";
 import { Component, OnInit } from "@angular/core";
 import { UntypedFormGroup, UntypedFormControl, Validators } from "@angular/forms";
 import { Router } from "@angular/router";
@@ -20,11 +19,9 @@ export class AddMovieComponent implements OnInit {
   constructor(
     private router: Router,
     private movieService: MovieService,
-    private navbarService: NavbarService
   ) {}
 
   ngOnInit() {
-    this.navbarService.title.next("Add Movies");
   }
 
   addMovie() {

src/app/movie/movie-detail/movie-detail.component.ts

@@ -1,4 +1,3 @@
-import { NavbarService } from "./../../navbar/services/navbar.service";
 import { MovieService } from "./../services/movie.service";
 import { Component, OnInit, OnDestroy } from "@angular/core";
 import { ActivatedRoute } from "@angular/router";
@@ -17,7 +16,6 @@ export class MovieDetailComponent implements OnInit, OnDestroy {
 
   constructor(
     private movieService: MovieService,
-    private navbarService: NavbarService,
     private route: ActivatedRoute
   ) {}
 
@@ -27,7 +25,6 @@ export class MovieDetailComponent implements OnInit, OnDestroy {
       .movieFromHttp(this.id)
       .subscribe((movie) => {
         this.movie = movie;
-        this.navbarService.title.next(movie.name);
       });
   }
 

src/app/movie/movie-list/movie-list.component.ts

@@ -1,6 +1,5 @@
 import { Component, OnInit } from "@angular/core";
 import { Observable } from "rxjs";
-import { NavbarService } from "./../../navbar/services/navbar.service";
 import { Movie } from "../models/movie.model";
 import { MovieService } from "./../services/movie.service";
 import {
@@ -50,14 +49,12 @@ export class MovieListComponent implements OnInit {
 
   // inject movie & navbar services
   constructor(
-    private movieService: MovieService,
-    private navbarService: NavbarService
+    private movieService: MovieService
   ) {}
 
   ngOnInit() {
     this.loadingMovies = new Array(9).fill(0).map((n, index) => index);
 
     this.movies$ = this.movieService.getMoviesFromHttp();
-    this.navbarService.title.next("FilmSelector");
   }
 }

src/app/movie/movie/movie.component.html

@@ -1,4 +1,4 @@
-<div>
+<div *ngIf="movie">
   <img [src]="movie.image">
   <h1>{{movie.id}} - {{movie.name}}</h1>
   <h2>{{movie.genre}} - {{movie.releaseYear}}</h2>

src/app/navbar/navbar.component.html

@@ -1,5 +1,4 @@
 <nav>
-  <h1 routerLink="/">{{ title$ | async }}</h1>
   <button routerLink="movies/add" *ngIf="!router.url.includes('movies/add')">
     Add
   </button>

src/app/navbar/navbar.component.ts

@@ -1,4 +1,3 @@
-import { NavbarService } from "./services/navbar.service";
 import { Component, OnInit } from "@angular/core";
 import { Router } from "@angular/router";
 
@@ -8,9 +7,8 @@ import { Router } from "@angular/router";
   styleUrls: ["./navbar.component.scss"],
 })
 export class NavbarComponent implements OnInit {
-  title$ = this.navbarService.title;
 
-  constructor(public navbarService: NavbarService, public router: Router) {}
+  constructor(public router: Router) {}
 
   ngOnInit() {}
 }