-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedWe need help with thisWe need help with thisneeds-triageNew issue, maintainer review neededNew issue, maintainer review needed
Description
Type
Incorrect/outdated info
Location
Settings Modal / User Interface
Description
Current Behavior:
When changing options in the Settings menu (e.g., toggling a switch, adjusting the scale slider):
- The changes are applied and saved immediately (auto-save).
- The "Save Settings" button is visible but performs no necessary action.
- The "Cancel" button closes the modal without reverting changes. It functions effectively as a "Close" button, leaving the modified settings active.
The Issue:
The presence of "Save" and "Cancel" buttons at the bottom of the modal implies a transactional workflow (i.e., changes are temporary until confirmed).
- Users expecting to experiment with settings and revert them by hitting "Cancel" are unable to do so.
- Users are confused about whether the "Save" button is required.
Steps to Reproduce:
- Open Settings.
- Change a setting (e.g., toggle "Dev Tools" or adjust "Fine-tune Scale").
- Note that the change applies immediately.
- Click "Cancel".
- Re-open Settings (or observe the app) to see the change was not discarded.
Expected Behavior:
Please align the UI with the logic in one of two ways:
- Option A (Transactional - Preferred): Settings should not apply/persist until "Save Settings" is clicked. Clicking "Cancel" should discard all changes made while the modal was open.
- Option B (Live/Auto-save): If immediate application is intended, remove the "Save Settings" and "Cancel" buttons entirely. Replace them with a simple "Close" or "Done" button to reflect that changes are already live.
Context:
- Version: 2.7.3-beta.1
- OS: [Your OS]
Contribution
- I'm willing to submit a PR for this
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedWe need help with thisWe need help with thisneeds-triageNew issue, maintainer review neededNew issue, maintainer review needed
Projects
Status
Backlog