fix[glfw]: Fix IndexOOB when requesting GLFW_KEY_LAST

alexytomi · alexytomi · commit 2e090c2418c2 · 2025-06-19T08:30:27.000+08:00
Fixes C1OUS3R/Undertale#23 hopefully
diff --git a/app_pojavlauncher/src/main/assets/components/lwjgl3/lwjgl-glfw-classes.jar b/app_pojavlauncher/src/main/assets/components/lwjgl3/lwjgl-glfw-classes.jar
diff --git a/app_pojavlauncher/src/main/assets/components/lwjgl3/version b/app_pojavlauncher/src/main/assets/components/lwjgl3/version
@@ -1 +1 @@
-4903cfc8d3afd63918f59caf0a146efc2d837069
+349d027673855ffded0bb7471a5b662a63b438bd
diff --git a/jre_lwjgl3glfw/src/main/java/org/lwjgl/glfw/GLFW.java b/jre_lwjgl3glfw/src/main/java/org/lwjgl/glfw/GLFW.java
@@ -1159,6 +1159,9 @@ public static int glfwGetKeyScancode(int key) {
     }
 
     public static int glfwGetKey(@NativeType("GLFWwindow *") long window, int key) {
+        // This is jank, anything asking for int 348 results in an IndexOutOfBounds because idk.
+        // Probably an off-by-one error. This is the 'fix'
+        if (key == GLFW_KEY_LAST){return GLFW_KEY_LAST;}
         return keyDownBuffer.get(Math.max(0, key-31));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1159,6 +1159,9 @@ public static int glfwGetKeyScancode(int key) {`
`1159`	`1159`	`}`
`1160`	`1160`
`1161`	`1161`	`public static int glfwGetKey(@NativeType("GLFWwindow *") long window, int key) {`
	`1162`	`+ // This is jank, anything asking for int 348 results in an IndexOutOfBounds because idk.`
	`1163`	`+ // Probably an off-by-one error. This is the 'fix'`
	`1164`	`+ if (key == GLFW_KEY_LAST){return GLFW_KEY_LAST;}`
`1162`	`1165`	`return keyDownBuffer.get(Math.max(0, key-31));`
`1163`	`1166`	`}`
`1164`	`1167`