fix(Renderer/Default): Check asset ID instead of mcver

This is now based on the assetIndex.id that mojangs jsons have. I am
assuming inheritedFrom to always be present, if it isn't it'll treat it
like vanilla but it should still work due to the insertSafety setting
that field

This fixes the code breaking on versions with letters in them

Please finally don't break

Author: alexytomi

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/MainActivity.java

@@ -74,6 +74,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.text.ParseException;
+import java.util.Objects;
 
 public class MainActivity extends BaseActivity implements ControlButtonMenuListener, EditorExitable, ServiceConnection {
     public static volatile ClipboardManager GLOBAL_CLIPBOARD;
@@ -186,7 +187,7 @@ protected void initLayout(int resId) {
             String version = getIntent().getStringExtra(INTENT_MINECRAFT_VERSION);
             version = version == null ? minecraftProfile.lastVersionId : version;
 
-            JMinecraftVersionList.Version mVersionInfo = Tools.getVersionInfo(version);
+            JMinecraftVersionList.Version mVersionInfo = Tools.getVersionInfo(version, false);
             isInputStackCall = mVersionInfo.arguments != null;
             CallbackBridge.nativeSetUseInputStackQueue(isInputStackCall);
 
@@ -358,18 +359,50 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
     }
 
     private void runCraft(String versionId, JMinecraftVersionList.Version version) throws Throwable {
-        if(Tools.LOCAL_RENDERER == null) {
-            try {
-                // 25w09a is when HolyGL4ES starts showing a black screen upon world load.
-                boolean isBefore25w09a = DateUtils.dateBefore(DateUtils.parseReleaseDate(version.releaseTime), 2025, 2, 26);
-                if (isBefore25w09a) {
-                    Tools.LOCAL_RENDERER = "opengles2";
-                } else Tools.LOCAL_RENDERER = "opengles_mobileglues";
-            } catch (ParseException e) {
-                // If this gets triggered, it's probably because this is a modded version, we aren't sure
-                // which Minecraft version its based on so use Zink just to be safe
-                Tools.LOCAL_RENDERER = "vulkan_zink";
+        // Autoselect renderer
+        if (Tools.LOCAL_RENDERER == null) {
+            String assetVersion;
+            if (version.inheritsFrom != null) { // We are almost definitely modded if this runs
+                File vanillaJsonFile = new File(Tools.DIR_HOME_VERSION + "/" + version.inheritsFrom + "/" + version.inheritsFrom + ".json");
+                JMinecraftVersionList.Version vanillaJson;
+                try {
+                    vanillaJson = Tools.GLOBAL_GSON.fromJson(Tools.read(vanillaJsonFile.getAbsolutePath()), JMinecraftVersionList.Version.class);
+                } catch (IOException ignored) { // Should never happen, we check for this in MinecraftDownloader().start()
+                    throw new RuntimeException("Problem parsing vanilla.json. This should never happen, please send a bug report on github or discord.");
+                }
+                // Something went wrong if this is somehow not the case anymore
+                if (!Objects.equals(vanillaJson.assets, vanillaJson.assetIndex.id))
+                    Tools.showErrorRemote(new RuntimeException("Vanilla json seems to be corrupt. Please send a bug report on github or discord."));
+                assetVersion = vanillaJson.assets;
+            } else {
+                // Else assume we are vanilla
+                if (!Objects.equals(version.assets, version.assetIndex.id))
+                    Tools.showErrorRemote(new RuntimeException("Vanilla json seems to be corrupt. Please send a bug report on github or discord."));
+                assetVersion = version.assets;
             }
+            // 25w09a is when HolyGL4ES starts showing a black screen upon world load.
+            // There is no way to consistently check for that without breaking mod loaders
+            // for old versions like legacy fabric so we start from 25w07a instead
+
+            // 25w07a assets and assetIndex.id is set to 23, 25w08a and 25w09a is 24.
+
+            // 1.19.3 snapshots and all future versions restarted assets and assetsIndex.id
+            // to 1 and started counting up from there
+
+            // Previous versions had "1.19" and "1.18" and such, with April Fools versions
+            // being even more inconsistent like "3D Shareware v1.34" for the 2019 April Fools
+            // or 1.RV-Pre1 for 2016, thankfully now they don't seem to do that anymore and just
+            // use the incrementing system they now have
+
+            // I could probably read the manifest itself then check which position the `id` field is
+            // and count from there since its ordered latest to oldest but that uses way more code
+            // for basically 3 peoples benefit
+            try {
+                int assetID = Integer.parseInt(assetVersion);
+                // Check if below 25w08a
+                Tools.LOCAL_RENDERER = (assetID <= 23) ? "opengles2" : "opengles_mobileglues";
+                // Then assume 1.19.2 and below
+            } catch (NumberFormatException e) { Tools.LOCAL_RENDERER = "opengles2"; }
         }
 
         if(!Tools.checkRendererCompatible(this, Tools.LOCAL_RENDERER)) {