Optimized grid and overall rendering: skip lines at low zoom, use fillRect instead of vertical/horizontal drawLine

Also now using getNoteBounds() for checking if need to draw note in paint(). Optimized drawing of very short notes (<=1 pixel, as rectangles). Optimized drawing of bent and rounded notes.

Author: Ankalot

plugin/include/XenRoll/data/Parameters.h

@@ -52,6 +52,9 @@ class Parameters {
     static constexpr float max_bar_width_px = 4000.0f;
     static constexpr float max_octave_height_px = 5000.0f;
     static constexpr float max_note_height_scale = 2.0f;
+    static constexpr float min_subdiv_width_px = 4.0f; // for drawing subdiv lines
+    static constexpr float min_beat_width_px = 6.0f;   // for drawing beat lines
+    static constexpr float min_bar_width_px = 30.0f;   // for drawing bar lines
     // ===== Vocal to melody =====
     static constexpr float minVocalVolume_dB = -60.0f;
     static constexpr float maxVocalVolume_dB = 0.0f;

plugin/include/XenRoll/editor/panels/MainPanel.h

@@ -205,7 +205,7 @@ class MainPanel : public juce::Component, public juce::KeyListener {
     std::mutex mptcMtx;
 
     juce::Font bendFont;
-    std::unordered_map<juce::String, juce::Path> outlinedTextPathCache;
+    std::unordered_map<size_t, juce::Path> outlinedTextPathCache;
     static constexpr int OUTLINED_TEXT_CACHE_MAX_SIZE = 150;
 
     PitchMemoryResults pitchMemoryResults = {{}, {}};
@@ -293,6 +293,11 @@ class MainPanel : public juce::Component, public juce::KeyListener {
      */
     void updateLayout();
 
+    float getNotesHeight(); ///< in pixels
+
+    ///< For fast check if we need to draw note in paint()
+    juce::Rectangle<float> getNoteBounds(const Note &note);
+
     /**
      * @brief Get the path for drawing a note
      * @param note Note to get path for
@@ -344,7 +349,7 @@ class MainPanel : public juce::Component, public juce::KeyListener {
     void pitchCorrectRatioMarksBasedOnSelNotes();
     void timeCorrectRatioMarksBasedOnSelNotes(float dtime);
 
-    int totalCentsToY(int totalCents);
+    float totalCentsToY(int totalCents);
 
     void restoreState();
 

plugin/include/XenRoll/editor/panels/NotePathManager.h

@@ -19,8 +19,13 @@ class NotePathManager {
   private:
     const int numOctaves;
 
-    ///< Is used to scale duration in CacheKey & to round corner radius in path (tol)
+    ///< Is used to scale duration in CacheKey
     static constexpr float MAX_PX_SCALE = 4.0f;
+    ///< Minimum rounding radius
+    static constexpr float TOL_RADIUS = 1.8f;
+    ///< If arc has angle < 90° and sagitta less than this, then just draw a line instead
+    static constexpr float MAX_VISUAL_DEVIATION = 0.4f;
+
     static constexpr size_t MAX_CACHE_SIZE = 1000; // 1000 elements = ~0.5 Mb total
 
     ///< Cache key, contains only params that affect the shape of note
@@ -55,6 +60,10 @@ class NotePathManager {
      * @return juce::Path Canonical path
      */
     juce::Path buildCanonicalPath(float w, float dy, float h, float noteRoundCoef) const;
+
+    void addConditionalArc(juce::Path &path, float centreX, float centreY, float radius,
+                           float fromRadians, float toRadians,
+                           bool startAsNewSubPath = false) const;
 };
 
 } // namespace audio_plugin