Skip to content

Commit f214c03

Browse files
Merge pull request #72 from AnotherDaniel/var_units
Fix units: VAR->var
2 parents 61e6222 + 58f26d7 commit f214c03

File tree

3 files changed

+25
-16
lines changed

3 files changed

+25
-16
lines changed

plugins/sources/EVCharger/evcharger.py

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ def env_vars(config):
2626
if os.environ.get('EVCHARGER_PASSWORD'):
2727
config['server']['password'] = os.environ.get('EVCHARGER_PASSWORD')
2828
if os.environ.get('EVCHARGER_UPDATEFREQ'):
29-
config['behavior']['updateFreq'] = os.environ.get('EVCHARGER_UPDATEFREQ')
29+
config['behavior']['updateFreq'] = os.environ.get(
30+
'EVCHARGER_UPDATEFREQ')
3031
if os.environ.get('EVCHARGER_PREFIX'):
3132
config['behavior']['sensorPrefix'] = os.environ.get('EVCHARGER_PREFIX')
3233

@@ -62,9 +63,11 @@ def execute(config, add_data, dostop):
6263

6364
# Login & Extract Access-Token
6465
try:
65-
response = session.post(loginurl, data=postdata, timeout=5, verify=verify_tls)
66+
response = session.post(loginurl, data=postdata,
67+
timeout=5, verify=verify_tls)
6668
except requests.exceptions.ConnectTimeout:
67-
logging.fatal(f"Charger not reachable via HTTP: {config.get('server', 'address')}")
69+
logging.fatal(
70+
f"Charger not reachable via HTTP: {config.get('server', 'address')}")
6871
return
6972
except requests.exceptions.ConnectionError as e:
7073
logging.fatal(f"Charger connection error: {e.args[0]}")
@@ -74,7 +77,8 @@ def execute(config, add_data, dostop):
7477
logging.fatal("Username or Password wrong")
7578
return
7679
if (404 == response.status_code):
77-
logging.fatal(f"HTTP connection to {config.get('server', 'address')} refused (status 404)")
80+
logging.fatal(
81+
f"HTTP connection to {config.get('server', 'address')} refused (status 404)")
7882
return
7983

8084
token = response.json()["access_token"]
@@ -103,12 +107,14 @@ def execute(config, add_data, dostop):
103107

104108
try:
105109
url = f"{config.get('server', 'protocol')}://{config.get('server', 'address')}/api/v1/measurements/live"
106-
response = session.post(url, headers=headers, data='[{"componentId":"IGULD:SELF"}]', verify=verify_tls)
110+
response = session.post(
111+
url, headers=headers, data='[{"componentId":"IGULD:SELF"}]', verify=verify_tls)
107112

108113
# Check if a new acccess token is neccesary (TODO use refresh token)
109114
if (response.status_code == 401):
110115
logging.info(f"Got {response.status_code} - trying reauth")
111-
response = requests.post(loginurl, data=postdata, verify=verify_tls)
116+
response = requests.post(
117+
loginurl, data=postdata, verify=verify_tls)
112118
token = response.json()['access_token']
113119
headers = {"Authorization": "Bearer " + token}
114120
continue
@@ -126,7 +132,8 @@ def execute(config, add_data, dostop):
126132
try:
127133
v = round(float(v), 2)
128134
except Exception as e:
129-
logging.error(f"Error rounding value for parameter '{name}': value='{v}', type={type(v).__name__}, error: {e}")
135+
logging.error(
136+
f"Error rounding value for parameter '{name}': value='{v}', type={type(v).__name__}, error: {e}")
130137
raise
131138
unit = get_parameter_unit('SENSORS_EVCHARGER', name)
132139
if unit:
@@ -141,7 +148,8 @@ def execute(config, add_data, dostop):
141148
try:
142149
v = round(float(v), 2)
143150
except Exception as e:
144-
logging.error(f"Error rounding value for parameter '{name}[{idx}]': value='{v}', type={type(v).__name__}, error: {e}")
151+
logging.error(
152+
f"Error rounding value for parameter '{name}[{idx}]': value='{v}', type={type(v).__name__}, error: {e}")
145153
raise
146154
idxname = dname + "." + str(idx + 1)
147155
unit = get_parameter_unit('SENSORS_EVCHARGER', name)
@@ -150,7 +158,8 @@ def execute(config, add_data, dostop):
150158
else:
151159
add_data(idxname, v)
152160
else:
153-
logging.debug(f"value of {name} is currently not availably (nighttime?)")
161+
logging.debug(
162+
f"value of {name} is currently not availably (nighttime?)")
154163
pass
155164

156165
time.sleep(int(config.get('behavior', 'updateFreq')))
@@ -309,7 +318,7 @@ def execute(config, add_data, dostop):
309318
'name': "Reactive power",
310319
'device_class': "reactive_power",
311320
'icon': "mdi:home-lightning-bolt-outline",
312-
'unit_of_measurement': "VAR",
321+
'unit_of_measurement': "var",
313322
'state_class': "measurement",
314323
'suggested_display_precision': 2,
315324
},

plugins/sources/TripowerX/tripowerx.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ def execute(config, add_data, dostop):
662662
'enabled': "false",
663663
'name': "Reactive power",
664664
'suggested_display_precision': 2,
665-
'unit_of_measurement': "VAR",
665+
'unit_of_measurement': "var",
666666
'device_class': "reactive_power",
667667
'state_class': "measurement",
668668
'icon': "mdi:home-lightning-bolt-outline",
@@ -722,7 +722,7 @@ def execute(config, add_data, dostop):
722722
'enabled': "false",
723723
'name': "Phase 1 reactive power",
724724
'suggested_display_precision': 2,
725-
'unit_of_measurement': "VAR",
725+
'unit_of_measurement': "var",
726726
'device_class': "reactive_power",
727727
'state_class': "measurement",
728728
'icon': "mdi:home-lightning-bolt-outline",
@@ -732,7 +732,7 @@ def execute(config, add_data, dostop):
732732
'enabled': "false",
733733
'name': "Phase 2 reactive power",
734734
'suggested_display_precision': 2,
735-
'unit_of_measurement': "VAR",
735+
'unit_of_measurement': "var",
736736
'device_class': "reactive_power",
737737
'state_class': "measurement",
738738
'icon': "mdi:home-lightning-bolt-outline",
@@ -742,7 +742,7 @@ def execute(config, add_data, dostop):
742742
'enabled': "false",
743743
'name': "Phase 3 reactive power",
744744
'suggested_display_precision': 2,
745-
'unit_of_measurement': "VAR",
745+
'unit_of_measurement': "var",
746746
'device_class': "reactive_power",
747747
'state_class': "measurement",
748748
'icon': "mdi:home-lightning-bolt-outline",

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ requires = ["flit_core >=3.8.0,<4"]
44

55
[project]
66
name = "smahub"
7-
version = "1.7.4"
7+
version = "1.7.5"
88
authors = [{ name = "Daniel Krippner", email = "dk.mailbox@gmx.net" }]
99
description = "Little daemon that runs plugins for collecting data from SMA PV products, and publishes to eg MQTT via other plugins."
1010
readme = "README.md"
@@ -14,7 +14,7 @@ classifiers = [
1414
"License :: OSI Approved :: GNU General Public License v2 (GPLv2)",
1515
"Natural Language :: English",
1616
"Operating System :: OS Independent",
17-
"Programming Language :: Python :: 3.8",
17+
"Programming Language :: Python :: 3.10",
1818
]
1919
dependencies = [
2020
"debugpy ~=1.8",

0 commit comments

Comments
 (0)