Skip to content

Commit c522869

Browse files
committed
explicit error message when exporting with relative import
1 parent 93bac55 commit c522869

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

nbdev/maker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def make_code_cells(*ss): return dict2nb({'cells':L(ss).map(mk_cell)}).cells
111111
# %% ../nbs/api/02_maker.ipynb #a2546836
112112
def relative_import(name, fname, level=0):
113113
"Convert a module `name` to a name relative to `fname`"
114-
assert not level
114+
if level: raise ValueError(f"nbdev export does not support relative imports: module={name}, export_path={fname}")
115115
sname = name.replace('.','/')
116116
if not(os.path.commonpath([sname,fname])): return name
117117
rel = os.path.relpath(sname, fname)

nbs/api/02_maker.ipynb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@
350350
"#| export\n",
351351
"def relative_import(name, fname, level=0):\n",
352352
" \"Convert a module `name` to a name relative to `fname`\"\n",
353-
" assert not level\n",
353+
" if level: raise ValueError(f\"nbdev export does not support relative imports: module={name}, export_path={fname}\")\n",
354354
" sname = name.replace('.','/')\n",
355355
" if not(os.path.commonpath([sname,fname])): return name\n",
356356
" rel = os.path.relpath(sname, fname)\n",
@@ -817,6 +817,9 @@
817817
}
818818
],
819819
"metadata": {
820+
"language_info": {
821+
"name": "python"
822+
},
820823
"solveit_dialog_mode": "learning",
821824
"solveit_ver": 2
822825
},

0 commit comments

Comments
 (0)