add new checker: negative-positive

Author: ccoVeille

CONTRIBUTING.md

@@ -21,12 +21,12 @@ package checkers
 
 // Zero detects situations like
 //
-//	assert.Equal(t, 0, count) 
+//	assert.Equal(t, 0, count)
 //	assert.Equal(t, nil, userObj)
 //
 // and requires
 //
-//	assert.Zero(t, count) 
+//	assert.Zero(t, count)
 //	assert.Zero(t, userObj)
 type Zero struct{}
 
@@ -41,8 +41,8 @@ The above code is enough to satisfy the `checkers.Checker` interface.
 
 The earlier the checker is in [the registry](internal/checkers/checkers_registry.go), the more priority it is.
 
-For example, the `zero` checker takes precedence over the `expected-actual` or `empty`, 
-because its check is more "narrow" and when you fix the warning from `zero`, 
+For example, the `zero` checker takes precedence over the `expected-actual` or `empty`,
+because its check is more "narrow" and when you fix the warning from `zero`,
 the rest of the checkers will become irrelevant.
 
 ```go
@@ -89,7 +89,7 @@ FAIL
 
 ### 7) Implement the checker
 
-`Zero` is an example of [checkers.RegularChecker](./internal/checkers/checker.go) because it works with "general" 
+`Zero` is an example of [checkers.RegularChecker](./internal/checkers/checker.go) because it works with "general"
 assertion call. For more complex checkers, use the [checkers.AdvancedChecker](./internal/checkers/checker.go) interface.
 
 If the checker turns out to be too “fat”, then you can omit some obviously rare combinations,
@@ -130,7 +130,6 @@ Describe a new checker in [checkers section](./README.md#checkers).
 - [float-compare](#float-compare)
 - [http-const](#http-const)
 - [http-sugar](#http-sugar)
-- [negative-positive](#negative-positive)
 - [no-fmt-mess](#no-fmt-mess)
 - [require-len](#require-len)
 - [suite-run](#suite-run)
@@ -229,7 +228,7 @@ func (s *ServiceIntegrationSuite) TearDownTest() {
      assert.GreaterOrEqual(t, a, 42.42)
      assert.Less(t, a, 42.42)
      assert.LessOrEqual(t, a, 42.42)
-    
+
      assert.True(t, a != 42.42) // assert.False(t, a == 42.42)
      assert.True(t, a > 42.42)  // assert.False(t, a <= 42.42)
      assert.True(t, a >= 42.42) // assert.False(t, a < 42.42)
@@ -283,7 +282,7 @@ And similar idea for `assert.InEpsilonSlice` / `assert.InDeltaSlice`.
 ```go
 ❌   assert.HTTPStatusCode(t,
          handler, http.MethodGet, "/index", nil, http.StatusOK)
-     assert.HTTPStatusCode(t, 
+     assert.HTTPStatusCode(t,
          handler, http.MethodGet, "/admin", nil, http.StatusNotFound)
      assert.HTTPStatusCode(t,
          handler, http.MethodGet, "/oauth", nil, http.StatusFound)
@@ -300,23 +299,6 @@ And similar idea for `assert.InEpsilonSlice` / `assert.InDeltaSlice`.
 
 ---
 
-### negative-positive
-
-```go
-❌   assert.Less(t, val, 0)
-     assert.Greater(t, val, 0)
-
-✅   assert.Negative(t, val)
-     assert.Positive(t, val)
-```
-
-**Autofix**: true. <br>
-**Enabled by default**: maybe? <br>
-**Reason**: More appropriate `testify` API with clearer failure message. <br>
-**Related issues**: [#76](https://github.com/Antonboom/testifylint/issues/76)
-
----
-
 ### no-fmt-mess
 
 **Autofix**: true. <br>
@@ -330,7 +312,7 @@ func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{})
 func Equalf(t TestingT, expected interface{}, actual interface{}, msg string, args ...interface{}) bool
 ```
 
-The f-functions [were added a long time ago](https://github.com/stretchr/testify/pull/356) to eliminate 
+The f-functions [were added a long time ago](https://github.com/stretchr/testify/pull/356) to eliminate
 `govet` [complain](https://go.googlesource.com/tools/+/refs/heads/release-branch.go1.12/go/analysis/passes/printf/printf.go?pli=1#506).
 
 This introduces some inconsistency into the test code, and the next strategies are seen for the checker:
@@ -343,7 +325,7 @@ This will make it easier to migrate to [v2](https://github.com/stretchr/testify/
 
 But it doesn't look like a "go way" and the `govet` won't be happy.
 
-2) IMHO, a more appropriate option is to disallow the use of `msgAndArgs` in non-f assertions. Look at 
+2) IMHO, a more appropriate option is to disallow the use of `msgAndArgs` in non-f assertions. Look at
 [the comment](https://github.com/stretchr/testify/issues/1089#issuecomment-1695059265).
 
 But there will be no non-stylistic benefits from the checker in this case (depends on the view of API in `v2`).
@@ -357,7 +339,7 @@ assert.Error(t, err, fmt.Sprintf("Profile %s should not be valid", test.profile)
 
 ### require-len
 
-The main idea: if code contains array/slice indexing, 
+The main idea: if code contains array/slice indexing,
 then before that there must be a length constraint through `require`.
 
 ```go
@@ -383,7 +365,7 @@ func (s *Suite) TestSomething() {
         // ...
         assert.Equal(t, "gopher", result)
     })
-	
+
     ✅
     s.Run("subtest1", func() {
         // ...

README.md

@@ -69,22 +69,24 @@ https://golangci-lint.run/usage/linters/#testifylint
 
 | Name                                                | Enabled By Default | Autofix |
 |-----------------------------------------------------|--------------------|---------|
-| [blank-import](#blank-import)                       | ✅                  | ❌       |
-| [bool-compare](#bool-compare)                       | ✅                  | ✅       |
-| [compares](#compares)                               | ✅                  | ✅       |
-| [empty](#empty)                                     | ✅                  | ✅       |
-| [error-is-as](#error-is-as)                         | ✅                  | ✅       |
-| [error-nil](#error-nil)                             | ✅                  | ✅       |
-| [expected-actual](#expected-actual)                 | ✅                  | ✅       |
-| [float-compare](#float-compare)                     | ✅                  | ❌       |
-| [go-require](#go-require)                           | ✅                  | ❌       |
-| [len](#len)                                         | ✅                  | ✅       |
-| [nil-compare](#nil-compare)                         | ✅                  | ✅       |
-| [require-error](#require-error)                     | ✅                  | ❌       |
-| [suite-dont-use-pkg](#suite-dont-use-pkg)           | ✅                  | ✅       |
-| [suite-extra-assert-call](#suite-extra-assert-call) | ✅                  | ✅       |
-| [suite-thelper](#suite-thelper)                     | ❌                  | ✅       |
-| [useless-assert](#useless-assert)                   | ✅                  | ❌       |
+| [blank-import](#blank-import)                       | ✅                 | ❌      |
+| [bool-compare](#bool-compare)                       | ✅                 | ✅      |
+| [compares](#compares)                               | ✅                 | ✅      |
+| [empty](#empty)                                     | ✅                 | ✅      |
+| [error-is-as](#error-is-as)                         | ✅                 | ✅      |
+| [error-nil](#error-nil)                             | ✅                 | ✅      |
+| [error-nil](#error-nil)                             | ✅                 | ✅      |
+| [expected-actual](#expected-actual)                 | ✅                 | ✅      |
+| [float-compare](#float-compare)                     | ✅                 | ❌      |
+| [go-require](#go-require)                           | ✅                 | ❌      |
+| [len](#len)                                         | ✅                 | ✅      |
+| [negative-positive](#negative-positive)             | ✅                 | ✅      |
+| [nil-compare](#nil-compare)                         | ✅                 | ✅      |
+| [require-error](#require-error)                     | ✅                 | ❌      |
+| [suite-dont-use-pkg](#suite-dont-use-pkg)           | ✅                 | ✅      |
+| [suite-extra-assert-call](#suite-extra-assert-call) | ✅                 | ✅      |
+| [suite-thelper](#suite-thelper)                     | ❌                 | ✅      |
+| [useless-assert](#useless-assert)                   | ✅                 | ❌      |
 
 > ⚠️ Also look at open for contribution [checkers](CONTRIBUTING.md#open-for-contribution)
 
@@ -124,7 +126,7 @@ import (
      assert.EqualValues(t, false, result)
      assert.Exactly(t, false, result)
      assert.NotEqual(t, true, result)
-     assert.NotEqualValues(t, true, result) 
+     assert.NotEqualValues(t, true, result)
      assert.False(t, !result)
      assert.True(t, result == true)
      // And other variations...
@@ -229,7 +231,7 @@ To turn off this behavior use the `--bool-compare.ignore-custom-types` flag.
 **Reason**: In the first two cases, a common mistake that leads to hiding the incorrect wrapping of sentinel errors.
 In the rest cases – more appropriate `testify` API with clearer failure message.
 
-Also `error-is-as` repeats `go vet`'s [errorsas check](https://cs.opensource.google/go/x/tools/+/master:go/analysis/passes/errorsas/errorsas.go) 
+Also `error-is-as` repeats `go vet`'s [errorsas check](https://cs.opensource.google/go/x/tools/+/master:go/analysis/passes/errorsas/errorsas.go)
 logic, but without autofix.
 
 ---
@@ -305,7 +307,7 @@ It is planned [to change the order of assertion arguments](https://github.com/st
      assert.Exactly(t, 42.42, result)
      assert.True(t, result == 42.42)
      assert.False(t, result != 42.42)
-	
+
 ✅   assert.InEpsilon(t, 42.42, result, 0.0001) // Or assert.InDelta
 ```
 
@@ -323,7 +325,7 @@ This checker is similar to the [floatcompare](https://github.com/golangci/golang
 go func() {
     conn, err = lis.Accept()
     require.NoError(t, err) ❌
-    
+
     if assert.Error(err) {
         assert.FailNow(t, msg) ❌
     }
@@ -337,7 +339,7 @@ go func() {
 This checker is a radically improved analogue of `go vet`'s
 [testinggoroutine](https://cs.opensource.google/go/x/tools/+/master:go/analysis/passes/testinggoroutine/doc.go) check.
 
-The point of the check is that, according to the [documentation](https://pkg.go.dev/testing#T), 
+The point of the check is that, according to the [documentation](https://pkg.go.dev/testing#T),
 functions leading to `t.FailNow` (essentially to `runtime.GoExit`) must only be used in the goroutine that runs the test.
 Otherwise, they will not work as declared, namely, finish the test function.
 
@@ -376,6 +378,24 @@ P.S. Related `testify`'s [thread](https://github.com/stretchr/testify/issues/772
 
 ---
 
+### negative-positive
+
+```go
+❌   assert.Less(t, val, 0)
+     assert.Greater(t, 0, val)
+     assert.Less(t, val, 0)
+     assert.Greater(t, 0, val)
+
+✅   assert.Negative(t, val)
+     assert.Positive(t, val)
+```
+
+**Autofix**: true. <br>
+**Enabled by default**: true <br>
+**Reason**: More appropriate `testify` API with clearer failure message.
+
+---
+
 ### nil-compare
 
 ```go
@@ -433,7 +453,7 @@ The best option here is to just use `Nil` / `NotNil` (see [details](https://gith
 **Enabled by default**: true. <br>
 **Reason**: Such "ignoring" of errors leads to further panics, making the test harder to debug.
 
-[testify/require](https://pkg.go.dev/github.com/stretchr/testify@master/require#hdr-Assertions) allows 
+[testify/require](https://pkg.go.dev/github.com/stretchr/testify@master/require#hdr-Assertions) allows
 to stop test execution when a test fails.
 
 By default `require-error` only checks the `*Error*` assertions, presented above. <br>
@@ -484,7 +504,7 @@ But sometimes, on the contrary, people want consistency with `s.Assert()` and `s
 ```go
 func (s *MySuite) TestSomething() {
      // ...
- 
+
      ❌
      s.Require().NoError(err)
      s.Equal(42, value)

analyzer/checkers_factory_test.go

@@ -19,6 +19,7 @@ func Test_newCheckers(t *testing.T) {
 		checkers.NewEmpty(),
 		checkers.NewLen(),
 		checkers.NewCompares(),
+		checkers.NewNegativePositive(),
 		checkers.NewErrorNil(),
 		checkers.NewNilCompare(),
 		checkers.NewErrorIsAs(),
@@ -33,6 +34,7 @@ func Test_newCheckers(t *testing.T) {
 		checkers.NewEmpty(),
 		checkers.NewLen(),
 		checkers.NewCompares(),
+		checkers.NewNegativePositive(),
 		checkers.NewErrorNil(),
 		checkers.NewNilCompare(),
 		checkers.NewErrorIsAs(),

analyzer/testdata/src/checkers-default/negative-positive/negative_positive_test.go

@@ -0,0 +1,53 @@
+// Code generated by testifylint/internal/testgen. DO NOT EDIT.
+
+package negativepositive
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNegativePositiveChecker(t *testing.T) {
+	var a int
+
+	// Invalid.
+	{
+		assert.Positive(t, a)                                   // want "negative-positive: use assert\\.Positive"
+		assert.Positivef(t, a, "msg with args %d %s", 42, "42") // want "negative-positive: use assert\\.Positivef"
+		assert.Negative(t, a)                                   // want "negative-positive: use assert\\.Negative"
+		assert.Negativef(t, a, "msg with args %d %s", 42, "42") // want "negative-positive: use assert\\.Negativef"
+		assert.Negative(t, a)                                   // want "negative-positive: use assert\\.Negative"
+		assert.Negativef(t, a, "msg with args %d %s", 42, "42") // want "negative-positive: use assert\\.Negativef"
+		assert.Positive(t, a)                                   // want "negative-positive: use assert\\.Positive"
+		assert.Positivef(t, a, "msg with args %d %s", 42, "42") // want "negative-positive: use assert\\.Positivef"
+	}
+
+	// Valid.
+	{
+		assert.Greater(t, 1, a)
+		assert.Greaterf(t, 1, a, "msg with args %d %s", 42, "42")
+		assert.Less(t, 1, a)
+		assert.Lessf(t, 1, a, "msg with args %d %s", 42, "42")
+	}
+
+	// Ignored.
+	{
+		assert.Greater(t, 1, a)
+		assert.Greaterf(t, 1, a, "msg with args %d %s", 42, "42")
+		assert.Greater(t, 0, 0)
+		assert.Greaterf(t, 0, 0, "msg with args %d %s", 42, "42")
+		assert.GreaterOrEqual(t, 0, a)
+		assert.GreaterOrEqualf(t, 0, a, "msg with args %d %s", 42, "42")
+		assert.GreaterOrEqual(t, a, 0)
+		assert.GreaterOrEqualf(t, a, 0, "msg with args %d %s", 42, "42")
+		assert.Less(t, 1, a)
+		assert.Lessf(t, 1, a, "msg with args %d %s", 42, "42")
+		assert.Less(t, 0, 0)
+		assert.Lessf(t, 0, 0, "msg with args %d %s", 42, "42")
+		assert.LessOrEqual(t, 0, a)
+		assert.LessOrEqualf(t, 0, a, "msg with args %d %s", 42, "42")
+		assert.LessOrEqual(t, a, 0)
+		assert.LessOrEqualf(t, a, 0, "msg with args %d %s", 42, "42")
+	}
+}

analyzer/testdata/src/checkers-default/negative-positive/negative_positive_test.go.golden

@@ -12,6 +12,7 @@ var registry = checkersRegistry{
 	{factory: asCheckerFactory(NewEmpty), enabledByDefault: true},
 	{factory: asCheckerFactory(NewLen), enabledByDefault: true},
 	{factory: asCheckerFactory(NewCompares), enabledByDefault: true},
+	{factory: asCheckerFactory(NewNegativePositive), enabledByDefault: true},
 	{factory: asCheckerFactory(NewErrorNil), enabledByDefault: true},
 	{factory: asCheckerFactory(NewNilCompare), enabledByDefault: true},
 	{factory: asCheckerFactory(NewErrorIsAs), enabledByDefault: true},

internal/checkers/checkers_registry.go

@@ -40,6 +40,7 @@ func TestAll(t *testing.T) {
 		"empty",
 		"len",
 		"compares",
+		"negative-positive",
 		"error-nil",
 		"nil-compare",
 		"error-is-as",
@@ -70,6 +71,7 @@ func TestEnabledByDefault(t *testing.T) {
 		"empty",
 		"len",
 		"compares",
+		"negative-positive",
 		"error-nil",
 		"nil-compare",
 		"error-is-as",