Go 1.24 (#234)

Author: Antonboom

.github/workflows/ci.yml

@@ -8,8 +8,8 @@ on:
     branches: [ master ]
 
 env:
-  GO_VERSION: ^1.23
-  GOLANGCI_LINT_VERSION: v1.61.0
+  GO_VERSION: ^1.24
+  GOLANGCI_LINT_VERSION: v1.64.7
 
 permissions:
   contents: read

.golangci.yml

@@ -103,10 +103,13 @@ linters:
     - asasalint
     - asciicheck
     - bidichk
+    - copyloopvar
     - depguard
+    - durationcheck
     - errcheck
     - errname
     - exhaustive
+    - exptostd
     - forbidigo
     - gci
     - gocheckcompilerdirectives
@@ -120,27 +123,30 @@ linters:
     - gosimple
     - govet
     - ineffassign
+    - intrange
     - lll
     - makezero
     - mirror
     - misspell
     - nakedret
     - nilerr
+    - nilnesserr
     - nestif
     - nolintlint
+    - perfsprint
     - prealloc
     - predeclared
     - reassign
     - revive
     - staticcheck
     - stylecheck
-    - tenv
     - testableexamples
     - testpackage
     - thelper
     - unconvert
     - unparam
     - unused
     - usestdlibvars
+    - usetesting
     - wastedassign
     - whitespace

analyzer/analyzer_test.go

@@ -14,8 +14,6 @@ func TestTestifyLint(t *testing.T) {
 	t.Parallel()
 
 	for _, checker := range checkers.All() {
-		checker := checker
-
 		t.Run(checker, func(t *testing.T) {
 			t.Parallel()
 
@@ -176,8 +174,6 @@ func TestTestifyLint_NotDefaultCases(t *testing.T) {
 	}
 
 	for _, tt := range cases {
-		tt := tt
-
 		t.Run(tt.dir, func(t *testing.T) {
 			t.Parallel()
 

analyzer/testdata/src/debug/suite_method_signature_test.go

@@ -27,7 +27,8 @@ func (s *BrokenSuite) TestTypo(_ *testing.T) { // value.go:424: test panicked: r
 
 /*
 1) Flagged by govet (copylocks).
-2) Related to https://github.com/go-critic/go-critic/issues/331.
+2) Flagged by https://golangci-lint.run/usage/linters/#recvcheck.
+3) Related to https://github.com/go-critic/go-critic/issues/331.
 */
 func (s BrokenSuite) TestValueReceiver() {
 	s.True(true)

go.mod

@@ -1,10 +1,12 @@
 module github.com/Antonboom/testifylint
 
-go 1.22.1
+go 1.23.0
 
-require golang.org/x/tools v0.29.0
+toolchain go1.24.1
+
+require golang.org/x/tools v0.31.0
 
 require (
-	golang.org/x/mod v0.22.0 // indirect
-	golang.org/x/sync v0.10.0 // indirect
+	golang.org/x/mod v0.24.0 // indirect
+	golang.org/x/sync v0.12.0 // indirect
 )

go.sum

@@ -1,8 +1,8 @@
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
-golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4=
-golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
-golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
-golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
-golang.org/x/tools v0.29.0 h1:Xx0h3TtM9rzQpQuR4dKLrdglAmCEN5Oi+P74JdhdzXE=
-golang.org/x/tools v0.29.0/go.mod h1:KMQVMRsVxU6nHCFXrBPhDB8XncLNLM0lIy/F14RP588=
+golang.org/x/mod v0.24.0 h1:ZfthKaKaT4NrhGVZHO1/WDTwGES4De8KtWO0SIbNJMU=
+golang.org/x/mod v0.24.0/go.mod h1:IXM97Txy2VM4PJ3gI61r1YEk/gAj6zAHN3AdZt6S9Ww=
+golang.org/x/sync v0.12.0 h1:MHc5BpPuC30uJk597Ri8TV3CNZcTLu6B6z4lJy+g6Jw=
+golang.org/x/sync v0.12.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
+golang.org/x/tools v0.31.0 h1:0EedkvKDbh+qistFTd0Bcwe/YLh4vHwWEkiI0toFIBU=
+golang.org/x/tools v0.31.0/go.mod h1:naFTU+Cev749tSJRXJlna0T3WxKvb1kWEx15xA4SdmQ=

internal/checkers/formatter.go

@@ -230,7 +230,7 @@ func assertHasFormattedAnalogue(pass *analysis.Pass, call *CallMeta) bool {
 	if !ok {
 		return false
 	}
-	for i := 0; i < suite.NumMethods(); i++ {
+	for i := range suite.NumMethods() {
 		if suite.Method(i).Name() == call.Fn.Name+"f" {
 			return true
 		}
@@ -256,7 +256,7 @@ func getMsgAndArgsPosition(sig *types.Signature) int {
 }
 
 func getMsgPosition(sig *types.Signature) int {
-	for i := 0; i < sig.Params().Len(); i++ {
+	for i := range sig.Params().Len() {
 		param := sig.Params().At(i)
 
 		if b, ok := param.Type().(*types.Basic); ok && b.Kind() == types.String && (param.Name() == "msg" ||

internal/checkers/helpers_http.go

@@ -24,7 +24,7 @@ func mimicHTTPHandler(pass *analysis.Pass, fType *ast.FuncType) bool {
 		return false
 	}
 
-	for i := 0; i < sig.Params().Len(); i++ {
+	for i := range sig.Params().Len() {
 		lhs := sig.Params().At(i).Type()
 		rhs := pass.TypesInfo.TypeOf(fType.Params.List[i].Type)
 		if !types.Identical(lhs, rhs) {

internal/checkers/suite_thelper.go

@@ -43,7 +43,7 @@ func (checker SuiteTHelper) Check(pass *analysis.Pass, inspector *inspector.Insp
 		}
 		rcvName := rcv.Names[0].Name
 
-		helperCallStr := fmt.Sprintf("%s.T().Helper()", rcvName)
+		helperCallStr := rcvName + ".T().Helper()"
 
 		firstStmt := fd.Body.List[0]
 		if analysisutil.NodeString(pass.Fset, firstStmt) == helperCallStr {

internal/testgen/gen_negative_positive.go

@@ -25,8 +25,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 	for _, zeroType := range []string{
 		"", "int", "int8", "int16", "int32", "int64",
 	} {
-		v := fmt.Sprintf("%s(a)", zeroType)
-		zero := fmt.Sprintf("%s(0)", zeroType)
+		v := zeroType + "(a)"
+		zero := zeroType + "(0)"
 
 		if zeroType == "" {
 			v, zero = "a", "0"
@@ -46,8 +46,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 		"", "int", "int8", "int16", "int32", "int64",
 		"uint", "uint8", "uint16", "uint32", "uint64",
 	} {
-		v := fmt.Sprintf("%s(a)", zeroType)
-		zero := fmt.Sprintf("%s(0)", zeroType)
+		v := zeroType + "(a)"
+		zero := zeroType + "(0)"
 
 		if zeroType == "" {
 			v, zero = "a", "0"
@@ -85,8 +85,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 			"uint", "uint8", "uint16", "uint32", "uint64",
 			"CustomInt16",
 		} {
-			v := fmt.Sprintf("%s(a)", zeroType)
-			zero := fmt.Sprintf("%s(0)", zeroType)
+			v := zeroType + "(a)"
+			zero := zeroType + "(0)"
 
 			ignoredAssertions = append(ignoredAssertions,
 				Assertion{Fn: fn, Argsf: zero + ", " + v},
@@ -120,8 +120,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 		"uint", "uint8", "uint16", "uint32", "uint64",
 		"CustomInt16",
 	} {
-		v := fmt.Sprintf("%s(a)", zeroType)
-		zero := fmt.Sprintf("%s(0)", zeroType)
+		v := zeroType + "(a)"
+		zero := zeroType + "(0)"
 
 		if zeroType == "" {
 			v, zero = "a", "0"
@@ -140,8 +140,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 		"uint", "uint8", "uint16", "uint32", "uint64",
 		"CustomInt16",
 	} {
-		v := fmt.Sprintf("%s(a)", zeroType)
-		zero := fmt.Sprintf("%s(0)", zeroType)
+		v := zeroType + "(a)"
+		zero := zeroType + "(0)"
 
 		if zeroType == "" {
 			v, zero = "a", "0"
@@ -160,8 +160,8 @@ func (g NegativePositiveTestsGenerator) TemplateData() any {
 		"uint", "uint8", "uint16", "uint32", "uint64",
 		"CustomInt16",
 	} {
-		v := fmt.Sprintf("%s(a)", zeroType)
-		zero := fmt.Sprintf("%s(0)", zeroType)
+		v := zeroType + "(a)"
+		zero := zeroType + "(0)"
 
 		ignoredAssertions = append(ignoredAssertions,
 			Assertion{Fn: "Less", Argsf: v + ", " + zero},